From: "J. Bruce Fields" <bfields@fieldses.org>
To: Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc: "J. Bruce Fields" <bfields@redhat.com>,
linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v1 05/13] NFS skip recovery of copy open on dest server
Date: Thu, 1 Nov 2018 17:24:41 -0400 [thread overview]
Message-ID: <20181101212441.GE12930@fieldses.org> (raw)
In-Reply-To: <CAN-5tyF08cLZAtPivj7t_f94HgY7mC3zBh=vp0E8Ez-GQhL7RA@mail.gmail.com>
On Thu, Nov 01, 2018 at 04:38:43PM -0400, Olga Kornievskaia wrote:
> On Thu, Nov 1, 2018 at 4:20 PM J. Bruce Fields <bfields@fieldses.org> wrote:
> >
> > On Fri, Oct 19, 2018 at 11:28:57AM -0400, Olga Kornievskaia wrote:
> > > From: Olga Kornievskaia <kolga@netapp.com>
> > >
> > > Mark the open created for the source file on the destination
> > > server. Then if this open is going thru a recovery, then fail
> > > the recovery as we don't need to be recoving a "fake" open.
> > > We need to fail the ongoing READs and vfs_copy_file_range().
> >
> > Nothing to do with this patch, really, but:
>
> And because it not related to this patch, then I'm confused.
>
> > I'm not always a stickler about the 80-character-column rule, but, man,
> > nfs4_reclaim_open_state is deeply nested, could that be broken up a
> > little?
>
> really? it's nested? Anna reworked the reclaim state code and nesting
> has gone done considerably. It's only 2 tabs in?
>
> > Also I notice there's a printk("AGLO: ...") in there that you
> > probably didn't mean to leave upstream?
>
> I don't believe I've ever had a printk() in the code. I did have a
> leftover dprintk() and that has since been removed.
Oh, I see, this was all fixed recently upstream by Anna's cb7a8384dc02
"NFS: Split out the body of nfs4_reclaim_open_state()", ignore me.
--b.
next prev parent reply other threads:[~2018-11-01 21:24 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 15:28 [PATCH v1 00/13] server-side support for "inter" SSC copy Olga Kornievskaia
2018-10-19 15:28 ` [PATCH v1 01/13] fs: Don't copy beyond the end of the file Olga Kornievskaia
2018-10-31 16:54 ` J. Bruce Fields
2018-10-31 17:07 ` Olga Kornievskaia
2018-10-31 17:54 ` J. Bruce Fields
2018-10-31 18:01 ` Olga Kornievskaia
2018-10-31 18:29 ` J. Bruce Fields
2018-10-19 15:28 ` [PATCH v1 02/13] VFS permit cross device vfs_copy_file_range Olga Kornievskaia
2018-10-19 15:28 ` [PATCH v1 03/13] NFS NFSD defining nl4_servers structure needed by both Olga Kornievskaia
2018-10-19 15:28 ` [PATCH v1 04/13] NFS inter ssc open Olga Kornievskaia
2018-10-31 18:40 ` J. Bruce Fields
2018-10-31 18:54 ` Olga Kornievskaia
2018-11-01 20:12 ` J. Bruce Fields
2018-11-01 20:30 ` Olga Kornievskaia
2018-10-19 15:28 ` [PATCH v1 05/13] NFS skip recovery of copy open on dest server Olga Kornievskaia
2018-11-01 20:19 ` J. Bruce Fields
2018-11-01 20:38 ` Olga Kornievskaia
2018-11-01 21:24 ` J. Bruce Fields [this message]
2018-10-19 15:28 ` [PATCH v1 06/13] NFSD fill-in netloc4 structure Olga Kornievskaia
2018-11-01 20:37 ` J. Bruce Fields
2018-11-01 20:55 ` Olga Kornievskaia
2018-10-19 15:28 ` [PATCH v1 07/13] NFSD add ca_source_server<> to COPY Olga Kornievskaia
2018-11-01 20:48 ` J. Bruce Fields
2018-11-01 21:00 ` Olga Kornievskaia
2018-11-02 13:53 ` J. Bruce Fields
2018-11-02 14:03 ` J. Bruce Fields
2018-11-02 16:36 ` Olga Kornievskaia
2018-11-02 15:46 ` J. Bruce Fields
2018-11-02 16:35 ` Olga Kornievskaia
2018-11-02 16:49 ` J. Bruce Fields
2018-11-02 17:04 ` Olga Kornievskaia
2018-10-19 15:29 ` [PATCH v1 08/13] NFSD return nfs4_stid in nfs4_preprocess_stateid_op Olga Kornievskaia
2018-11-02 19:05 ` J. Bruce Fields
2018-11-02 19:25 ` Olga Kornievskaia
2018-11-02 19:53 ` J. Bruce Fields
2018-10-19 15:29 ` [PATCH v1 09/13] NFSD add COPY_NOTIFY operation Olga Kornievskaia
2018-11-05 17:50 ` J. Bruce Fields
2018-11-08 18:29 ` Olga Kornievskaia
2018-11-08 18:46 ` J. Bruce Fields
2018-10-19 15:29 ` [PATCH v1 10/13] NFSD check stateids against copy stateids Olga Kornievskaia
2018-11-05 21:33 ` J. Bruce Fields
2018-11-08 18:43 ` Olga Kornievskaia
2018-10-19 15:29 ` [PATCH v1 11/13] NFSD generalize nfsd4_compound_state flag names Olga Kornievskaia
2018-10-19 15:29 ` [PATCH v1 12/13] NFSD: allow inter server COPY to have a STALE source server fh Olga Kornievskaia
2018-11-07 18:57 ` J. Bruce Fields
2018-11-08 18:51 ` Olga Kornievskaia
2018-11-08 19:25 ` J. Bruce Fields
2018-11-08 19:27 ` J. Bruce Fields
2018-11-08 19:31 ` Olga Kornievskaia
2018-11-08 19:32 ` Olga Kornievskaia
2018-10-19 15:29 ` [PATCH v1 13/13] NFSD add nfs4 inter ssc to nfsd4_copy Olga Kornievskaia
2018-11-07 21:48 ` J. Bruce Fields
2018-11-08 19:16 ` Olga Kornievskaia
2018-11-09 16:23 ` J. Bruce Fields
2018-10-25 16:07 ` [PATCH v1 00/13] server-side support for "inter" SSC copy J. Bruce Fields
2018-10-29 17:54 ` Olga Kornievskaia
2018-10-29 20:53 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101212441.GE12930@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=olga.kornievskaia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.