From: Greg KH <gregkh@linuxfoundation.org>
To: Ioannis Valasakis <code@wizofe.uk>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 4/5] staging: greybus Match with open parentheses
Date: Fri, 2 Nov 2018 05:53:00 +0100 [thread overview]
Message-ID: <20181102045300.GA11843@kroah.com> (raw)
In-Reply-To: <202cacec28435d2bb33fa9873f8fef9e451dada7.1541123999.git.code@wizofe.uk>
On Fri, Nov 02, 2018 at 02:04:49AM +0000, Ioannis Valasakis wrote:
> Fix the arguments by open parentheses
> Reported by checkpatch.
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
> drivers/staging/greybus/control.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
> index 9c453e0b1b33..08a51c652a10 100644
> --- a/drivers/staging/greybus/control.h
> +++ b/drivers/staging/greybus/control.h
> @@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
> int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
> int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
> int gb_control_disconnecting_operation(struct gb_control *control,
> - u16 cport_id);
> + u17 cport_id);
I don't think you built this code :(
next prev parent reply other threads:[~2018-11-02 4:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 2:00 [PATCH 0/5] staging: greybus Various stylistic errors Ioannis Valasakis
2018-11-02 2:02 ` [PATCH 1/5] staging: greybus Fix styling, parenthesis matching Ioannis Valasakis
2018-11-02 7:15 ` [Outreachy kernel] " Julia Lawall
2018-11-02 10:06 ` Ioannis Valasakis
2018-11-02 2:02 ` [PATCH 2/5] staging: greybus Change comparison to NULL Ioannis Valasakis
2018-11-02 7:10 ` [Outreachy kernel] " Julia Lawall
2018-11-02 2:04 ` [PATCH 3/5] staging: greybus Add a blank line after declaration Ioannis Valasakis
2018-11-02 2:04 ` [PATCH 4/5] staging: greybus Match with open parentheses Ioannis Valasakis
2018-11-02 4:53 ` Greg KH [this message]
2018-11-02 12:25 ` Ioannis Valasakis
2018-11-02 12:43 ` [Outreachy kernel] " Julia Lawall
2018-11-02 14:31 ` Sasha Levin
2018-11-02 14:33 ` Ioannis Valasakis
2018-11-02 2:05 ` [PATCH 5/5] staging: greybus Fix SPDX identifier Ioannis Valasakis
2018-11-02 7:08 ` [Outreachy kernel] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102045300.GA11843@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=code@wizofe.uk \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.