* [PATCH v2] i2c: rk3x: fix some typo
@ 2018-11-06 12:01 ` Heiko Stuebner
0 siblings, 0 replies; 14+ messages in thread
From: Heiko Stuebner @ 2018-11-06 12:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi Yangtao, Peter,
Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee:
> I am sorry.
> -- Yangtao
If anything, it is me that should be sorry, as I did suggest the
patch description, including the new spelling error.
And it took me like the whole weekend to actually realize where the
Calculated / Calculates error was hiding ;-) .
Heiko
> On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote:
> >
> > On 2018-11-02 13:45, Yangtao Li wrote:
> > > Fix multiple instances of a misspelled "Calculates".
> >
> > Yes, it sure is hard to spell "Calcluated," it's almost impossible to
> > get it completely right and not introduce another typo somewhere... :-)
> >
> > Cheers,
> > Peter
> >
> > >
> > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > > ---
> > > Changes in v2:
> > > -add commit message
> > > ---
> > > drivers/i2c/busses/i2c-rk3x.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> > > index b8a2728dd4b6..fe347e8e2a23 100644
> > > --- a/drivers/i2c/busses/i2c-rk3x.c
> > > +++ b/drivers/i2c/busses/i2c-rk3x.c
> > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed)
> > > *
> > > * @clk_rate: I2C input clock rate
> > > * @t: Known I2C timing information
> > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > *
> > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > * a best-effort divider value is returned in divs. If the target rate is
> > > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate,
> > > *
> > > * @clk_rate: I2C input clock rate
> > > * @t: Known I2C timing information
> > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > *
> > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > * a best-effort divider value is returned in divs. If the target rate is
> > >
> >
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] i2c: rk3x: fix some typo
2018-11-06 12:01 ` Heiko Stuebner
@ 2018-11-06 13:01 ` Frank Lee
-1 siblings, 0 replies; 14+ messages in thread
From: Frank Lee @ 2018-11-06 13:01 UTC (permalink / raw)
To: Heiko Stübner
Cc: peda, linux-arm-kernel, linux-rockchip, linux-i2c, linux-kernel
Hi Heiko：
please，correct it in the cimmit message.
--Yangtao
On Tue, Nov 6, 2018 at 8:01 PM Heiko Stuebner <heiko@sntech.de> wrote:
>
> Hi Yangtao, Peter,
>
> Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee:
> > I am sorry.
> > -- Yangtao
>
> If anything, it is me that should be sorry, as I did suggest the
> patch description, including the new spelling error.
>
> And it took me like the whole weekend to actually realize where the
> Calculated / Calculates error was hiding ;-) .
>
>
> Heiko
>
> > On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote:
> > >
> > > On 2018-11-02 13:45, Yangtao Li wrote:
> > > > Fix multiple instances of a misspelled "Calculates".
> > >
> > > Yes, it sure is hard to spell "Calcluated," it's almost impossible to
> > > get it completely right and not introduce another typo somewhere... :-)
> > >
> > > Cheers,
> > > Peter
> > >
> > > >
> > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > > > ---
> > > > Changes in v2:
> > > > -add commit message
> > > > ---
> > > > drivers/i2c/busses/i2c-rk3x.c | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> > > > index b8a2728dd4b6..fe347e8e2a23 100644
> > > > --- a/drivers/i2c/busses/i2c-rk3x.c
> > > > +++ b/drivers/i2c/busses/i2c-rk3x.c
> > > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed)
> > > > *
> > > > * @clk_rate: I2C input clock rate
> > > > * @t: Known I2C timing information
> > > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > > *
> > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > > * a best-effort divider value is returned in divs. If the target rate is
> > > > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate,
> > > > *
> > > > * @clk_rate: I2C input clock rate
> > > > * @t: Known I2C timing information
> > > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > > *
> > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > > * a best-effort divider value is returned in divs. If the target rate is
> > > >
> > >
> >
>
>
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2] i2c: rk3x: fix some typo
@ 2018-11-06 13:01 ` Frank Lee
0 siblings, 0 replies; 14+ messages in thread
From: Frank Lee @ 2018-11-06 13:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi Heiko?
please?correct it in the cimmit message.
--Yangtao
On Tue, Nov 6, 2018 at 8:01 PM Heiko Stuebner <heiko@sntech.de> wrote:
>
> Hi Yangtao, Peter,
>
> Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee:
> > I am sorry.
> > -- Yangtao
>
> If anything, it is me that should be sorry, as I did suggest the
> patch description, including the new spelling error.
>
> And it took me like the whole weekend to actually realize where the
> Calculated / Calculates error was hiding ;-) .
>
>
> Heiko
>
> > On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote:
> > >
> > > On 2018-11-02 13:45, Yangtao Li wrote:
> > > > Fix multiple instances of a misspelled "Calculates".
> > >
> > > Yes, it sure is hard to spell "Calcluated," it's almost impossible to
> > > get it completely right and not introduce another typo somewhere... :-)
> > >
> > > Cheers,
> > > Peter
> > >
> > > >
> > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > > > ---
> > > > Changes in v2:
> > > > -add commit message
> > > > ---
> > > > drivers/i2c/busses/i2c-rk3x.c | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> > > > index b8a2728dd4b6..fe347e8e2a23 100644
> > > > --- a/drivers/i2c/busses/i2c-rk3x.c
> > > > +++ b/drivers/i2c/busses/i2c-rk3x.c
> > > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed)
> > > > *
> > > > * @clk_rate: I2C input clock rate
> > > > * @t: Known I2C timing information
> > > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > > *
> > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > > * a best-effort divider value is returned in divs. If the target rate is
> > > > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate,
> > > > *
> > > > * @clk_rate: I2C input clock rate
> > > > * @t: Known I2C timing information
> > > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > > *
> > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > > * a best-effort divider value is returned in divs. If the target rate is
> > > >
> > >
> >
>
>
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] i2c: rk3x: fix some typo
2018-11-06 13:01 ` Frank Lee
@ 2018-11-06 13:02 ` Frank Lee
-1 siblings, 0 replies; 14+ messages in thread
From: Frank Lee @ 2018-11-06 13:02 UTC (permalink / raw)
To: Heiko Stübner, Yangtao Li
Cc: peda, linux-arm-kernel, linux-rockchip, linux-i2c, linux-kernel
add myself.
On Tue, Nov 6, 2018 at 9:01 PM Frank Lee <tiny.windzz@gmail.com> wrote:
>
> Hi Heiko：
>
> please，correct it in the cimmit message.
>
> --Yangtao
> On Tue, Nov 6, 2018 at 8:01 PM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> > Hi Yangtao, Peter,
> >
> > Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee:
> > > I am sorry.
> > > -- Yangtao
> >
> > If anything, it is me that should be sorry, as I did suggest the
> > patch description, including the new spelling error.
> >
> > And it took me like the whole weekend to actually realize where the
> > Calculated / Calculates error was hiding ;-) .
> >
> >
> > Heiko
> >
> > > On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote:
> > > >
> > > > On 2018-11-02 13:45, Yangtao Li wrote:
> > > > > Fix multiple instances of a misspelled "Calculates".
> > > >
> > > > Yes, it sure is hard to spell "Calcluated," it's almost impossible to
> > > > get it completely right and not introduce another typo somewhere... :-)
> > > >
> > > > Cheers,
> > > > Peter
> > > >
> > > > >
> > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > > > > ---
> > > > > Changes in v2:
> > > > > -add commit message
> > > > > ---
> > > > > drivers/i2c/busses/i2c-rk3x.c | 4 ++--
> > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> > > > > index b8a2728dd4b6..fe347e8e2a23 100644
> > > > > --- a/drivers/i2c/busses/i2c-rk3x.c
> > > > > +++ b/drivers/i2c/busses/i2c-rk3x.c
> > > > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed)
> > > > > *
> > > > > * @clk_rate: I2C input clock rate
> > > > > * @t: Known I2C timing information
> > > > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > > > *
> > > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > > > * a best-effort divider value is returned in divs. If the target rate is
> > > > > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate,
> > > > > *
> > > > > * @clk_rate: I2C input clock rate
> > > > > * @t: Known I2C timing information
> > > > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > > > *
> > > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > > > * a best-effort divider value is returned in divs. If the target rate is
> > > > >
> > > >
> > >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2] i2c: rk3x: fix some typo
@ 2018-11-06 13:02 ` Frank Lee
0 siblings, 0 replies; 14+ messages in thread
From: Frank Lee @ 2018-11-06 13:02 UTC (permalink / raw)
To: linux-arm-kernel
add myself.
On Tue, Nov 6, 2018 at 9:01 PM Frank Lee <tiny.windzz@gmail.com> wrote:
>
> Hi Heiko?
>
> please?correct it in the cimmit message.
>
> --Yangtao
> On Tue, Nov 6, 2018 at 8:01 PM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> > Hi Yangtao, Peter,
> >
> > Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee:
> > > I am sorry.
> > > -- Yangtao
> >
> > If anything, it is me that should be sorry, as I did suggest the
> > patch description, including the new spelling error.
> >
> > And it took me like the whole weekend to actually realize where the
> > Calculated / Calculates error was hiding ;-) .
> >
> >
> > Heiko
> >
> > > On Fri, Nov 2, 2018 at 8:58 PM Peter Rosin <peda@axentia.se> wrote:
> > > >
> > > > On 2018-11-02 13:45, Yangtao Li wrote:
> > > > > Fix multiple instances of a misspelled "Calculates".
> > > >
> > > > Yes, it sure is hard to spell "Calcluated," it's almost impossible to
> > > > get it completely right and not introduce another typo somewhere... :-)
> > > >
> > > > Cheers,
> > > > Peter
> > > >
> > > > >
> > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > > > > ---
> > > > > Changes in v2:
> > > > > -add commit message
> > > > > ---
> > > > > drivers/i2c/busses/i2c-rk3x.c | 4 ++--
> > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> > > > > index b8a2728dd4b6..fe347e8e2a23 100644
> > > > > --- a/drivers/i2c/busses/i2c-rk3x.c
> > > > > +++ b/drivers/i2c/busses/i2c-rk3x.c
> > > > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed)
> > > > > *
> > > > > * @clk_rate: I2C input clock rate
> > > > > * @t: Known I2C timing information
> > > > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > > > *
> > > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > > > * a best-effort divider value is returned in divs. If the target rate is
> > > > > @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate,
> > > > > *
> > > > > * @clk_rate: I2C input clock rate
> > > > > * @t: Known I2C timing information
> > > > > - * @t_calc: Caculated rk3x private timings that would be written into regs
> > > > > + * @t_calc: Calculated rk3x private timings that would be written into regs
> > > > > *
> > > > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case
> > > > > * a best-effort divider value is returned in divs. If the target rate is
> > > > >
> > > >
> > >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2] i2c: rk3x: fix some typo
2018-11-06 12:01 ` Heiko Stuebner
@ 2018-11-09 16:09 ` Wolfram Sang
-1 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2018-11-09 16:09 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Frank Lee, peda, linux-arm-kernel, linux-rockchip, linux-i2c,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
On Tue, Nov 06, 2018 at 01:01:33PM +0100, Heiko Stuebner wrote:
> Hi Yangtao, Peter,
>
> Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee:
> > I am sorry.
> > -- Yangtao
>
> If anything, it is me that should be sorry, as I did suggest the
> patch description, including the new spelling error.
>
> And it took me like the whole weekend to actually realize where the
> Calculated / Calculates error was hiding ;-) .
You guys are fun :) Anyhow, $subject is way too generic, that is the
real culprit here. I don't mind empty descriptions, so you can basically
move the message into the header.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2] i2c: rk3x: fix some typo
@ 2018-11-09 16:09 ` Wolfram Sang
0 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2018-11-09 16:09 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 06, 2018 at 01:01:33PM +0100, Heiko Stuebner wrote:
> Hi Yangtao, Peter,
>
> Am Montag, 5. November 2018, 16:59:58 CET schrieb Frank Lee:
> > I am sorry.
> > -- Yangtao
>
> If anything, it is me that should be sorry, as I did suggest the
> patch description, including the new spelling error.
>
> And it took me like the whole weekend to actually realize where the
> Calculated / Calculates error was hiding ;-) .
You guys are fun :) Anyhow, $subject is way too generic, that is the
real culprit here. I don't mind empty descriptions, so you can basically
move the message into the header.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181109/391a2489/attachment.sig>
^ permalink raw reply [flat|nested] 14+ messages in thread