All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libv4l: needs kernel headers >= 3.18
Date: Fri, 2 Nov 2018 15:19:58 +0100	[thread overview]
Message-ID: <20181102151958.23d16ccc@gmx.net> (raw)
In-Reply-To: <20181102133521.2297-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Fri,  2 Nov 2018 14:35:21 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Bump to version 1.16.1 added a dependency to bpf headers:
> https://git.linuxtv.org/v4l-utils.git/commit/?id=d6025b0e8c7f57b0f9390f987acc5eed57360d80
> 
> BPF headers are available since kernel 3.18:
> https://github.com/torvalds/linux/commit/c15952dc18d8a293d976ac6c06d44d9d98023b45
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/d22c0939eed4bc949f7eaeae7595d01ec45cc2cd
> 

Thanks for taking care of the autobuild failure, but....

To be exact, only utils/keytable depend on the (new) linux kernel bpf header, so
it would be sufficient for only v4l-utils to depend on headers >= 3.18 (or split
v4l-utils into the single utils with different dependencies)?

Or: the commit d6025b0e8c7f57b0f9390f987acc5eed57360d80 adds already a copy
of the linux/bpf.h header, maybe only the dependent linux/bpf_common.h file is
missing?

Regards,
Peter

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libv4l/Config.in   | 2 +-
>  package/v4l2grab/Config.in | 2 +-
>  package/zbar/Config.in     | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/libv4l/Config.in b/package/libv4l/Config.in
> index 57ddde1dfb..84844349a4 100644
> --- a/package/libv4l/Config.in
> +++ b/package/libv4l/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBV4L
>  	bool "libv4l"
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_INSTALL_LIBSTDCPP
> -	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # media headers
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_18 # bpf headers
>  	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
>  	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
>  	help
> diff --git a/package/v4l2grab/Config.in b/package/v4l2grab/Config.in
> index ec3a7a8c54..e25b1618e8 100644
> --- a/package/v4l2grab/Config.in
> +++ b/package/v4l2grab/Config.in
> @@ -4,7 +4,7 @@ config BR2_PACKAGE_V4L2GRAB
>  	depends on BR2_USE_MMU # libv4l
>  	depends on !BR2_STATIC_LIBS # libv4l
>  	depends on BR2_INSTALL_LIBSTDCPP # libv4l
> -	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # libv4l
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_18 # libv4l
>  	select BR2_PACKAGE_JPEG
>  	select BR2_PACKAGE_LIBV4L
>  	help
> diff --git a/package/zbar/Config.in b/package/zbar/Config.in
> index 05c9b769ce..1d8f1be7cf 100644
> --- a/package/zbar/Config.in
> +++ b/package/zbar/Config.in
> @@ -3,7 +3,7 @@ config BR2_PACKAGE_ZBAR
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # libv4l
>  	depends on BR2_USE_MMU # libv4l
>  	depends on BR2_INSTALL_LIBSTDCPP # libv4l
> -	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # libv4l
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_18 # libv4l
>  	select BR2_PACKAGE_JPEG
>  	select BR2_PACKAGE_LIBV4L
>  	help

  reply	other threads:[~2018-11-02 14:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02 13:35 [Buildroot] [PATCH 1/1] libv4l: needs kernel headers >= 3.18 Fabrice Fontaine
2018-11-02 14:19 ` Peter Seiderer [this message]
2018-11-02 17:01   ` Fabrice Fontaine
2018-11-02 17:46     ` Peter Seiderer
2018-11-02 18:41       ` Fabrice Fontaine
2018-11-02 19:08         ` Peter Seiderer
2018-11-02 19:23           ` Peter Seiderer
2018-11-02 20:20             ` Fabrice Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181102151958.23d16ccc@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.