From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v15 2/2] drm/i915: Allow "max bpc" property to limit pipe_bpp Date: Fri, 2 Nov 2018 09:18:57 -0700 Message-ID: <20181102161856.GB2233@intel.com> References: <20181012184233.29250-2-radhakrishna.sripada@intel.com> <20181023014400.16055-1-manasi.d.navare@intel.com> <4254bab3e4fd8f167f5cecaf31a03affd3218d18.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C2EA6E577 for ; Fri, 2 Nov 2018 16:19:00 +0000 (UTC) Content-Disposition: inline In-Reply-To: <4254bab3e4fd8f167f5cecaf31a03affd3218d18.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Lisovskiy, Stanislav" Cc: "daniel.vetter@ffwll.ch" , "intel-gfx@lists.freedesktop.org" , "Kadiyala, Kishore" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjMsIDIwMTggYXQgMTI6MDA6MzVQTSArMDAwMCwgTGlzb3Zza2l5LCBTdGFu aXNsYXYgd3JvdGU6Cj4gT24gTW9uLCAyMDE4LTEwLTIyIGF0IDE4OjQ0IC0wNzAwLCBNYW5hc2kg TmF2YXJlIHdyb3RlOgo+ID4gRnJvbTogUmFkaGFrcmlzaG5hIFNyaXBhZGEgPHJhZGhha3Jpc2hu YS5zcmlwYWRhQGludGVsLmNvbT4KPiA+IAo+ID4gVXNlIHRoZSBuZXdseSBhZGRlZCAibWF4IGJw YyIgY29ubmVjdG9yIHByb3BlcnR5IHRvIGxpbWl0IHBpcGUgYnBwLgo+ID4gCj4gPiBWMzogVXNl IGRybV9jb25uZWN0b3Jfc3RhdGUgdG8gYWNjZXNzIHRoZSAibWF4IGJwYyIgcHJvcGVydHkKPiA+ IFY0OiBJbml0aWFsaXplIHRoZSBkcm0gcHJvcGVydHksIGFkZCBzdXVwb3J0IHRvIERQKFZpbGxl KQo+ID4gVjU6IFVzZSB0aGUgcHJvcGVydHkgaW4gdGhlIGNvbm5lY3RvciBhbmQgZml4IENJIGZh aWx1cmUoVmlsbGUpCj4gPiBWNjogVXNlIHRoZSBjb3JlIGZ1bmN0aW9uIHRvIGF0dGFjaCBtYXhf YnBjIHByb3BlcnR5LCByZW1vdmUgdGhlCj4gPiByZWR1bmRhbnQKPiA+ICAgICBjbGFtcGluZyBv ZiBwaXBlIGJwcCBiYXNlZCBvbiBjb25uZWN0b3IgaW5mbwo+ID4gVjc6IEZpeCBDaGVja3BhdGNo IHdhcm5pbmdzCj4gPiBWOTogQ2xlYW51cCBjb25uZWN0ZWRfc2lua19tYXhfYnBwIGFuZCBmaXgg aW5pdGlhbCB2YWx1ZSBpbiBEUChWaWxsZSkKPiA+IFYxMjogRml4IGRlYnVnIG1lc3NhZ2UoVmls bGUpCj4gPiBWMTM6IFJlbW92ZSB0aGUgcmVkdW5kYW50IGNoZWNrIGFuZCBzaW1wbGlmeSB0aGUg Y2hlY2sgbG9naWMoU3RhbikKPiA+IFYxNDogRml4IHRoZSBjaGVjayBpbiBjb25uZWN0ZWRfc2lu a19tYXhfYnBwKFN0YW4pCj4gPiB2MTUgKEZyb20gTWFuYXNpKTogQWRkIG1pc3NpbmcgYnJlYWsg KFN0YW4pCj4gPiAKPiA+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXgu aW50ZWwuY29tPgo+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+ Cj4gPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4gQ2M6IEtp c2hvcmUgS2FkaXlhbGEgPGtpc2hvcmUua2FkaXlhbGFAaW50ZWwuY29tPgo+ID4gQ2M6IE1hbmFz aSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gPiBDYzogU3RhbmlzbGF2IExp c292c2tpeSA8c3RhbmlzbGF2Lmxpc292c2tpeUBpbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5 OiBSYWRoYWtyaXNobmEgU3JpcGFkYSA8cmFkaGFrcmlzaG5hLnNyaXBhZGFAaW50ZWwuY29tPgo+ ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNTAgKysr KysrKysrKysrKysrKy0tLS0tLS0tCj4gPiAtLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHAuYyAgICAgIHwgIDQgKysrCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf aGRtaS5jICAgIHwgIDUgKysrCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAzOCBpbnNlcnRpb25zKCsp LCAyMSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPiA+IGluZGV4IGZjN2UzYjBiZDk1Yy4uMmJiY2IzODI3NzBkIDEwMDY0NAo+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IEBAIC0xMDg1NiwzMCArMTA4NTYsMzgg QEAgc3RhdGljIHZvaWQKPiA+IGludGVsX21vZGVzZXRfdXBkYXRlX2Nvbm5lY3Rvcl9hdG9taWNf c3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICAJZHJtX2Nvbm5lY3Rvcl9saXN0X2l0 ZXJfZW5kKCZjb25uX2l0ZXIpOwo+ID4gIH0KPiA+ICAKPiA+IC1zdGF0aWMgdm9pZAo+ID4gLWNv bm5lY3RlZF9zaW5rX2NvbXB1dGVfYnBwKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3Rv ciwKPiA+IC0JCQkgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4gPiAr c3RhdGljIGludAo+ID4gK2Nvbm5lY3RlZF9zaW5rX21heF9icHAoY29uc3Qgc3RydWN0IGRybV9j b25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGUsCj4gPiArCQkgICAgICAgc3RydWN0IGludGVsX2Ny dGNfc3RhdGUgKnBpcGVfY29uZmlnKQo+ID4gIHsKPiA+IC0JY29uc3Qgc3RydWN0IGRybV9kaXNw bGF5X2luZm8gKmluZm8gPSAmY29ubmVjdG9yLQo+ID4gPmJhc2UuZGlzcGxheV9pbmZvOwo+ID4g LQlpbnQgYnBwID0gcGlwZV9jb25maWctPnBpcGVfYnBwOwo+ID4gLQo+ID4gLQlEUk1fREVCVUdf S01TKCJbQ09OTkVDVE9SOiVkOiVzXSBjaGVja2luZyBmb3Igc2luayBicHAKPiA+IGNvbnN0cmFp bnNcbiIsCj4gPiAtCQkgICAgICBjb25uZWN0b3ItPmJhc2UuYmFzZS5pZCwKPiA+IC0JCSAgICAg IGNvbm5lY3Rvci0+YmFzZS5uYW1lKTsKPiA+ICsJaW50IGJwcDsKPiA+ICsJc3RydWN0IGRybV9k aXNwbGF5X2luZm8gKmluZm8gPSAmY29ubl9zdGF0ZS0+Y29ubmVjdG9yLQo+ID4gPmRpc3BsYXlf aW5mbzsKPiA+ICAKPiA+IC0JLyogRG9uJ3QgdXNlIGFuIGludmFsaWQgRURJRCBicGMgdmFsdWUg Ki8KPiA+IC0JaWYgKGluZm8tPmJwYyAhPSAwICYmIGluZm8tPmJwYyAqIDMgPCBicHApIHsKPiA+ IC0JCURSTV9ERUJVR19LTVMoImNsYW1waW5nIGRpc3BsYXkgYnBwICh3YXMgJWQpIHRvIEVESUQK PiA+IHJlcG9ydGVkIG1heCBvZiAlZFxuIiwKPiA+IC0JCQkgICAgICBicHAsIGluZm8tPmJwYyAq IDMpOwo+ID4gLQkJcGlwZV9jb25maWctPnBpcGVfYnBwID0gaW5mby0+YnBjICogMzsKPiA+ICsJ c3dpdGNoIChjb25uX3N0YXRlLT5tYXhfYnBjKSB7Cj4gPiArCWNhc2UgNiAuLi4gNzoKPiA+ICsJ CWJwcCA9IDYgKiAzOwo+ID4gKwkJYnJlYWs7Cj4gPiArCWNhc2UgOCAuLi4gOToKPiA+ICsJCWJw cCA9IDggKiAzOwo+ID4gKwkJYnJlYWs7Cj4gPiArCWNhc2UgMTAgLi4uIDExOgo+ID4gKwkJYnBw ID0gMTAgKiAzOwo+ID4gKwkJYnJlYWs7Cj4gPiArCWNhc2UgMTI6Cj4gPiArCQlicHAgPSAxMiAq IDM7Cj4gPiArCQlicmVhazsKPiA+ICsJZGVmYXVsdDoKPiA+ICsJCXJldHVybiAtRUlOVkFMOwo+ ID4gIAl9Cj4gPiAgCj4gPiAtCS8qIENsYW1wIGJwcCB0byA4IG9uIHNjcmVlbnMgd2l0aG91dCBF RElEIDEuNCAqLwo+ID4gLQlpZiAoaW5mby0+YnBjID09IDAgJiYgYnBwID4gMjQpIHsKPiA+IC0J CURSTV9ERUJVR19LTVMoImNsYW1waW5nIGRpc3BsYXkgYnBwICh3YXMgJWQpIHRvCj4gPiBkZWZh dWx0IGxpbWl0IG9mIDI0XG4iLAo+ID4gLQkJCSAgICAgIGJwcCk7Cj4gPiAtCQlwaXBlX2NvbmZp Zy0+cGlwZV9icHAgPSAyNDsKPiA+ICsJaWYgKGJwcCA8IHBpcGVfY29uZmlnLT5waXBlX2JwcCkg ewo+ID4gKwkJRFJNX0RFQlVHX0tNUygiTGltaXRpbmcgZGlzcGxheSBicHAgdG8gJWQgaW5zdGVh ZCBvZgo+ID4gRWRpZCBicHAgIgo+ID4gKwkJCSAgICAgICIlZCwgcmVxdWVzdGVkIGJwcCAlZCwg bWF4IHBsYXRmb3JtCj4gPiBicHAgJWRcbiIsIGJwcCwKPiA+ICsJCQkgICAgICAzICogaW5mby0+ YnBjLCAzICogY29ubl9zdGF0ZS0KPiA+ID5tYXhfcmVxdWVzdGVkX2JwYywKPiA+ICsJCQkgICAg ICBwaXBlX2NvbmZpZy0+cGlwZV9icHApOwo+ID4gKwkJcGlwZV9jb25maWctPnBpcGVfYnBwID0g YnBwOwo+ID4gIAl9Cj4gPiArCXJldHVybiAwOwo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgaW50 Cj4gPiBAQCAtMTA5MTAsOCArMTA5MTgsOCBAQCBjb21wdXRlX2Jhc2VsaW5lX3BpcGVfYnBwKHN0 cnVjdCBpbnRlbF9jcnRjCj4gPiAqY3J0YywKPiA+ICAJCWlmIChjb25uZWN0b3Jfc3RhdGUtPmNy dGMgIT0gJmNydGMtPmJhc2UpCj4gPiAgCQkJY29udGludWU7Cj4gPiAgCj4gPiAtCQljb25uZWN0 ZWRfc2lua19jb21wdXRlX2JwcCh0b19pbnRlbF9jb25uZWN0b3IoY29ubmVjCj4gPiB0b3IpLAo+ ID4gLQkJCQkJICAgcGlwZV9jb25maWcpOwo+ID4gKwkJaWYgKGNvbm5lY3RlZF9zaW5rX21heF9i cHAoY29ubmVjdG9yX3N0YXRlLAo+ID4gcGlwZV9jb25maWcpIDwgMCkKPiA+ICsJCQlyZXR1cm4g LUVJTlZBTDsKPiA+ICAJfQo+ID4gIAo+ID4gIAlyZXR1cm4gYnBwOwo+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHAuYwo+ID4gaW5kZXggMzM4NGE5YmJkYWZkLi41NGVmYTA0NzhiYTAgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiBAQCAtNTczNSw2ICs1NzM1LDEwIEBAIGlu dGVsX2RwX2FkZF9wcm9wZXJ0aWVzKHN0cnVjdCBpbnRlbF9kcAo+ID4gKmludGVsX2RwLCBzdHJ1 Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdAo+ID4gIAkJaW50ZWxfYXR0YWNoX2ZvcmNlX2F1ZGlv X3Byb3BlcnR5KGNvbm5lY3Rvcik7Cj4gPiAgCj4gPiAgCWludGVsX2F0dGFjaF9icm9hZGNhc3Rf cmdiX3Byb3BlcnR5KGNvbm5lY3Rvcik7Cj4gPiArCWlmIChIQVNfR01DSF9ESVNQTEFZKGRldl9w cml2KSkKPiA+ICsJCWRybV9jb25uZWN0b3JfYXR0YWNoX21heF9icGNfcHJvcGVydHkoY29ubmVj dG9yLCA2LAo+ID4gMTApOwo+ID4gKwllbHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDUp Cj4gPiArCQlkcm1fY29ubmVjdG9yX2F0dGFjaF9tYXhfYnBjX3Byb3BlcnR5KGNvbm5lY3Rvciwg NiwKPiA+IDEyKTsKPiA+ICAKPiA+ICAJaWYgKGludGVsX2RwX2lzX2VkcChpbnRlbF9kcCkpIHsK PiA+ICAJCXUzMiBhbGxvd2VkX3NjYWxlcnM7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfaGRtaS5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hk bWkuYwo+ID4gaW5kZXggODlkNWUzOTg0NDUyLi5jYTgyYWVkYjQwMWUgMTAwNjQ0Cj4gPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2hkbWkuYwo+ID4gQEAgLTIxMDYsMTEgKzIxMDYsMTYgQEAgc3RhdGlj IGNvbnN0IHN0cnVjdCBkcm1fZW5jb2Rlcl9mdW5jcwo+ID4gaW50ZWxfaGRtaV9lbmNfZnVuY3Mg PSB7Cj4gPiAgc3RhdGljIHZvaWQKPiA+ICBpbnRlbF9oZG1pX2FkZF9wcm9wZXJ0aWVzKHN0cnVj dCBpbnRlbF9oZG1pICppbnRlbF9oZG1pLCBzdHJ1Y3QKPiA+IGRybV9jb25uZWN0b3IgKmNvbm5l Y3RvcikKPiA+ICB7Cj4gPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRv X2k5MTUoY29ubmVjdG9yLT5kZXYpOwo+ID4gKwo+ID4gIAlpbnRlbF9hdHRhY2hfZm9yY2VfYXVk aW9fcHJvcGVydHkoY29ubmVjdG9yKTsKPiA+ICAJaW50ZWxfYXR0YWNoX2Jyb2FkY2FzdF9yZ2Jf cHJvcGVydHkoY29ubmVjdG9yKTsKPiA+ICAJaW50ZWxfYXR0YWNoX2FzcGVjdF9yYXRpb19wcm9w ZXJ0eShjb25uZWN0b3IpOwo+ID4gIAlkcm1fY29ubmVjdG9yX2F0dGFjaF9jb250ZW50X3R5cGVf cHJvcGVydHkoY29ubmVjdG9yKTsKPiA+ICAJY29ubmVjdG9yLT5zdGF0ZS0+cGljdHVyZV9hc3Bl Y3RfcmF0aW8gPQo+ID4gSERNSV9QSUNUVVJFX0FTUEVDVF9OT05FOwo+ID4gKwo+ID4gKwlpZiAo IUhBU19HTUNIX0RJU1BMQVkoZGV2X3ByaXYpKQo+ID4gKwkJZHJtX2Nvbm5lY3Rvcl9hdHRhY2hf bWF4X2JwY19wcm9wZXJ0eShjb25uZWN0b3IsIDgsCj4gPiAxMik7Cj4gPiAgfQo+ID4gIAo+ID4g IC8qCj4gCj4gTG9va3MgZ29vZCB0byBtZS4KPiBSZXZpZXdlZC1ieTogU3RhbmlzbGF2IExpc292 c2tpeSA8c3RhbmlzbGF2Lmxpc292c2tpeUBpbnRlbC5jb20+CgpwdXNoZWQgdG8gZGlucS4KCnRo YW5rcyBmb3IgcGF0Y2hlcyBhbmQgcmV2aWV3cwoKPiAKPiAtLSAKPiBCZXN0IFJlZ2FyZHMsCj4g Cj4gTGlzb3Zza2l5IFN0YW5pc2xhdgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK