diff for duplicates of <20181102205114.GD4170@linux.ibm.com> diff --git a/a/1.txt b/N1/1.txt index d6c9662..99a0698 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -On Fri, Nov 02, 2018@08:33:25PM +0000, Krein, Dennis wrote: +On Fri, Nov 02, 2018 at 08:33:25PM +0000, Krein, Dennis wrote: > Yes it's fine with me to sign off on this. I have done extensive > additional testing with the patch in my repro setup and have run well > over 100 hours with no problem. The repro setup with rcutorture and the @@ -23,10 +23,10 @@ Reported-by credit? Thanx, Paul > ________________________________ -> From: Paul E. McKenney <paulmck at linux.ibm.com> +> From: Paul E. McKenney <paulmck@linux.ibm.com> > Sent: Friday, November 2, 2018 2:14:48 PM > To: Krein, Dennis -> Cc: linux-nvme at lists.infradead.org; linux-kernel at vger.kernel.org; hch at infradead.org; bvanassche at acm.org +> Cc: linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; hch@infradead.org; bvanassche@acm.org > Subject: Re: srcu hung task panic > > NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe. @@ -34,8 +34,8 @@ Reported-by credit? > > > -> On Fri, Oct 26, 2018@07:48:35AM -0700, Paul E. McKenney wrote: -> > On Fri, Oct 26, 2018@04:00:53AM +0000, Krein, Dennis wrote: +> On Fri, Oct 26, 2018 at 07:48:35AM -0700, Paul E. McKenney wrote: +> > On Fri, Oct 26, 2018 at 04:00:53AM +0000, Krein, Dennis wrote: > > > I have a patch attached that fixes the problem for us. I also tried a > > > version with an smb_mb() call added at end of rcu_segcblist_enqueue() > > > - but that turned out not to be needed. I think the key part of @@ -90,7 +90,7 @@ Reported-by credit? > > ------------------------------------------------------------------------ > > > > commit 1c1d315dfb7049d0233b89948a3fbcb61ea15d26 -> > Author: Dennis Krein <Dennis.Krein at netapp.com> +> > Author: Dennis Krein <Dennis.Krein@netapp.com> > > Date: Fri Oct 26 07:38:24 2018 -0700 > > > > srcu: Lock srcu_data structure in srcu_gp_start() @@ -106,10 +106,10 @@ Reported-by credit? > > structure's ->lock across the calls to rcu_segcblist_advance() and > > rcu_segcblist_accelerate(), thus preventing this corruption. > > -> > Reported-by: Bart Van Assche <bvanassche at acm.org> -> > Reported-by: Christoph Hellwig <hch at infradead.org> -> > Signed-off-by: Dennis Krein <Dennis.Krein at netapp.com> -> > Signed-off-by: Paul E. McKenney <paulmck at linux.ibm.com> +> > Reported-by: Bart Van Assche <bvanassche@acm.org> +> > Reported-by: Christoph Hellwig <hch@infradead.org> +> > Signed-off-by: Dennis Krein <Dennis.Krein@netapp.com> +> > Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com> > > > > diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c > > index 60f3236beaf7..697a2d7e8e8a 100644 diff --git a/a/content_digest b/N1/content_digest index ab631a1..efcd971 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,12 +5,18 @@ "ref\020181026144835.GW4170@linux.ibm.com\0" "ref\020181102201448.GA15234@linux.ibm.com\0" "ref\0SN6PR06MB43338B272D71F977DBBF906FE5CF0@SN6PR06MB4333.namprd06.prod.outlook.com\0" - "From\0paulmck@linux.ibm.com (Paul E. McKenney)\0" - "Subject\0srcu hung task panic\0" + "From\0Paul E. McKenney <paulmck@linux.ibm.com>\0" + "Subject\0Re: srcu hung task panic\0" "Date\0Fri, 2 Nov 2018 13:51:14 -0700\0" + "To\0Krein" + " Dennis <Dennis.Krein@netapp.com>\0" + "Cc\0linux-nvme@lists.infradead.org <linux-nvme@lists.infradead.org>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + hch@infradead.org <hch@infradead.org> + " bvanassche@acm.org <bvanassche@acm.org>\0" "\00:1\0" "b\0" - "On Fri, Nov 02, 2018@08:33:25PM +0000, Krein, Dennis wrote:\n" + "On Fri, Nov 02, 2018 at 08:33:25PM +0000, Krein, Dennis wrote:\n" "> Yes it's fine with me to sign off on this. I have done extensive\n" "> additional testing with the patch in my repro setup and have run well\n" "> over 100 hours with no problem. The repro setup with rcutorture and the\n" @@ -35,10 +41,10 @@ "\t\t\t\t\t\t\tThanx, Paul\n" "\n" "> ________________________________\n" - "> From: Paul E. McKenney <paulmck at linux.ibm.com>\n" + "> From: Paul E. McKenney <paulmck@linux.ibm.com>\n" "> Sent: Friday, November 2, 2018 2:14:48 PM\n" "> To: Krein, Dennis\n" - "> Cc: linux-nvme at lists.infradead.org; linux-kernel at vger.kernel.org; hch at infradead.org; bvanassche at acm.org\n" + "> Cc: linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; hch@infradead.org; bvanassche@acm.org\n" "> Subject: Re: srcu hung task panic\n" "> \n" "> NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe.\n" @@ -46,8 +52,8 @@ "> \n" "> \n" "> \n" - "> On Fri, Oct 26, 2018@07:48:35AM -0700, Paul E. McKenney wrote:\n" - "> > On Fri, Oct 26, 2018@04:00:53AM +0000, Krein, Dennis wrote:\n" + "> On Fri, Oct 26, 2018 at 07:48:35AM -0700, Paul E. McKenney wrote:\n" + "> > On Fri, Oct 26, 2018 at 04:00:53AM +0000, Krein, Dennis wrote:\n" "> > > I have a patch attached that fixes the problem for us. I also tried a\n" "> > > version with an smb_mb() call added at end of rcu_segcblist_enqueue()\n" "> > > - but that turned out not to be needed. I think the key part of\n" @@ -102,7 +108,7 @@ "> > ------------------------------------------------------------------------\n" "> >\n" "> > commit 1c1d315dfb7049d0233b89948a3fbcb61ea15d26\n" - "> > Author: Dennis Krein <Dennis.Krein at netapp.com>\n" + "> > Author: Dennis Krein <Dennis.Krein@netapp.com>\n" "> > Date: Fri Oct 26 07:38:24 2018 -0700\n" "> >\n" "> > srcu: Lock srcu_data structure in srcu_gp_start()\n" @@ -118,10 +124,10 @@ "> > structure's ->lock across the calls to rcu_segcblist_advance() and\n" "> > rcu_segcblist_accelerate(), thus preventing this corruption.\n" "> >\n" - "> > Reported-by: Bart Van Assche <bvanassche at acm.org>\n" - "> > Reported-by: Christoph Hellwig <hch at infradead.org>\n" - "> > Signed-off-by: Dennis Krein <Dennis.Krein at netapp.com>\n" - "> > Signed-off-by: Paul E. McKenney <paulmck at linux.ibm.com>\n" + "> > Reported-by: Bart Van Assche <bvanassche@acm.org>\n" + "> > Reported-by: Christoph Hellwig <hch@infradead.org>\n" + "> > Signed-off-by: Dennis Krein <Dennis.Krein@netapp.com>\n" + "> > Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>\n" "> >\n" "> > diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c\n" "> > index 60f3236beaf7..697a2d7e8e8a 100644\n" @@ -142,4 +148,4 @@ "> > state = rcu_seq_state(READ_ONCE(sp->srcu_gp_seq));\n" > -c484b0d62138264ab89d007e9c5553d09176560c5c11c376ba087e8b8e1a7291 +412b73bd73b085a6be24c8f7dc7141178923970f12e689d79d9480068a8ce5ef
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.