All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] scanpypi: use archive file name to specify the extraction folder
Date: Fri, 2 Nov 2018 21:36:40 +0100	[thread overview]
Message-ID: <20181102213640.3a274edc@windsurf> (raw)
In-Reply-To: <20181102134501.13860-1-yegorslists@googlemail.com>

Hello,

On Fri,  2 Nov 2018 14:45:01 +0100, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Some packages have archive name that is different from package name.
> For example websocket-client's archive name is websocket_client-*.tar.gz.
> scanpypi expects the temporary extract folder to be:
> 
> /tmp-folder/BR-package-name/PyPI-packagename-and-version
> 
> In the case of websocket-client package the real extraction folder
> will be different from the expected one because of the '_' in the
> archive file name.
> 
> Use archive file name instead of package name to specify the extraction
> folder. As the version is already part of this file, we don't need to
> specify it.
> 
> Bonus: remove obsolete "return None, None" as the function doesn't return
> anything. OSError class doesn't provide "message" member, so replace it
> with "strerror".

I've applied to master, but I believe it should perhaps have been two
separate patches. Indeed, I don't see the relationship between the use
of the archive file name, and the change around "return None, None".

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-11-02 20:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02 13:45 [Buildroot] [PATCH v2] scanpypi: use archive file name to specify the extraction folder yegorslists at googlemail.com
2018-11-02 15:28 ` Asaf Kahlon
2018-11-02 20:36 ` Thomas Petazzoni [this message]
2018-11-05  8:22   ` Yegor Yefremov
2018-11-14 22:36 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181102213640.3a274edc@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.