From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Vasily Averin <vvs@virtuozzo.com>
Cc: linux-ext4@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-kernel@vger.kernel.org,
Yongqiang Yang <xiaoqiangnk@gmail.com>,
Yongqiang Yang <yangyongqiang01@baidu.com>
Subject: Re: [PATCH v2 01/11] ext4 resise: extra brelse in setup_new_flex_group_blocks()
Date: Sat, 3 Nov 2018 16:20:02 -0400 [thread overview]
Message-ID: <20181103202002.GE28850@thunk.org> (raw)
In-Reply-To: <37de5906-2d76-461a-ff92-b6fcc775b408@virtuozzo.com>
On Wed, Oct 31, 2018 at 12:57:37AM +0300, Vasily Averin wrote:
> currently bh is set to NULL only during first iteration of for cycle,
> then this pointer is not cleared after end of using.
> Therefore rollback after errors can lead to extra brelse(bh) call,
> decrements bh counter and later trigger an unexpected warning in __brelse()
>
> Patch moves brelse() calls in body of cycle to exclude requirement of
> brelse() call in rollback.
>
> Fixes 33afdcc5402d ("ext4: add a function which sets up group blocks ...") # 3.3+
>
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Thanks, applied. I addjusted the patch summary to read:
ext4: avoid potential extra brelse in setup_new_flex_group_blocks()
(Note that resise should have been spelled as "resize", by the way.)
- Ted
next prev parent reply other threads:[~2018-11-04 5:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1540935522.git.vvs@virtuozzo.com>
2018-10-30 21:57 ` [PATCH v2 01/11] ext4 resise: extra brelse in setup_new_flex_group_blocks() Vasily Averin
2018-11-03 20:20 ` Theodore Y. Ts'o [this message]
2018-10-30 21:57 ` [PATCH v2 02/11] ext4 resize: missing brelse() after errors in set_flexbg_block_bitmap() Vasily Averin
2018-11-03 20:28 ` Theodore Y. Ts'o
2018-10-30 21:57 ` [PATCH v2 03/11] ext4 resize: brelse() cleanup in add_new_gdb_meta_bg() Vasily Averin
2018-11-03 20:55 ` Theodore Y. Ts'o
2018-10-30 21:58 ` [PATCH v2 04/11] ext4 resize: lost brelse() in update_backups() Vasily Averin
2018-11-03 21:14 ` Theodore Y. Ts'o
2018-10-30 21:58 ` [PATCH v2 05/11] ext4 resize: lost rollback in ext4_resize_fs() Vasily Averin
2018-11-06 21:17 ` Theodore Y. Ts'o
2018-10-30 21:58 ` [PATCH v2 06/11] ext4 resize: lost resize_inode cleanup before retry " Vasily Averin
2018-11-06 21:23 ` Theodore Y. Ts'o
2018-10-30 21:58 ` [PATCH v2 07/11] ext4: lost put_bh in ext4_mark_iloc_dirty() Vasily Averin
2018-11-06 21:53 ` Theodore Y. Ts'o
2018-10-30 21:58 ` [PATCH v2 08/11] ext4: lost brelse in ext4_orphan_add() Vasily Averin
2018-11-06 22:04 ` Theodore Y. Ts'o
2018-10-30 21:58 ` [PATCH v2 09/11] ext4: iloc.bh cleanup in add_new_gdb() Vasily Averin
2018-11-06 22:19 ` Theodore Y. Ts'o
2018-11-06 22:19 ` Theodore Y. Ts'o
2018-10-30 21:58 ` [PATCH v2 10/11] ext4: remove useless brelse call in ext4_xattr_inode_update_ref() Vasily Averin
2018-11-06 22:49 ` Theodore Y. Ts'o
2018-10-30 21:58 ` [PATCH v2 11/11] ext4: access to uninitialized bh fields in ext4_xattr_set_handle() Vasily Averin
[not found] ` <48BA929C-9BF7-4092-BDD3-BECB64AF0599@dilger.ca>
2018-10-31 3:39 ` Vasily Averin
2018-11-01 0:42 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181103202002.GE28850@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vvs@virtuozzo.com \
--cc=xiaoqiangnk@gmail.com \
--cc=yangyongqiang01@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.