From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] ngrep: bump to version 1.47
Date: Sun, 4 Nov 2018 11:19:53 +0100 [thread overview]
Message-ID: <20181104111953.08d765e0@windsurf> (raw)
In-Reply-To: <CAPi7W8388ghbe_PtDyJ_Hi1=2PLo4sAoZbzwORjH4qLGQ-ue5w@mail.gmail.com>
Hello,
On Sat, 3 Nov 2018 23:01:07 +0100, Fabrice Fontaine wrote:
> > So PCRE is not mandatory.
> Indeed, PCRE is not really "mandatory", ngrep use GNU regex by default
> but this was already the case before the bump (in version 1.45): see
> https://github.com/jpr5/ngrep/blob/V1_45/configure.in.
> I didn't want to change this behavior when bumping the package and I
> could find why pcre wasn't made optional in the initial commit back in
> 2011.
> However, I'll add a third patch in my serie to make pcre an optional
> dependency before bumping the package..
Indeed, it could be a third patch.
> > > @@ -20,7 +20,6 @@ NGREP_CONF_ENV += LIBS+="$(NGREP_LIBS)"
> >
> > This assignment becomes totally pointless.
> OK, I'll replace it by:
> ifeq ($(BR2_STATIC_LIBS),y)
> NGREP_CONF_ENV += LIBS="$(STAGING_DIR)/usr/bin/pcap-config --static
> --additional-libs"
> endif
Sorry, my bad here, I had entirely missed that NGREP_LIBS was still
being set in the BR2_STATIC_LIBS case. So the way you did it originally
was OK, sorry about that. Doing is directly in NGREP_CONF_ENV also
works, since there will be a single assignment of LIBS.
> > You should add a --disable-tcpkill here, and then in your PATCH 2/2,
> > add the optional dependency on libdnet.
> OK, I'll make a v2 with this update (and the other ones)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-11-04 10:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 13:23 [Buildroot] [PATCH 1/2] ngrep: bump to version 1.47 Fabrice Fontaine
2018-11-01 13:23 ` [Buildroot] [PATCH 2/2] ngrep: add libnet optional dependency Fabrice Fontaine
2018-11-03 21:42 ` [Buildroot] [PATCH 1/2] ngrep: bump to version 1.47 Thomas Petazzoni
2018-11-03 22:01 ` Fabrice Fontaine
2018-11-04 10:19 ` Thomas Petazzoni [this message]
2018-11-04 11:04 ` Fabrice Fontaine
2018-11-04 11:28 ` Thomas Petazzoni
2018-11-04 11:34 ` Baruch Siach
2018-11-06 0:14 ` Arnout Vandecappelle
2018-11-06 7:59 ` Thomas Petazzoni
2018-11-06 9:54 ` Peter Korsgaard
2018-11-06 10:31 ` Arnout Vandecappelle
2018-11-06 11:18 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181104111953.08d765e0@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.