From: Pavel Machek <pavel@ucw.cz>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Boyd <sboyd@kernel.org>, James Cameron <quozl@laptop.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 5/8] Input: olpc_apsp: depend on CONFIG_OF
Date: Sun, 4 Nov 2018 12:50:23 +0100 [thread overview]
Message-ID: <20181104115023.GJ23864@amd> (raw)
In-Reply-To: <20181010142504.233467-6-lkundrak@v3.sk>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
On Wed 2018-10-10 16:25:01, Lubomir Rintel wrote:
> This is a device-tree enabled driver. Moreover CONFIG_OLPC is specific
> to the x86 platform code, while the driver is for an ARM-based laptop.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> drivers/input/serio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig
> index d90d9f1098ff..a4f70021b53e 100644
> --- a/drivers/input/serio/Kconfig
> +++ b/drivers/input/serio/Kconfig
> @@ -254,7 +254,7 @@ config SERIO_APBPS2
>
> config SERIO_OLPC_APSP
> tristate "OLPC AP-SP input support"
> - depends on OLPC || COMPILE_TEST
> + depends on OF
I'd keep "|| COMPILE_TEST".
Otherwise
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-11-04 11:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 14:24 [PATCH v2 0/8] OLPC 1.75 Keyboard/Touchpad fixes Lubomir Rintel
2018-10-10 14:24 ` [PATCH v2 1/8] dt-bindings: olpc,ap-sp: add clock Lubomir Rintel
2018-11-04 11:41 ` Pavel Machek
2018-10-10 14:24 ` [PATCH v2 2/8] dt-bindings: olpc,ap-sp: add GPIO lines Lubomir Rintel
2018-11-04 11:49 ` Pavel Machek
2018-10-10 14:24 ` [PATCH v2 3/8] dt-bindings: marvell,mmp2: Add clock id for the SP clock Lubomir Rintel
2018-11-04 11:48 ` Pavel Machek
2018-10-10 14:25 ` [PATCH v2 4/8] clk: mmp2: add " Lubomir Rintel
2018-11-04 11:48 ` Pavel Machek
2018-10-10 14:25 ` [PATCH v2 5/8] Input: olpc_apsp: depend on CONFIG_OF Lubomir Rintel
2018-10-10 17:18 ` Dmitry Torokhov
2018-11-04 11:50 ` Pavel Machek [this message]
2018-10-10 14:25 ` [PATCH v2 6/8] Input: olpc_apsp: check FIFO status on open(), not probe() Lubomir Rintel
2018-10-10 14:25 ` [PATCH v2 7/8] Input: olpc_apsp: enable the SP clock Lubomir Rintel
2018-10-10 17:09 ` Dmitry Torokhov
2018-11-04 11:53 ` Pavel Machek
2018-10-10 14:25 ` [PATCH v2 8/8] Input: olpc_apsp: allocate the GPIOs used Lubomir Rintel
2018-10-10 17:10 ` Dmitry Torokhov
2018-10-10 17:11 ` Dmitry Torokhov
2018-10-11 8:38 ` Linus Walleij
2018-11-04 11:55 ` Pavel Machek
2018-10-15 19:56 ` [PATCH v2 0/8] OLPC 1.75 Keyboard/Touchpad fixes Pavel Machek
2018-10-16 9:44 ` Lubomir Rintel
2018-10-30 10:01 ` Pavel Machek
2018-10-30 10:26 ` Pavel Machek
2018-10-30 19:40 ` Lubomir Rintel
2018-10-31 3:37 ` James Cameron
2018-10-31 12:46 ` Pavel Machek
2018-10-31 11:54 ` Pavel Machek
2018-11-01 13:47 ` Pavel Machek
2018-10-30 23:54 ` James Cameron
2018-10-31 12:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181104115023.GJ23864@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=quozl@laptop.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.