Re: [Outreachy kernel] [PATCH] staging: greybus: remove unmatched right bracket

[Ioannis Valasakis <code@wizofe.uk>]

On Sun, Nov 04, 2018 at 07:27:27AM +0100, Julia Lawall wrote:
> 
> 
> On Sun, 4 Nov 2018, Ioannis Valasakis wrote:
> 
> > Remove unmatched right bracket.
> > Reported by uncrustify.
> >
> > Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> 
> I wondered how such a problem could go unnoticed, but this file seems to
> have a lot of other compilation problems that could perhaps also be fixed
> up.
Weird indeed. I was wondering myself after compiling the modules but I
noticed that camera isn't compile by running a make. Could you let me
know how did you find out the compilation problems, i.e. how did you try
compiling camera.c, so that I can replicate?

thanks
ioannis
> 
> julia
> 
> > ---
> >  drivers/staging/greybus/camera.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> > index 6dded10f4155..c6d65430ea4c 100644
> > --- a/drivers/staging/greybus/camera.c
> > +++ b/drivers/staging/greybus/camera.c
> > @@ -1190,7 +1190,6 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam)
> >  		debugfs_create_file(entry->name, entry->mask,
> >  				    gcam->debugfs.root, gcam,
> >  				    &gb_camera_debugfs_ops);
> > -		}
> >  	}
> >
> >  	return 0;
> > --
> > 2.19.1
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104020212.GA18914%40kvasir.local.
> > For more options, visit https://groups.google.com/d/optout.
> >