All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qt5: use ccache for building host code
Date: Sun, 4 Nov 2018 22:12:20 +0100	[thread overview]
Message-ID: <20181104221220.5805582b@gmx.net> (raw)
In-Reply-To: <20181020132535.24508-1-thomas.petazzoni@bootlin.com>

Hello Thomas,

On Sat, 20 Oct 2018 15:25:35 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> qt5 currently doesn't use HOSTCC/HOSTCXX, so it doesn't use ccache
> when building all its host code (especially qmake). This means that
> even with ccache enabled and a hot cache, it still takes a long time
> to build qt5base.
> 
> Before this patch, building qt5base takes:
> 
>  - 446 seconds with a cold ccache
>  - 185 seconds with a hot ccache
> 
> This is because the ccache is not used for host code.
> 
> After this patch, building qt5base takes:
> 
>  - 450 seconds with a cold ccache
>  - 15 seconds with a hot ccache
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/qt5/qt5base/qt5base.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index ab2b883fc4..d9f7af7196 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -264,6 +264,13 @@ define QT5BASE_CONFIGURE_ARCH_CONFIG
>  endef
>  endif
>  
> +# This allows to use ccache when available
> +define QT5BASE_CONFIGURE_HOSTCC
> +	$(SED) 's,^QMAKE_COMPILER\s*=.*,QMAKE_COMPILER=$(HOSTCC),' $(@D)/mkspecs/common/g++-base.conf
> +	$(SED) 's,^QMAKE_CC\s*=.*,QMAKE_CC=$(HOSTCC),' $(@D)/mkspecs/common/g++-base.conf
> +	$(SED) 's,^QMAKE_CXX\s*=.*,QMAKE_CXX=$(HOSTCXX),' $(@D)/mkspecs/common/g++-base.conf
> +endef
> +

With this sed commands applied, a qmake host compile is always using ccache (same
behavior already for the cross/target compile?)?

Regards,
Peter

>  define QT5BASE_CONFIGURE_CMDS
>  	mkdir -p $(@D)/mkspecs/devices/linux-buildroot-g++/
>  	sed 's/@EGLFS_DEVICE@/$(QT5BASE_EGLFS_DEVICE)/g' \
> @@ -274,6 +281,7 @@ define QT5BASE_CONFIGURE_CMDS
>  	$(QT5BASE_CONFIGURE_CONFIG_FILE)
>  	touch $(QT5BASE_ARCH_CONFIG_FILE)
>  	$(QT5BASE_CONFIGURE_ARCH_CONFIG)
> +	$(QT5BASE_CONFIGURE_HOSTCC)
>  	(cd $(@D); \
>  		$(TARGET_MAKE_ENV) \
>  		PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \

  parent reply	other threads:[~2018-11-04 21:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-20 13:25 [Buildroot] [PATCH] qt5: use ccache for building host code Thomas Petazzoni
2018-11-03 13:49 ` Thomas Petazzoni
2018-11-04 21:08   ` Peter Seiderer
2018-11-04 21:12 ` Peter Seiderer [this message]
2018-11-04 21:25   ` Thomas Petazzoni
2018-11-04 21:46     ` Peter Seiderer
2018-11-05  7:49       ` Thomas Petazzoni
2018-11-05 20:16         ` Peter Seiderer
2018-11-30  9:00 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181104221220.5805582b@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.