From: Baoquan He <bhe@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>,
Stable tree <stable@vger.kernel.org>
Subject: Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages
Date: Mon, 5 Nov 2018 08:20:09 +0800 [thread overview]
Message-ID: <20181105002009.GF27491@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20181102155528.20358-1-mhocko@kernel.org>
Hi Michal,
On 11/02/18 at 04:55pm, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> Baoquan He has noticed that 15c30bc09085 ("mm, memory_hotplug: make
> has_unmovable_pages more robust") is causing memory offlining failures
> on a movable node. After a further debugging it turned out that
> has_unmovable_pages fails prematurely because it stumbles over off-LRU
> pages. Nevertheless those pages are not on LRU because they are waiting
> on the pcp LRU caches (an example of __dump_page added by a debugging
> patch)
> [ 560.923297] page:ffffea043f39fa80 count:1 mapcount:0 mapping:ffff880e5dce1b59 index:0x7f6eec459
> [ 560.931967] flags: 0x5fffffc0080024(uptodate|active|swapbacked)
> [ 560.937867] raw: 005fffffc0080024 dead000000000100 dead000000000200 ffff880e5dce1b59
> [ 560.945606] raw: 00000007f6eec459 0000000000000000 00000001ffffffff ffff880e43ae8000
> [ 560.953323] page dumped because: hotplug
> [ 560.957238] page->mem_cgroup:ffff880e43ae8000
> [ 560.961620] has_unmovable_pages: pfn:0x10fd030d, found:0x1, count:0x0
> [ 560.968127] page:ffffea043f40c340 count:2 mapcount:0 mapping:ffff880e2f2d8628 index:0x0
> [ 560.976104] flags: 0x5fffffc0000006(referenced|uptodate)
> [ 560.981401] raw: 005fffffc0000006 dead000000000100 dead000000000200 ffff880e2f2d8628
> [ 560.989119] raw: 0000000000000000 0000000000000000 00000002ffffffff ffff88010a8f5000
> [ 560.996833] page dumped because: hotplug
Sorry, last week I didn't test this patch with memory pressure adding.
Today use "stress -m 200 -t 2h" to add pressure, hot removing failed.
Will send you output log. W/o memory pressure, it sometimes succeed. I
saw one failure last night, it still show un-removable as 0 in
hotpluggable node one time, I worried it might be caused by my compiling
mistake, so compile and try again this morning.
Thanks
Baoquan
next prev parent reply other threads:[~2018-11-05 0:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 9:10 Memory hotplug failed to offline on bare metal system of multiple nodes Baoquan He
2018-11-01 9:10 ` Baoquan He
2018-11-01 9:22 ` Michal Hocko
2018-11-01 9:42 ` Baoquan He
2018-11-01 9:58 ` Michal Hocko
2018-11-02 15:55 ` [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages Michal Hocko
2018-11-02 15:55 ` Michal Hocko
2018-11-05 0:20 ` Baoquan He [this message]
2018-11-05 9:14 ` Michal Hocko
2018-11-05 9:26 ` Baoquan He
2018-11-05 9:35 ` Michal Hocko
2018-11-05 9:28 ` Michal Hocko
2018-11-05 9:45 ` Baoquan He
2018-11-05 10:25 ` Baoquan He
2018-11-05 12:38 ` Michal Hocko
2018-11-05 12:38 ` Michal Hocko
2018-11-05 12:38 ` Michal Hocko
2018-11-05 14:23 ` Baoquan He
2018-11-05 17:10 ` Michal Hocko
2018-11-06 0:22 ` Baoquan He
2018-11-06 8:28 ` Michal Hocko
2018-11-06 9:16 ` Baoquan He
2018-11-06 9:36 ` Baoquan He
2018-11-06 9:51 ` Michal Hocko
2018-11-06 10:00 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105002009.GF27491@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.