From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gJcmt-0004IP-4f for ath10k@lists.infradead.org; Mon, 05 Nov 2018 11:11:21 +0000 MIME-Version: 1.0 Subject: Re: [PATCH] ath10k: Fixup extended per sta tx statistics From: Kalle Valo In-Reply-To: <20181018073619.c2cxj74enkramhjr@kili.mountain> References: <20181018073619.c2cxj74enkramhjr@kili.mountain> Message-Id: <20181105111108.D538A607CA@smtp.codeaurora.org> Date: Mon, 5 Nov 2018 11:11:08 +0000 (UTC) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, Anilkumar Kolli , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Dan Carpenter wrote: > I had a couple concerns with this code. First, we definitely need to > set the error code if the kzalloc() fails. Secondly, I was worried that > if we didn't set "arsta->tx_stats" to NULL after freeing it, then it > looks to me like it might lead to a use after free. I can't test that, > but it's harmless to set it to NULL so I did. > > Fixes: a904417fc876 ("ath10k: add extended per sta tx statistics support") > Signed-off-by: Dan Carpenter > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 539b44e70c5b ath10k: fixup extended per sta tx statistics -- https://patchwork.kernel.org/patch/10646825/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k