From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Anilkumar Kolli <akolli@codeaurora.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ath10k: Fixup extended per sta tx statistics
Date: Mon, 05 Nov 2018 11:11:09 +0000 [thread overview]
Message-ID: <20181105111109.231AA6053D@smtp.codeaurora.org> (raw)
In-Reply-To: <20181018073619.c2cxj74enkramhjr@kili.mountain>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> I had a couple concerns with this code. First, we definitely need to
> set the error code if the kzalloc() fails. Secondly, I was worried that
> if we didn't set "arsta->tx_stats" to NULL after freeing it, then it
> looks to me like it might lead to a use after free. I can't test that,
> but it's harmless to set it to NULL so I did.
>
> Fixes: a904417fc876 ("ath10k: add extended per sta tx statistics support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
539b44e70c5b ath10k: fixup extended per sta tx statistics
--
https://patchwork.kernel.org/patch/10646825/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Anilkumar Kolli <akolli@codeaurora.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ath10k: Fixup extended per sta tx statistics
Date: Mon, 5 Nov 2018 11:11:09 +0000 (UTC) [thread overview]
Message-ID: <20181105111109.231AA6053D@smtp.codeaurora.org> (raw)
In-Reply-To: <20181018073619.c2cxj74enkramhjr@kili.mountain>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> I had a couple concerns with this code. First, we definitely need to
> set the error code if the kzalloc() fails. Secondly, I was worried that
> if we didn't set "arsta->tx_stats" to NULL after freeing it, then it
> looks to me like it might lead to a use after free. I can't test that,
> but it's harmless to set it to NULL so I did.
>
> Fixes: a904417fc876 ("ath10k: add extended per sta tx statistics support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
539b44e70c5b ath10k: fixup extended per sta tx statistics
--
https://patchwork.kernel.org/patch/10646825/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-11-05 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 7:36 [PATCH] ath10k: Fixup extended per sta tx statistics Dan Carpenter
2018-10-18 7:36 ` Dan Carpenter
2018-10-18 7:36 ` Dan Carpenter
2018-11-05 11:11 ` Kalle Valo
2018-11-05 11:11 ` Kalle Valo [this message]
2018-11-05 11:11 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105111109.231AA6053D@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akolli@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.