From: Kalle Valo <kvalo@codeaurora.org>
To: Anilkumar Kolli <akolli@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Anilkumar Kolli <akolli@codeaurora.org>
Subject: Re: [PATCH v2] ath10k: report tx rate using ieee80211_tx_rate_update()
Date: Mon, 5 Nov 2018 11:52:18 +0000 (UTC) [thread overview]
Message-ID: <20181105115218.833276053D@smtp.codeaurora.org> (raw)
In-Reply-To: <1540530438-11292-1-git-send-email-akolli@codeaurora.org>
Anilkumar Kolli <akolli@codeaurora.org> wrote:
> Mesh path metric needs tx rate information from ieee80211_tx_status()
> call but in ath10k there is no mechanism to report tx rate information
> via ieee80211_tx_status(), the tx rate is only accessible via
> sta_statiscs() op.
>
> Per peer tx stats has tx rate info available, Tx rate is available
> to ath10k driver after every 4 PPDU sent in the air. For each PPDU,
> ath10k driver updates rate informattion to mac80211 using
> ieee80211_tx_rate_update().
>
> Per peer txrate information is updated through per peer statistics
> and is available for QCA9888/QCA9984/QCA4019/QCA998X only
>
> Tested on QCA9984 with firmware-5.bin_10.4-3.5.3-00053
> Tested on QCA998X with firmware-5.bin_10.2.4-1.0-00036
>
> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
The corresponding mac80211 patch is not yet in ath-next branch, I'll
wait for that.
drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_update_per_peer_tx_stats':
drivers/net/wireless/ath/ath10k/htt_rx.c:3060:3: error: implicit declaration of function 'ieee80211_tx_rate_update'; did you mean 'ieee80211_tx_dequeue'? [-Werror=implicit-function-declaration]
ieee80211_tx_rate_update(ar->hw, sta, &arsta->tx_info);
^~~~~~~~~~~~~~~~~~~~~~~~
ieee80211_tx_dequeue
cc1: some warnings being treated as errors
make[5]: *** [drivers/net/wireless/ath/ath10k/htt_rx.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [drivers/net/wireless/ath/ath10k] Error 2
make[3]: *** [drivers/net/wireless/ath] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
Patch set to Awaiting Upstream.
--
https://patchwork.kernel.org/patch/10656925/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-11-05 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 5:07 [PATCH v2] ath10k: report tx rate using ieee80211_tx_rate_update() Anilkumar Kolli
2018-10-26 5:07 ` Anilkumar Kolli
2018-11-05 11:52 ` Kalle Valo [this message]
2018-11-05 11:52 ` Kalle Valo
2018-12-20 17:00 ` Kalle Valo
2018-12-20 17:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105115218.833276053D@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akolli@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.