From: Kalle Valo <kvalo@codeaurora.org>
To: Govind Singh <govinds@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Govind Singh <govinds@codeaurora.org>
Subject: Re: [PATCH v2 2/3] ath10k: Disable interface pause wow config for integrated chipset
Date: Mon, 5 Nov 2018 13:01:51 +0000 (UTC) [thread overview]
Message-ID: <20181105130151.AF99F60600@smtp.codeaurora.org> (raw)
In-Reply-To: <20181012094938.14734-3-govinds@codeaurora.org>
Govind Singh <govinds@codeaurora.org> wrote:
> wow pause iface config controls the PCI D0/D3-WOW cases for pcie
> bus state. Firmware does not expects WOW_IFACE_PAUSE_ENABLED config
> for bus/link that cannot be suspended ex:snoc and does not trigger
> common subsystem shutdown.
> Disable interface pause wow config for integrated chipset(WCN3990)
> for correct WOW configuration in the firmware.
>
> Testing:
> Tested on WCN3990 HW.
> Tested FW: WLAN.HL.2.0-01192-QCAHLSWMTPLZ-1.
>
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This introduced a new warning:
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3263:41: warning: incorrect type in assignment (different base types)
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3263:41: expected restricted __le32 [usertype] pause_iface_config
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3263:41: got int
I fixed it in the pending branch:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=22aab99eaf71dadc3cf2e8a2b982986a40ca641e
--
https://patchwork.kernel.org/patch/10638235/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-11-05 13:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 9:49 [PATCH v2 0/3] Add support for suspend/resume and WOW for WCN3990 chipset Govind Singh
2018-10-12 9:49 ` Govind Singh
2018-10-12 9:49 ` [PATCH v2 1/3] ath10k: Enable bus layer suspend/resume for WCN3990 Govind Singh
2018-10-12 9:49 ` Govind Singh
2018-10-12 9:49 ` [PATCH v2 2/3] ath10k: Disable interface pause wow config for integrated chipset Govind Singh
2018-10-12 9:49 ` Govind Singh
2018-11-05 13:01 ` Kalle Valo
2018-11-05 13:01 ` Kalle Valo [this message]
2018-10-12 9:49 ` [PATCH v2 3/3] ath10k: Request credit report if flow control enabled on ep Govind Singh
2018-10-12 9:49 ` Govind Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105130151.AF99F60600@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=govinds@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.