From: Greg KH <gregkh@linuxfoundation.org>
To: Maya Nakamura <m.maya.nakamura@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 2/2] staging: rtlwifi: Change line and comment spacing
Date: Mon, 5 Nov 2018 14:47:35 +0100 [thread overview]
Message-ID: <20181105134735.GC8389@kroah.com> (raw)
In-Reply-To: <a0c1be6312a62595a5f8f7e0b02ced685933052d.1541037077.git.m.maya.nakamura@gmail.com>
On Wed, Oct 31, 2018 at 09:06:27PM -0700, Maya Nakamura wrote:
> Add blank lines at the end of if statements and spaces before and after
> comments. Edit statements so that the line does not end with an assignment
> operator or a parenthesis. Remove a blank comment, too.
That is a lot of different things all in one patch. Please only do one
"logical" type of thing. This should be broken up into multiple patches
please.
thanks,
greg k-h
next prev parent reply other threads:[~2018-11-05 13:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 4:03 [PATCH 0/2] staging: rtlwifi: Modify bool operations and clean up spacing Maya Nakamura
2018-11-01 4:04 ` [PATCH 1/2] staging: rtlwifi: Replace 1 with true and remove comparison for bool Maya Nakamura
2018-11-01 4:06 ` [PATCH 2/2] staging: rtlwifi: Change line and comment spacing Maya Nakamura
2018-11-05 13:47 ` Greg KH [this message]
2018-11-08 8:20 ` Maya Nakamura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105134735.GC8389@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=m.maya.nakamura@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.