From: Sam Ravnborg <sam@ravnborg.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH] Add initial support for the EVB-KSZ9477 eval board
Date: Mon, 5 Nov 2018 14:56:20 +0100 [thread overview]
Message-ID: <20181105135620.GA22964@ravnborg.org> (raw)
In-Reply-To: <20181105073259.kz5bunbwfu7xtqlr@pengutronix.de>
On Mon, Nov 05, 2018 at 08:32:59AM +0100, Sascha Hauer wrote:
> Hi Sam,
>
> On Sat, Nov 03, 2018 at 12:31:12AM +0100, Sam Ravnborg wrote:
> > On Fri, Nov 02, 2018 at 10:07:43AM +0100, Sascha Hauer wrote:
> > > From: Ahmad Fatoum <a.fatoum@pengutronix.de>
> > >
> > > The EVB-KSZ9477 is an evaluation board for the KSZ9477 ethernet switch.
> > > This board is equipped with a atsama5d3 SoC with 256MiB of SDRAM, 256MiB
> > > of NAND flash and a SD card slot.
> > >
> > > For now only second stage booting is supported with AT91bootstrap as
> > > first stage loader.
> > Reminds me...
> >
> > I have noticed a brown-paper-bug introduced by me that would
> > hurt first stage bootloaders.
> > But only for at91sam926x boards I think, that this is likely not
> > considered.
>
>
> > +#define at91_sdramc_write(field, value) \
> > + __raw_writel((value), cfg->sdramc + (field))
>
> I prefer using plain __raw_writel rather than creating a new wrapper.
> The reason is a series I created that gets rid of these kind of wrappers
> in AT91 which decide during compile time on which SoC we are running.
> The above is not one of these, but I think doing it without accessors
> fits better into the series I created.
Fine, and thanks a lot for taking care of this!
Sam
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-11-05 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 9:07 [PATCH] Add initial support for the EVB-KSZ9477 eval board Sascha Hauer
2018-11-02 23:31 ` Sam Ravnborg
2018-11-05 7:32 ` Sascha Hauer
2018-11-05 13:56 ` Sam Ravnborg [this message]
2018-11-07 13:37 ` Roland Hieber
2018-11-07 20:57 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105135620.GA22964@ravnborg.org \
--to=sam@ravnborg.org \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.