From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm/atomic: Use explicit old crtc state in drm_atomic_add_affected_planes() Date: Mon, 5 Nov 2018 16:04:56 +0200 Message-ID: <20181105140456.GK9144@intel.com> References: <20181101184646.14753-1-ville.syrjala@linux.intel.com> <20181105092601.GF21967@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181105092601.GF21967@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBOb3YgMDUsIDIwMTggYXQgMTA6MjY6MDFBTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUaHUsIE5vdiAwMSwgMjAxOCBhdCAwODo0Njo0NFBNICswMjAwLCBWaWxsZSBT eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gUmVwbGFjZSAnY3J0Yy0+c3RhdGUnIHdpdGggdGhlIGV4 cGxpY2l0IG9sZCBjcnRjIHN0YXRlLgo+ID4gCj4gPiBBY3R1YWxseSBpdCBzaG91bGRuJ3QgbWF0 dGVyIHdoZXRoZXIgd2UgdXNlIHRoZSBvbGQgb3IgdGhlIG5ldwo+ID4gY3J0YyBzdGF0ZSBoZXJl IHNpbmNlIGFueSBwbGFuZSB0aGF0IGhhcyBiZWVuIHJlbW92ZWQgZnJvbSB0aGUKPiA+IGNydGMg c2luY2UgdGhlIGNydGMgc3RhdGUgd2FzIGR1cGxpY2F0ZWQgd2lsbCBoYXZlIGJlZW4gYWRkZWQK PiA+IHRvIHRoZSBhdG9taWMgc3RhdGUgYWxyZWFkeS4gVGhhdCBpcywgeW91IGNhbid0IGNhbGwK PiA+IGRybV9hdG9taWNfc2V0X2NydGNfZm9yX3BsYW5lKCkgd2l0aG91dCBoYXZpbmcgdGhlIG5l dwo+ID4gcGxhbmUgc3RhdGUgYWxyZWFkeSBpbiBoYW5kLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5 OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IAo+IEkg dGhpbmsgdGhpcyB3aWxsIGJyZWFrIGFtZGdwdV9ub3RpZnlfZnJlZXN5bmMgYmVjYXVzZSB0aGF0 IGRvZXNuJ3QgZ3JhYgo+IHRoZSBjcnRjIHN0YXRlIGZpcnN0LiBXaGljaCB3b3JrZWQgd2l0aCB0 aGUgb2xkIHN0dWZmLCBiZWNhdXNlIGFkZGluZyBhCj4gY29ubmVjdG9yIG9yIHBsYW5lIHdpbGwg YWxzbyBhZGQgaXQncyBjcnRjLiBCdXQgd2l0aCB0aGUgbmV3IGxvZ2ljIHdlJ2xsCj4ganVzdCBv b3BzIEkgdGhpbmsuCgpkcm1fYXRvbWljX2FkZF9hZmZlY3RlZF9jb25uZWN0b3JzKCkgd2lsbCBh ZGQgdGhlIGNydGMgdG8gdGhlCnN0YXRlLiBTbyBsb29rcyBsaWtlIGl0IHNob3VsZG4ndCBvb3Bz LgoKPiAKPiBPdG9oLCBpdCdzIGRlYWQgY29kZSwgc28gd2hhdCBleGFjdGx5IGFyZSBhbWQgcGVv cGxlIGRvaW5nIGFnYWluIDotKQoKSGVoLiBUaGFua3MgZm9yIHRoZSByZXZpZXcuCgo+IAo+IEFk ZGluZyBIYXJyeSBzbyBoZSdzIGF3YXJlLCBidXQgcGF0Y2ggaGVyZSBsb29rcyBnb29kLgo+IAo+ IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4g LS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyB8IDQgKysrLQo+ID4gIDEgZmls ZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pYy5jCj4gPiBpbmRleCAzZGJmYmRkYWU3ZTYuLjA2NGM0ODA3NTkxNyAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fYXRvbWljLmMKPiA+IEBAIC05MjcsNiArOTI3LDggQEAgaW50Cj4gPiAgZHJtX2F0 b21pY19hZGRfYWZmZWN0ZWRfcGxhbmVzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwK PiA+ICAJCQkgICAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ID4gIHsKPiA+ICsJY29uc3Qg c3RydWN0IGRybV9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSA9Cj4gPiArCQlkcm1fYXRvbWlj X2dldF9vbGRfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gPiAgCXN0cnVjdCBkcm1fcGxhbmUg KnBsYW5lOwo+ID4gIAo+ID4gIAlXQVJOX09OKCFkcm1fYXRvbWljX2dldF9uZXdfY3J0Y19zdGF0 ZShzdGF0ZSwgY3J0YykpOwo+ID4gQEAgLTkzNCw3ICs5MzYsNyBAQCBkcm1fYXRvbWljX2FkZF9h ZmZlY3RlZF9wbGFuZXMoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ID4gIAlEUk1f REVCVUdfQVRPTUlDKCJBZGRpbmcgYWxsIGN1cnJlbnQgcGxhbmVzIGZvciBbQ1JUQzolZDolc10g dG8gJXBcbiIsCj4gPiAgCQkJIGNydGMtPmJhc2UuaWQsIGNydGMtPm5hbWUsIHN0YXRlKTsKPiA+ ICAKPiA+IC0JZHJtX2Zvcl9lYWNoX3BsYW5lX21hc2socGxhbmUsIHN0YXRlLT5kZXYsIGNydGMt PnN0YXRlLT5wbGFuZV9tYXNrKSB7Cj4gPiArCWRybV9mb3JfZWFjaF9wbGFuZV9tYXNrKHBsYW5l LCBzdGF0ZS0+ZGV2LCBvbGRfY3J0Y19zdGF0ZS0+cGxhbmVfbWFzaykgewo+ID4gIAkJc3RydWN0 IGRybV9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUgPQo+ID4gIAkJCWRybV9hdG9taWNfZ2V0X3Bs YW5lX3N0YXRlKHN0YXRlLCBwbGFuZSk7Cj4gPiAgCj4gPiAtLSAKPiA+IDIuMTguMQo+ID4gCj4g PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gZHJp LWRldmVsIG1haWxpbmcgbGlzdAo+ID4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwKPiAKPiAtLSAKPiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENv cnBvcmF0aW9uCj4gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50 ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==