From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,1/2] dt-bindings: dmaengine: dw-dmac: add protection control property From: Andy Shevchenko Message-Id: <20181105142336.GH10650@smile.fi.intel.com> Date: Mon, 5 Nov 2018 16:23:36 +0200 To: Christian Lamparter Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org, Dan Williams , Vinod Koul , Viresh Kumar , Rob Herring , Mark Rutland List-ID: T24gU3VuLCBOb3YgMDQsIDIwMTggYXQgMDY6MDE6MzhQTSArMDEwMCwgQ2hyaXN0aWFuIExhbXBh cnRlciB3cm90ZToKPiBUaGlzIHBhdGNoIGFkZHMgdGhlIHBlci1jaGFubmVsIGRtYSBwcm90ZWN0 aW9uIGNvbnRyb2wKPiBwcm9wLWVuY29kZWQtYXJyYXkgYW5kIGR0LWJpbmRpbmcgZGVmaW5pdGlv bnMgKGluY2x1ZGluZwo+IGRlZmluaXRpb25zIGZvciB0aGUgZXhpc3RpbmcgY2hhbm5lbCBhbGxv Y2F0aW9uIGFuZCBwcmlvcml0eQo+IG9yZGVyIHZhbHVlcyBiYXNlZCBvbiBpbmNsdWRlL2xpbnV4 L3BsYXRmb3JtX2RhdGEvZG1hLWR3LmgpCj4gZm9yIHRoZSBEZXNpZ25XYXJlIEFIQiBDZW50cmFs IERpcmVjdCBNZW1vcnkgQWNjZXNzIENvbnRyb2xsZXIuCj4gCj4gTm90ZTogVGhlIHByb3RlY3Rp b24gY29udHJvbCBzaWduYWxzIGFyZSBvbmUtdG8tb25lIG1hcHBlZCB0bwo+IHRoZSBBSEIgSFBS T1RbMTozXSBzaWduYWxzLiAgVGhlIEhQUk9UMCAoRGF0YSBBY2Nlc3MpIGlzCj4gYWx3YXlzIGhh cmR3aXJlZCB0byAxIGZvciB0aGlzIGNvbnRyb2xsZXIuCj4gCgpSZXZpZXdlZC1ieTogQW5keSBT aGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+Cgo+IFNpZ25lZC1v ZmYtYnk6IENocmlzdGlhbiBMYW1wYXJ0ZXIgPGNodW5rZWV5QGdtYWlsLmNvbT4KPiAtLS0KPiAg Li4uL2RldmljZXRyZWUvYmluZGluZ3MvZG1hL3NucHMtZG1hLnR4dCAgICAgIHwgIDQgKysrKwo+ ICBNQUlOVEFJTkVSUyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgNCArKyst Cj4gIGluY2x1ZGUvZHQtYmluZGluZ3MvZG1hL2R3LWRtYWMuaCAgICAgICAgICAgICB8IDIwICsr KysrKysrKysrKysrKysrKysKPiAgMyBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAx IGRlbGV0aW9uKC0pCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL2R0LWJpbmRpbmdzL2Rt YS9kdy1kbWFjLmgKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2RtYS9zbnBzLWRtYS50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvZG1hL3NucHMtZG1hLnR4dAo+IGluZGV4IDM5ZTJiMjZiZTM0NC4uNzJiNDk4NGE0YzE4IDEw MDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEvc25wcy1k bWEudHh0Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RtYS9zbnBz LWRtYS50eHQKPiBAQCAtMjcsNiArMjcsMTAgQEAgT3B0aW9uYWwgcHJvcGVydGllczoKPiAgICBn ZW5lcmFsIHB1cnBvc2UgRE1BIGNoYW5uZWwgYWxsb2NhdG9yLiBGYWxzZSBpZiBub3QgcGFzc2Vk Lgo+ICAtIG11bHRpLWJsb2NrOiBNdWx0aSBibG9jayB0cmFuc2ZlcnMgc3VwcG9ydGVkIGJ5IGhh cmR3YXJlLiBBcnJheSBwcm9wZXJ0eSB3aXRoCj4gICAgb25lIGNlbGwgcGVyIGNoYW5uZWwuIDA6 IG5vdCBzdXBwb3J0ZWQsIDEgKGRlZmF1bHQpOiBzdXBwb3J0ZWQuCj4gKy0gc25wcyxkbWEtcHJv dGVjdGlvbi1jb250cm9sOiBDaGFubmVsJ3MgQUhCIEhQUk9UWzM6MV0gcHJvdGVjdGlvbiBzZXR0 aW5nLgo+ICsgIEFycmF5IHByb3BlcnR5IHdpdGggb25lIGNlbGwgcGVyIGNoYW5uZWwuIFRoZSBk ZWZhdWx0IHZhbHVlIGZvciBhIGNoYW5uZWwKPiArICBpcyAwIChmb3Igbm9uLWNhY2hlYWJsZSwg c3Ryb25nbHkgb3JkZXJlZCwgdW5wcml2aWxlZ2VkIGRhdGEgYWNjZXNzKS4KPiArICBSZWZlciB0 byBpbmNsdWRlL2R0LWJpbmRpbmdzL2RtYS9kdy1kbWFjLmggZm9yIHBvc3NpYmxlIHZhbHVlcy4K PiAgCj4gIEV4YW1wbGU6Cj4gIAo+IGRpZmYgLS1naXQgYS9NQUlOVEFJTkVSUyBiL01BSU5UQUlO RVJTCj4gaW5kZXggZGFjYmEyM2I4MGI0Li5jMzU5OThlMjBlOWQgMTAwNjQ0Cj4gLS0tIGEvTUFJ TlRBSU5FUlMKPiArKysgYi9NQUlOVEFJTkVSUwo+IEBAIC0xNDEwNyw5ICsxNDEwNywxMSBAQCBT WU5PUFNZUyBERVNJR05XQVJFIERNQUMgRFJJVkVSCj4gIE06CVZpcmVzaCBLdW1hciA8dmlyZXNo a0BrZXJuZWwub3JnPgo+ICBSOglBbmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2Y2hlbmtvQGxp bnV4LmludGVsLmNvbT4KPiAgUzoJTWFpbnRhaW5lZAo+ICtGOglEb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvZG1hL3NucHMtZG1hLnR4dAo+ICtGOglkcml2ZXJzL2RtYS9kdy8KPiAr RjoJaW5jbHVkZS9kdC1iaW5kaW5ncy9kbWEvZHctZG1hYy5oCj4gIEY6CWluY2x1ZGUvbGludXgv ZG1hL2R3LmgKPiAgRjoJaW5jbHVkZS9saW51eC9wbGF0Zm9ybV9kYXRhL2RtYS1kdy5oCj4gLUY6 CWRyaXZlcnMvZG1hL2R3Lwo+ICAKPiAgU1lOT1BTWVMgREVTSUdOV0FSRSBFTlRFUlBSSVNFIEVU SEVSTkVUIERSSVZFUgo+ICBNOglKb3NlIEFicmV1IDxKb3NlLkFicmV1QHN5bm9wc3lzLmNvbT4K PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kdC1iaW5kaW5ncy9kbWEvZHctZG1hYy5oIGIvaW5jbHVk ZS9kdC1iaW5kaW5ncy9kbWEvZHctZG1hYy5oCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRl eCAwMDAwMDAwMDAwMDAuLjkxNTJhNmUyNDA2Ywo+IC0tLSAvZGV2L251bGwKPiArKysgYi9pbmNs dWRlL2R0LWJpbmRpbmdzL2RtYS9kdy1kbWFjLmgKPiBAQCAtMCwwICsxLDIwIEBACj4gKy8qIFNQ RFgtTGljZW5zZS1JZGVudGlmaWVyOiAoR1BMLTIuMCBPUiBNSVQpICovCj4gKwo+ICsjaWZuZGVm IF9fRFRfQklORElOR1NfRE1BX0RXX0RNQUNfSF9fCj4gKyNkZWZpbmUgX19EVF9CSU5ESU5HU19E TUFfRFdfRE1BQ19IX18KPiArCj4gKyNkZWZpbmUgRFdfRE1BQ19DSEFOX0FMTE9DQVRJT05fQVND RU5ESU5HICAgICAgIDAgICAgICAgLyogemVybyB0byBzZXZlbiAqLwo+ICsjZGVmaW5lIERXX0RN QUNfQ0hBTl9BTExPQ0FUSU9OX0RFU0NFTkRJTkcgICAgICAxICAgICAgIC8qIHNldmVuIHRvIHpl cm8gKi8KPiArI2RlZmluZSBEV19ETUFDX0NIQU5fUFJJT1JJVFlfQVNDRU5ESU5HICAgICAgICAg MCAgICAgICAvKiBjaGFuMCBoaWdoZXN0ICovCj4gKyNkZWZpbmUgRFdfRE1BQ19DSEFOX1BSSU9S SVRZX0RFU0NFTkRJTkcgICAgICAgIDEgICAgICAgLyogY2hhbjcgaGlnaGVzdCAqLwo+ICsKPiAr LyoKPiArICogUHJvdGVjdGlvbiBDb250cm9sIGJpdHMgcHJvdmlkZSBwcm90ZWN0aW9uIGFnYWlu c3QgaWxsZWdhbCB0cmFuc2FjdGlvbnMuCj4gKyAqIFRoZSBwcm90ZWN0aW9uIGJpdHNbMDoyXSBh cmUgb25lLXRvLW9uZSBtYXBwZWQgdG8gQUhCIEhQUk9UWzM6MV0gc2lnbmFscy4KPiArICogVGhl IEFIQiBIUFJPVFswXSBiaXQgaXMgaGFyZHdpcmVkIHRvIDE6IERhdGEgQWNjZXNzLgo+ICsgKi8K PiArI2RlZmluZSBEV19ETUFDX0hQUk9UMV9QUklWSUxFR0VEX01PREUJKDEgPDwgMCkJLyogUHJp dmlsZWdlZCBNb2RlICovCj4gKyNkZWZpbmUgRFdfRE1BQ19IUFJPVDJfQlVGRkVSQUJMRQkoMSA8 PCAxKQkvKiBETUEgaXMgYnVmZmVyYWJsZSAqLwo+ICsjZGVmaW5lIERXX0RNQUNfSFBST1QzX0NB Q0hFQUJMRQkoMSA8PCAyKQkvKiBETUEgaXMgY2FjaGVhYmxlICovCj4gKwo+ICsjZW5kaWYgLyog X19EVF9CSU5ESU5HU19ETUFfRFdfRE1BQ19IX18gKi8KPiAtLSAKPiAyLjE5LjEKPgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 5 Nov 2018 16:23:36 +0200 From: Andy Shevchenko Subject: Re: [PATCH v1 1/2] dt-bindings: dmaengine: dw-dmac: add protection control property Message-ID: <20181105142336.GH10650@smile.fi.intel.com> References: <6b18bcf33d6473c166b607a5fa31ba63727cf6bb.1541350844.git.chunkeey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b18bcf33d6473c166b607a5fa31ba63727cf6bb.1541350844.git.chunkeey@gmail.com> To: Christian Lamparter Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org, Dan Williams , Vinod Koul , Viresh Kumar , Rob Herring , Mark Rutland List-ID: On Sun, Nov 04, 2018 at 06:01:38PM +0100, Christian Lamparter wrote: > This patch adds the per-channel dma protection control > prop-encoded-array and dt-binding definitions (including > definitions for the existing channel allocation and priority > order values based on include/linux/platform_data/dma-dw.h) > for the DesignWare AHB Central Direct Memory Access Controller. > > Note: The protection control signals are one-to-one mapped to > the AHB HPROT[1:3] signals. The HPROT0 (Data Access) is > always hardwired to 1 for this controller. > Reviewed-by: Andy Shevchenko > Signed-off-by: Christian Lamparter > --- > .../devicetree/bindings/dma/snps-dma.txt | 4 ++++ > MAINTAINERS | 4 +++- > include/dt-bindings/dma/dw-dmac.h | 20 +++++++++++++++++++ > 3 files changed, 27 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/dma/dw-dmac.h > > diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt b/Documentation/devicetree/bindings/dma/snps-dma.txt > index 39e2b26be344..72b4984a4c18 100644 > --- a/Documentation/devicetree/bindings/dma/snps-dma.txt > +++ b/Documentation/devicetree/bindings/dma/snps-dma.txt > @@ -27,6 +27,10 @@ Optional properties: > general purpose DMA channel allocator. False if not passed. > - multi-block: Multi block transfers supported by hardware. Array property with > one cell per channel. 0: not supported, 1 (default): supported. > +- snps,dma-protection-control: Channel's AHB HPROT[3:1] protection setting. > + Array property with one cell per channel. The default value for a channel > + is 0 (for non-cacheable, strongly ordered, unprivileged data access). > + Refer to include/dt-bindings/dma/dw-dmac.h for possible values. > > Example: > > diff --git a/MAINTAINERS b/MAINTAINERS > index dacba23b80b4..c35998e20e9d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14107,9 +14107,11 @@ SYNOPSYS DESIGNWARE DMAC DRIVER > M: Viresh Kumar > R: Andy Shevchenko > S: Maintained > +F: Documentation/devicetree/bindings/dma/snps-dma.txt > +F: drivers/dma/dw/ > +F: include/dt-bindings/dma/dw-dmac.h > F: include/linux/dma/dw.h > F: include/linux/platform_data/dma-dw.h > -F: drivers/dma/dw/ > > SYNOPSYS DESIGNWARE ENTERPRISE ETHERNET DRIVER > M: Jose Abreu > diff --git a/include/dt-bindings/dma/dw-dmac.h b/include/dt-bindings/dma/dw-dmac.h > new file mode 100644 > index 000000000000..9152a6e2406c > --- /dev/null > +++ b/include/dt-bindings/dma/dw-dmac.h > @@ -0,0 +1,20 @@ > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ > + > +#ifndef __DT_BINDINGS_DMA_DW_DMAC_H__ > +#define __DT_BINDINGS_DMA_DW_DMAC_H__ > + > +#define DW_DMAC_CHAN_ALLOCATION_ASCENDING 0 /* zero to seven */ > +#define DW_DMAC_CHAN_ALLOCATION_DESCENDING 1 /* seven to zero */ > +#define DW_DMAC_CHAN_PRIORITY_ASCENDING 0 /* chan0 highest */ > +#define DW_DMAC_CHAN_PRIORITY_DESCENDING 1 /* chan7 highest */ > + > +/* > + * Protection Control bits provide protection against illegal transactions. > + * The protection bits[0:2] are one-to-one mapped to AHB HPROT[3:1] signals. > + * The AHB HPROT[0] bit is hardwired to 1: Data Access. > + */ > +#define DW_DMAC_HPROT1_PRIVILEGED_MODE (1 << 0) /* Privileged Mode */ > +#define DW_DMAC_HPROT2_BUFFERABLE (1 << 1) /* DMA is bufferable */ > +#define DW_DMAC_HPROT3_CACHEABLE (1 << 2) /* DMA is cacheable */ > + > +#endif /* __DT_BINDINGS_DMA_DW_DMAC_H__ */ > -- > 2.19.1 > -- With Best Regards, Andy Shevchenko