All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/4] device property: Introduce fwnode_name()
Date: Mon, 5 Nov 2018 16:57:33 +0200	[thread overview]
Message-ID: <20181105145733.GA1777@kuha.fi.intel.com> (raw)
In-Reply-To: <20181105143731.GK10650@smile.fi.intel.com>

Hi,

> > +const char *fwnode_name(const struct fwnode_handle *fwnode)
> > +{
> > +	const char *name = fwnode_call_ptr_op(fwnode, name);
> > +
> > +	if (!name)
> > +		fwnode_call_int_op(fwnode, property_read_string_array,
> > +				   "name", &name, 1);
> 
> Is it going to be extended in the future?
> 
> Otherwise I would rather go with (few more LOCs, yes)
> 
> 	const char *name;
> 
> 	name = fwnode_call_ptr_op(fwnode, name);
> 	if (name)
> 		return name;
> 
> 	fwnode_call_int_op(fwnode, property_read_string_array, "name", &name, 1);
> 	return name;

That does look better. I'll fix it.

thanks,

-- 
heikki

  reply	other threads:[~2018-11-05 14:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05  9:17 [PATCH 0/4] device property: Add fwnode_name() helper Heikki Krogerus
2018-11-05  9:17 ` [PATCH 1/4] device property: Introduce fwnode_name() Heikki Krogerus
2018-11-05 14:37   ` Andy Shevchenko
2018-11-05 14:57     ` Heikki Krogerus [this message]
2018-11-05  9:17 ` [PATCH 2/4] ACPI: property: Introduce acpi_fwnode_name() Heikki Krogerus
2018-11-05  9:17 ` [PATCH 3/4] of/property: Introduce of_fwnode_name() Heikki Krogerus
2018-11-05 18:50   ` Rob Herring
2018-11-06  8:45     ` Heikki Krogerus
2018-11-06 10:58     ` Andy Shevchenko
2018-11-06 12:27       ` Heikki Krogerus
2018-11-06 13:18         ` Rob Herring
2018-11-06 14:28           ` Andy Shevchenko
2018-11-06 18:17             ` Rob Herring
2018-11-06 14:40           ` Heikki Krogerus
2018-11-06 14:55             ` Andy Shevchenko
2018-11-06 15:05               ` Heikki Krogerus
2018-11-06 15:53                 ` Andy Shevchenko
2018-11-06 18:13                   ` Rob Herring
2018-11-07 12:35                     ` Heikki Krogerus
2018-11-05  9:17 ` [PATCH 4/4] device property: Drop get_named_child_node callback Heikki Krogerus
2018-11-05 14:38 ` [PATCH 0/4] device property: Add fwnode_name() helper Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181105145733.GA1777@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.