From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Junchang Wang <junchangwang@gmail.com>
Cc: akiyks@gmail.com, perfbook@vger.kernel.org
Subject: Re: [PATCH 1/2] memorder: fix typo
Date: Mon, 5 Nov 2018 11:45:42 -0800 [thread overview]
Message-ID: <20181105194542.GZ4170@linux.ibm.com> (raw)
In-Reply-To: <1541330319-14491-2-git-send-email-junchangwang@gmail.com>
On Sun, Nov 04, 2018 at 07:18:38PM +0800, Junchang Wang wrote:
> Fix typos in memorder.tex.
>
> Signed-off-by: Junchang Wang <junchangwang@gmail.com>
You know, I have no idea what litmus test I was describing in that
paragraph, but it certainly wasn't the one in Listing 15.17. :-/
I adjusted things a bit more, so please see below and let me know if
I messed anything up.
Thanx, Paul
------------------------------------------------------------------------
commit 73f0f6583b154f2cd9280f321e87dcaabe6b1221
Author: Junchang Wang <junchangwang@gmail.com>
Date: Sun Nov 4 19:18:38 2018 +0800
memorder: Fix typo
Fix typos in memorder.tex, including a very confused paragraph that
seems to be referring to some prior version of Listing 15.17.
Signed-off-by: Junchang Wang <junchangwang@gmail.com>
[ paulmck: Adjusted rewording of Listing 15.17 discussion. ]
Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
diff --git a/memorder/memorder.tex b/memorder/memorder.tex
index 8e11e92153e0..5e74a912e15d 100644
--- a/memorder/memorder.tex
+++ b/memorder/memorder.tex
@@ -1364,7 +1364,7 @@ The head pointer is \co{x1}, which initially
references the \co{int} variable \co{y} (line~5), which is in turn
initialized to the value $1$ (line~4).
\co{P0()} updates head pointer \co{x1} to reference \co{x0} (line~12),
-but only afer initializing it to $2$ (line~10) and forcing ordering
+but only after initializing it to $2$ (line~10) and forcing ordering
(line~11).
\co{P1()} picks up the head pointer \co{x1} (line~21), and then loads
the referenced value (line~22).
@@ -2294,9 +2294,9 @@ These ordering constraints are depicted graphically in
Figure~\ref{fig:memorder:Cumulativity}.
Note also that cumulativity is not limited to a single step back in time.
If there was another load from \co{x} or store to \co{x} from any thread
-that came before the store on line~13, that prior load or store would also
-be ordered before the store on line~32, though only if both \co{r1} and
-\co{r2} both end up containing the address of \co{x}.
+that came before the store on line~8, that prior load or store would also
+be ordered before the load on line~25, though only if both \co{r1} and
+\co{r2} both end up containing the value \co{1}.
In short, use of cumulative ordering operations can suppress
non-multicopy-atomic behaviors in some situations.
next prev parent reply other threads:[~2018-11-06 5:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 11:18 [PATCH 0/2] Updates to Chapter memorder Junchang Wang
2018-11-04 11:18 ` [PATCH 1/2] memorder: fix typo Junchang Wang
2018-11-05 19:45 ` Paul E. McKenney [this message]
2018-11-06 6:15 ` Junchang Wang
2018-11-04 11:18 ` [PATCH 2/2] memorybarriercum.svg: " Junchang Wang
2018-11-05 19:48 ` Paul E. McKenney
2018-11-04 12:04 ` [PATCH 0/2] Updates to Chapter memorder Akira Yokosawa
2018-11-05 19:50 ` Paul E. McKenney
2018-11-06 6:18 ` Junchang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105194542.GZ4170@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=akiyks@gmail.com \
--cc=junchangwang@gmail.com \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.