From: Tony Lindgren <tony@atomide.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-omap@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time
Date: Mon, 5 Nov 2018 12:15:27 -0800 [thread overview]
Message-ID: <20181105201527.GG56754@atomide.com> (raw)
In-Reply-To: <7868635.QLJqmcCUzE@avalon>
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [181105 15:14]:
> Hi Tony,
>
> On Thursday, 1 November 2018 18:17:43 EET Laurent Pinchart wrote:
> > On Thursday, 1 November 2018 17:58:56 EET Tony Lindgren wrote:
> > > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [181101 12:13]:
> > >> On Thursday, 1 November 2018 13:47:40 EET Tomi Valkeinen wrote:
> > >>> We do dispc_runtime_get/put in the HDMI driver's suspend/resume too,
> > >>> so don't we need similar hack (as you add in dsi.c) there also?
> > >>
> > >> We would if we had to access HDMI registers at probe time.
> > >
> > > With these I'm still seeing the following issue with hdmi on rmmod
> > > of omapdrm related modules as hdmi->dss is NULL in hdmi_runtime_resume.
> >
> > This is actually what I expected, but to my surprise the problem didn't
> > occur on my system, I don't know why. I'll try to investigate.
>
> I've submitted a v2 which should hopefully fix this.
Yes thanks seems to fix it, noticed one issue there though
for hdmi.
Regards,
Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-11-05 20:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 10:25 [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time Laurent Pinchart
2018-11-01 10:25 ` [PATCH 1/3] drm/omap: Populate DSS children in omapdss driver Laurent Pinchart
2018-11-01 10:25 ` [PATCH 2/3] drm/omap: hdmi4: Ensure the device is active during bind Laurent Pinchart
2018-11-01 10:25 ` [PATCH 3/3] drm/omap: dsi: Ensure the device is active during probe Laurent Pinchart
2018-11-01 11:47 ` [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time Tomi Valkeinen
2018-11-01 12:13 ` Laurent Pinchart
2018-11-01 12:56 ` Tomi Valkeinen
2018-11-01 15:58 ` Tony Lindgren
2018-11-01 16:17 ` Laurent Pinchart
2018-11-05 15:14 ` Laurent Pinchart
2018-11-05 20:15 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105201527.GG56754@atomide.com \
--to=tony@atomide.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.