From: Rob Herring <robh@kernel.org>
To: Doug Anderson <dianders@google.com>
Cc: vbadigan@codeaurora.org, Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Evan Green <evgreen@chromium.org>,
Asutosh Das <asutoshd@codeaurora.org>,
riteshh@codeaurora.org, stummala@codeaurora.org,
sayalil@codeaurora.org, Mark Rutland <mark.rutland@arm.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 1/2] dt-bindings: mmc: sdhci-msm: Add new compatible string for SDM845 SOC
Date: Mon, 5 Nov 2018 14:36:57 -0600 [thread overview]
Message-ID: <20181105203657.GA32282@bogus> (raw)
In-Reply-To: <CAD=FV=V9AdCgOSonb0tu==DgKRKeZxto+aGwxmdbHAqrmfMrDQ@mail.gmail.com>
On Thu, Nov 01, 2018 at 01:29:54PM -0700, Doug Anderson wrote:
> Hi,
>
> On Thu, Nov 1, 2018 at 5:07 AM Veerabhadrarao Badiganti
> <vbadigan@codeaurora.org> wrote:
> >
> > For SDM845 SOC, new compatible string "qcom,sdm845-sdhci" is added.
> >
> > Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> > ---
> > Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> > index 502b3b8..f2ffbeb 100644
> > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> > @@ -7,6 +7,7 @@ Required properties:
> > - compatible: Should contain:
> > "qcom,sdhci-msm-v4" for sdcc versions less than 5.0
> > "qcom,sdhci-msm-v5" for sdcc versions >= 5.0
> > + "qcom,sdm845-sdhci" for sdm845 SOC
>
> It's up to Rob of course, but IMO it seems a nicer way forward to
> include both the SoC-specific string and the "version" string in all
> cases. I'd write this for the full text:
Fine by me if you update all the dts files.
>
> - compatible: Should contain a SoC-specific string and a IP version string:
> version strings:
> "qcom,sdhci-msm-v4" for sdcc versions less than 5.0
> "qcom,sdhci-msm-v5" for sdcc version 5.0
> full compatible strings with SoC and version:
> "qcom,apq8084", "qcom,sdhci-msm-v4"
> "qcom,msm8974", "qcom,sdhci-msm-v4"
> "qcom,msm8916", "qcom,sdhci-msm-v4"
> "qcom,msm8992", "qcom,sdhci-msm-v4"
> "qcom,msm8996", "qcom,sdhci-msm-v4"
I assume you meant to append '-sdhci' here?
> "qcom,sdm845-sdhci", "qcom,sdhci-msm-v5"
>
> NOTE that some old device tree files may be floating around that only
> have the string "qcom,sdhci-msm-v4" without the SoC compatible string
> but doing that should be considered a deprecated practice.
>
> -Doug
next prev parent reply other threads:[~2018-11-05 20:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1541073999-11752-1-git-send-email-vbadigan@codeaurora.org>
2018-11-01 12:06 ` [PATCH V3 1/2] dt-bindings: mmc: sdhci-msm: Add new compatible string for SDM845 SOC Veerabhadrarao Badiganti
2018-11-01 12:06 ` Veerabhadrarao Badiganti
2018-11-01 20:29 ` Doug Anderson
2018-11-05 20:36 ` Rob Herring [this message]
2018-11-05 21:11 ` Doug Anderson
2018-11-06 17:59 ` Veerabhadrarao Badiganti
2018-11-01 12:06 ` [PATCH V3 2/2] mmc: sdhci-msm: Re-initialize DLL if MCLK is gated dynamically Veerabhadrarao Badiganti
2018-11-01 17:10 ` Evan Green
2018-11-01 20:16 ` Doug Anderson
2018-11-01 20:33 ` Doug Anderson
2018-11-06 17:51 ` Veerabhadrarao Badiganti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105203657.GA32282@bogus \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=evgreen@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=riteshh@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.