All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jordan Crouse <jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org
Subject: [PATCH v2 00/11] DPU cleanups
Date: Mon,  5 Nov 2018 16:30:52 -0700	[thread overview]
Message-ID: <20181105233103.7657-1-jcrouse@codeaurora.org> (raw)

I've been working on various methods to automate code cleanup strategies
and I'm using dpu as my guinea pig. I started out by trying to identify
unused or lightly static inline functions and then that morphed to 
very small functions in general and that then identified a few general
areas of cleanup such as debugfs init/destroy and the dpu_hw_blk_init
users.

Changes in v2: Addressed review comments (thanks!) and added even more
debugfs cleanup

Jordan Crouse (11):
  drm/msm/dpu: Remove dpu_dbg
  drm/msm/dpu: Use DEFINE_SHOW_ATTRIBUTE
  drm/msm/dpu: Remove dpu_crtc_get_mixer_height
  drm/msm/dpu: Remove dpu_crtc_is_enabled()
  drm/msm/dpu: Remove unused functions
  drm/msm/dpu: Cleanup callers of dpu_hw_blk_init
  drm/msm: Make irq_postinstall optional
  drm/msm/dpu: Remove dpu_irq and unused functions
  drm/msm/dpu: Cleanup the debugfs functions
  drm/msm/dpu: Further cleanups for static inline functions
  drm/msm/dpu: Clean up dpu_media_info.h static inline functions

 drivers/gpu/drm/msm/Makefile                  |    4 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c  |   59 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h  |   16 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c |  122 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h |    7 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c      |   76 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h      |   32 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c       | 2393 -----------------
 drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.h       |  103 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c   |   55 +-
 .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h  |    2 +-
 .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c  |   12 +-
 .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c  |    1 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c    |   10 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h    |    2 +-
 .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h    |    9 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c    |   18 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c   |   18 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h   |   10 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c     |   24 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h     |    5 -
 .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c   |   18 +-
 .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h   |   10 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c   |   21 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h   |   10 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c    |   20 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h    |   10 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c   |    1 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c       |   66 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h       |   59 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       |  188 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h       |    8 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c      |    8 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c     |  108 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c      |   24 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.h      |   15 +-
 .../gpu/drm/msm/disp/dpu1/msm_media_info.h    |  164 +-
 drivers/gpu/drm/msm/msm_drv.c                 |    6 +-
 38 files changed, 235 insertions(+), 3479 deletions(-)
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.h
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.c
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_irq.h

-- 
2.18.0

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

             reply	other threads:[~2018-11-05 23:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05 23:30 Jordan Crouse [this message]
2018-11-05 23:30 ` [PATCH 01/11] drm/msm/dpu: Remove dpu_dbg Jordan Crouse
     [not found]   ` <20181105233103.7657-2-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-11-06 14:22     ` Sean Paul
     [not found] ` <20181105233103.7657-1-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-11-05 23:30   ` [PATCH 02/11] drm/msm/dpu: Use DEFINE_SHOW_ATTRIBUTE Jordan Crouse
2018-11-06 14:28     ` Sean Paul
2018-11-05 23:30   ` [PATCH 03/11] drm/msm/dpu: Remove dpu_crtc_get_mixer_height Jordan Crouse
     [not found]     ` <20181105233103.7657-4-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-11-06 14:30       ` Sean Paul
2018-11-05 23:30   ` [PATCH 04/11] drm/msm/dpu: Remove dpu_crtc_is_enabled() Jordan Crouse
2018-11-06 14:31     ` Sean Paul
2018-11-05 23:30   ` [PATCH 05/11] drm/msm/dpu: Remove unused functions Jordan Crouse
2018-11-06 14:31     ` Sean Paul
2018-11-05 23:30   ` [PATCH 06/11] drm/msm/dpu: Cleanup callers of dpu_hw_blk_init Jordan Crouse
     [not found]     ` <20181105233103.7657-7-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-11-06 14:45       ` Sean Paul
2018-11-05 23:30   ` [PATCH 07/11] drm/msm: Make irq_postinstall optional Jordan Crouse
     [not found]     ` <20181105233103.7657-8-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-11-06 14:46       ` Sean Paul
2018-11-05 23:31   ` [PATCH 08/11] drm/msm/dpu: Remove dpu_irq and unused functions Jordan Crouse
     [not found]     ` <20181105233103.7657-9-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-11-06 14:46       ` Sean Paul
2018-11-05 23:31   ` [PATCH 09/11] drm/msm/dpu: Cleanup the debugfs functions Jordan Crouse
     [not found]     ` <20181105233103.7657-10-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-11-06 15:05       ` Sean Paul
2018-11-05 23:31   ` [PATCH 11/11] drm/msm/dpu: Clean up dpu_media_info.h static inline functions Jordan Crouse
     [not found]     ` <20181105233103.7657-12-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-11-06 15:13       ` Sean Paul
2018-11-06 16:16       ` Sam Ravnborg
2018-11-07 19:55   ` [PATCH v3 1/2] drm/msm/dpu: Further cleanups for " Jordan Crouse
     [not found]     ` <20181107195503.12204-1-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-11-07 19:55       ` [PATCH v3 2/2] drm/msm/dpu: Clean up dpu_media_info.h " Jordan Crouse
2018-11-05 23:31 ` [PATCH 10/11] drm/msm/dpu: Further cleanups for " Jordan Crouse
2018-11-06 15:12   ` Sean Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181105233103.7657-1-jcrouse@codeaurora.org \
    --to=jcrouse-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
    --cc=abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org \
    --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.