From: Mike Rapoport <rppt@linux.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Matthew Wilcox <willy@infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org,
Mike Rapoport <rppt@linux.vnet.ibm.com>
Subject: Re: [PATCH] docs/admin-guide/mm/concepts.rst: grammar fixups
Date: Tue, 6 Nov 2018 10:20:09 +0200 [thread overview]
Message-ID: <20181106082009.GA28505@rapoport-lnx> (raw)
In-Reply-To: <19eb9ca8-d285-3ea9-faa5-f996a462f138@infradead.org>
On Mon, Nov 05, 2018 at 11:29:27PM -0800, Randy Dunlap wrote:
> On 11/5/18 10:35 PM, Mike Rapoport wrote:
> > On Mon, Nov 05, 2018 at 01:12:40PM -0800, Matthew Wilcox wrote:
> >> On Mon, Nov 05, 2018 at 09:58:15PM +0200, Mike Rapoport wrote:
> >>> @@ -21,10 +21,10 @@ Virtual Memory Primer
> >>> The physical memory in a computer system is a limited resource and
> >>> even for systems that support memory hotplug there is a hard limit on
> >>> the amount of memory that can be installed. The physical memory is not
> >>> -necessary contiguous, it might be accessible as a set of distinct
> >>> +necessary contiguous; it might be accessible as a set of distinct
> >>
> >> necessarily
> >>
> >>> address ranges. Besides, different CPU architectures, and even
> >>> -different implementations of the same architecture have different view
> >>> -how these address ranges defined.
> >>> +different implementations of the same architecture have different views
> >>> +of how these address ranges defined.
> >>
> >> "are defined"?
> >>
> >>> Each physical memory page can be mapped as one or more virtual
> >>> pages. These mappings are described by page tables that allow
> >>> -translation from virtual address used by programs to real address in
> >>> -the physical memory. The page tables organized hierarchically.
> >>> +translation from a virtual address used by programs to the real
> >>> +address in the physical memory. The page tables are organized
> >>> +hierarchically.
> >>
> >> I don't like the term "real address". Can we say "physical address in memory" here, or "address of physical memory" or something?
> >
> > I didn't really like it as well, but I couldn't think of any better
> > adjective to emphasize that address in the physical memory is "the real
> > thing".
> >
> > Maybe the best would be to drop "real" and make it
> >
> > "translation from a virtual address used by programs to the
> > address in the physical memory"
>
> physical memory address ?
Works for me, thanks!
>
> --
> ~Randy
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2018-11-06 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 19:58 [PATCH] docs/admin-guide/mm/concepts.rst: grammar fixups Mike Rapoport
2018-11-05 21:00 ` Randy Dunlap
2018-11-05 21:12 ` Matthew Wilcox
2018-11-06 6:35 ` Mike Rapoport
2018-11-06 7:29 ` Randy Dunlap
2018-11-06 8:20 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106082009.GA28505@rapoport-lnx \
--to=rppt@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.