From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"yipeng1.wang@intel.com" <yipeng1.wang@intel.com>,
Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
nd <nd@arm.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>,
"Kapoor, Prasun" <Prasun.Kapoor@cavium.com>
Subject: Re: [PATCH v7 4/5] hash: add lock-free read-write concurrency
Date: Tue, 6 Nov 2018 09:47:29 +0000 [thread overview]
Message-ID: <20181106094715.GA12863@jerin> (raw)
In-Reply-To: <4202399.UOW9WdkMPh@xps>
-----Original Message-----
> Date: Tue, 06 Nov 2018 10:13:53 +0100
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
> "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
> "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
> "dev@dpdk.org" <dev@dpdk.org>, "yipeng1.wang@intel.com"
> <yipeng1.wang@intel.com>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
> "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, nd <nd@arm.com>,
> "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
> "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
> "chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>, "Kapoor,
> Prasun" <Prasun.Kapoor@cavium.com>
> Subject: Re: [dpdk-dev] [PATCH v7 4/5] hash: add lock-free read-write
> concurrency
>
> 06/11/2018 10:10, Jerin Jacob:
> > From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> > > Jerin, thank you for running this test and all the analysis. I have not run this test. I was focused on simultaneous reads and writes. You can look at file test_hash_readwrite_lf.c to look for the kind of the use cases.
> > >
> > > I am trying to reproduce this, I will get back with more details soon.
> >
> > OK. Since RC2 approaching, bit worried about next steps if we cannot
> > avoid the regression with this new feature for this release.
>
> 18.11-rc2 is already out.
>
> > 24% drop of performance regression not seen in past for a specific
> > usecase.So not sure what we did past for similar situations.
> >
> > Thomas,
> > Any thought of this?
>
> Everything is possible, you just need to agree on a patch.
> Please let's fix (or disable or revert) it in -rc3 this week.
I let Honnappa to decide fix, disable or revert action for rc3 release.
But it should either one of them for rc3 not this patch as is.
>
>
next prev parent reply other threads:[~2018-11-06 9:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 5:37 [PATCH v7 0/5] Address reader-writer concurrency in rte_hash Honnappa Nagarahalli
2018-10-26 5:37 ` [PATCH v7 1/5] hash: separate multi-writer from rw-concurrency Honnappa Nagarahalli
2018-10-26 5:37 ` [PATCH v7 2/5] hash: support do not free on delete Honnappa Nagarahalli
2018-10-26 5:37 ` [PATCH v7 3/5] hash: fix key store element alignment Honnappa Nagarahalli
2018-10-26 5:37 ` [PATCH v7 4/5] hash: add lock-free read-write concurrency Honnappa Nagarahalli
2018-11-03 11:52 ` Jerin Jacob
2018-11-03 15:40 ` Jerin Jacob
2018-11-06 6:07 ` Honnappa Nagarahalli
2018-11-06 9:10 ` Jerin Jacob
2018-11-06 9:13 ` Thomas Monjalon
2018-11-06 9:47 ` Jerin Jacob [this message]
2018-11-09 1:34 ` Honnappa Nagarahalli
2018-11-09 2:20 ` Honnappa Nagarahalli
2018-11-09 9:28 ` Jerin Jacob
2018-11-09 15:37 ` Honnappa Nagarahalli
2018-11-07 2:15 ` Wang, Yipeng1
2018-11-09 0:47 ` Honnappa Nagarahalli
2018-10-26 5:37 ` [PATCH v7 5/5] test/hash: read-write lock-free concurrency test Honnappa Nagarahalli
2018-10-26 10:52 ` [PATCH v7 0/5] Address reader-writer concurrency in rte_hash Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106094715.GA12863@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=Dharmik.Thakkar@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Prasun.Kapoor@cavium.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=nd@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.