From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/framebuffer: Expose only modifiers that
 support at least a format
Date: Tue, 6 Nov 2018 16:13:25 +0200
Message-ID: <20181106141325.GU9144@intel.com>
References: <20181106024434.12322-1-dhinakaran.pandiyan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20181106024434.12322-1-dhinakaran.pandiyan@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gTW9uLCBOb3YgMDUsIDIwMTggYXQgMDY6NDQ6MzRQTSAtMDgwMCwgRGhpbmFrYXJhbiBQYW5k
aXlhbiB3cm90ZToKPiBBbGxvd3MgZHJpdmVycyB0byBwYXNzIGEgbGFyZ2VyIG1vZGlmaWVyIGFy
cmF5LCB0aGVyZWJ5IGF2b2lkaW5nCj4gZGVjbGFyYXRpb25zIG9mIHN0YXRpYyBtb2RpZmllciBh
cnJheXMgdGhhdCBhcmUgb25seSBzbGlnaHQgZGlmZmVyZW50Cj4gZm9yIGVhY2ggcGxhbmUuCj4g
Cj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogVmlsbGUgU3lyasOk
bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTdWdnZXN0ZWQtYnk6IFZpbGxl
IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1i
eTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4g
LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fcGxhbmUuYyB8IDM1ICsrKysrKysrKysrKysrKysr
KysrKysrKysrKy0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCA4
IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5l
LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiBpbmRleCAxZmE5OGJkMTIwMDMuLjE1
NDZmZmJmOGUzNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiAr
KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiBAQCAtMTc5LDggKzE3OSw4IEBAIGlu
dCBkcm1fdW5pdmVyc2FsX3BsYW5lX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0
IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJCSAgICAgY29uc3QgY2hhciAqbmFtZSwgLi4uKQo+ICB7
Cj4gIAlzdHJ1Y3QgZHJtX21vZGVfY29uZmlnICpjb25maWcgPSAmZGV2LT5tb2RlX2NvbmZpZzsK
PiAtCXVuc2lnbmVkIGludCBmb3JtYXRfbW9kaWZpZXJfY291bnQgPSAwOwo+IC0JaW50IHJldDsK
PiArCXVuc2lnbmVkIGludCBmb3JtYXRfbW9kaWZpZXJfY291bnQsIGluX21vZGlmaWVyX2NvdW50
ID0gMDsKPiArCWludCByZXQsIGk7Cj4gIAo+ICAJLyogcGxhbmUgaW5kZXggaXMgdXNlZCB3aXRo
IDMyYml0IGJpdG1hc2tzICovCj4gIAlpZiAoV0FSTl9PTihjb25maWctPm51bV90b3RhbF9wbGFu
ZSA+PSAzMikpCj4gQEAgLTIxNiwyMiArMjE2LDQzIEBAIGludCBkcm1fdW5pdmVyc2FsX3BsYW5l
X2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4g
IAo+ICAJaWYgKGZvcm1hdF9tb2RpZmllcnMpIHsKPiAgCQljb25zdCB1aW50NjRfdCAqdGVtcF9t
b2RpZmllcnMgPSBmb3JtYXRfbW9kaWZpZXJzOwo+ICsKPiAgCQl3aGlsZSAoKnRlbXBfbW9kaWZp
ZXJzKysgIT0gRFJNX0ZPUk1BVF9NT0RfSU5WQUxJRCkKPiAtCQkJZm9ybWF0X21vZGlmaWVyX2Nv
dW50Kys7Cj4gKwkJCWluX21vZGlmaWVyX2NvdW50Kys7Cj4gIAl9Cj4gIAo+IC0JcGxhbmUtPm1v
ZGlmaWVyX2NvdW50ID0gZm9ybWF0X21vZGlmaWVyX2NvdW50Owo+IC0JcGxhbmUtPm1vZGlmaWVy
cyA9IGttYWxsb2NfYXJyYXkoZm9ybWF0X21vZGlmaWVyX2NvdW50LAo+ICsJcGxhbmUtPm1vZGlm
aWVycyA9IGttYWxsb2NfYXJyYXkoaW5fbW9kaWZpZXJfY291bnQsCj4gIAkJCQkJIHNpemVvZihm
b3JtYXRfbW9kaWZpZXJzWzBdKSwKPiAgCQkJCQkgR0ZQX0tFUk5FTCk7Cj4gIAo+IC0JaWYgKGZv
cm1hdF9tb2RpZmllcl9jb3VudCAmJiAhcGxhbmUtPm1vZGlmaWVycykgewo+ICsJaWYgKGluX21v
ZGlmaWVyX2NvdW50ICYmICFwbGFuZS0+bW9kaWZpZXJzKSB7Cj4gIAkJRFJNX0RFQlVHX0tNUygi
b3V0IG9mIG1lbW9yeSB3aGVuIGFsbG9jYXRpbmcgcGxhbmVcbiIpOwo+ICAJCWtmcmVlKHBsYW5l
LT5mb3JtYXRfdHlwZXMpOwo+ICAJCWRybV9tb2RlX29iamVjdF91bnJlZ2lzdGVyKGRldiwgJnBs
YW5lLT5iYXNlKTsKPiAgCQlyZXR1cm4gLUVOT01FTTsKPiAgCX0KPiAgCj4gKwlmb3IgKGkgPSAw
LCBmb3JtYXRfbW9kaWZpZXJfY291bnQgPSAwOyBpIDwgaW5fbW9kaWZpZXJfY291bnQ7IGkrKykg
ewo+ICsJCWludCBqOwo+ICsKPiArCQlmb3IgKGogPSAwOyBmdW5jcy0+Zm9ybWF0X21vZF9zdXBw
b3J0ZWQgJiYgaiA8IGZvcm1hdF9jb3VudDsgaisrKQo+ICsJCQlpZiAoZnVuY3MtPmZvcm1hdF9t
b2Rfc3VwcG9ydGVkKHBsYW5lLCBmb3JtYXRzW2pdLAo+ICsJCQkJCQkJZm9ybWF0X21vZGlmaWVy
c1tpXSkpCj4gKwkJCQlicmVhazsKPiArCj4gKwkJaWYgKGogPCBmb3JtYXRfY291bnQpCj4gKwkJ
CXBsYW5lLT5tb2RpZmllcnNbZm9ybWF0X21vZGlmaWVyX2NvdW50KytdID0KPiArCQkJCWZvcm1h
dF9tb2RpZmllcnNbaV07Cj4gKwl9Cj4gKwo+ICsJaWYgKGZvcm1hdF9tb2RpZmllcl9jb3VudCA8
IGluX21vZGlmaWVyX2NvdW50KSB7Cj4gKwkJc2l6ZV90IHNpemU7Cj4gKwo+ICsJCXNpemUgPSBm
b3JtYXRfbW9kaWZpZXJfY291bnQgKiBzaXplb2YoZm9ybWF0X21vZGlmaWVyc1swXSk7Cj4gKwkJ
cGxhbmUtPm1vZGlmaWVycyA9IGtyZWFsbG9jKHBsYW5lLT5tb2RpZmllcnMsIHNpemUsIEdGUF9L
RVJORUwpOwoKU2hvdWxkIGNoZWNrIHRoYXQgdGhlIHJlYWxsb2MgYWN0dWFsbHkgc3VjY2VlZGVk
LgoKQW5kIEkgdGhpbmsgd2UgbWlnaHQgd2FudCB0byBnaXZlIHRoaXMgc2FtZSB0cmVhdG1lbnQg
dG8gcGxhbmUtPmZvcm1hdHNbXQphcyB3ZWxsLgoKQW5kIHBlcmhhcHMgd2UgY291bGQgZXZlbiB0
aHJvdyBvdXQgcGxhbmUtPm1vZGlmaWVyc1tdIGFuZCBqdXN0IHJlbHkgb24KdGhlIElOX0ZPUk1B
VFMgYmxvYiBleGNsdXNpdmVseT8gSG1tLiBMb29rcyBsaWtlIHRoYXQgaXMgbm90IGdldHRpbmcg
ZnVsbHkKcG9wdWxhdGVkIHVubGVzcyB0aGUgZHJpdmVyIGhhcyBwcm92aWRlZCAuZm9ybWF0X21v
ZF9zdXBwb3J0ZWQoKS4gTm90CnN1cmUgd2h5IHRoYXQgaXMsIGFuZCBub3Qgc3VyZSB3aGF0IHVz
ZXJzcGFjZSBpcyBzdXBwb3NlZCB0byBkbyB3aXRoIGEKcGFydGlhbGx5IGZpbGxlZCBibG9iIGxp
a2UgdGhhdC4gSSdtIHRoaW5raW5nIHdlIHNob3VsZG4ndCBldmVuIGF0dGFjaAp0aGUgcHJvcGVy
dHkgdG8gdGhlIHBsYW5lIGluIHRoYXQgY2FzZS4KCj4gKwl9Cj4gKwlwbGFuZS0+bW9kaWZpZXJf
Y291bnQgPSBmb3JtYXRfbW9kaWZpZXJfY291bnQ7Cj4gKwo+ICAJaWYgKG5hbWUpIHsKPiAgCQl2
YV9saXN0IGFwOwo+ICAKPiBAQCAtMjUxLDggKzI3Miw2IEBAIGludCBkcm1fdW5pdmVyc2FsX3Bs
YW5lX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUs
Cj4gIAo+ICAJbWVtY3B5KHBsYW5lLT5mb3JtYXRfdHlwZXMsIGZvcm1hdHMsIGZvcm1hdF9jb3Vu
dCAqIHNpemVvZih1aW50MzJfdCkpOwo+ICAJcGxhbmUtPmZvcm1hdF9jb3VudCA9IGZvcm1hdF9j
b3VudDsKPiAtCW1lbWNweShwbGFuZS0+bW9kaWZpZXJzLCBmb3JtYXRfbW9kaWZpZXJzLAo+IC0J
ICAgICAgIGZvcm1hdF9tb2RpZmllcl9jb3VudCAqIHNpemVvZihmb3JtYXRfbW9kaWZpZXJzWzBd
KSk7Cj4gIAlwbGFuZS0+cG9zc2libGVfY3J0Y3MgPSBwb3NzaWJsZV9jcnRjczsKPiAgCXBsYW5l
LT50eXBlID0gdHlwZTsKPiAgCj4gLS0gCj4gMi4xNC4xCgotLSAKVmlsbGUgU3lyasOkbMOkCklu
dGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs
LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov
L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=