From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bootlin.com ([62.4.15.54]) by casper.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gK1Iv-0002Vl-3V for linux-mtd@lists.infradead.org; Tue, 06 Nov 2018 13:22:02 +0000 Date: Tue, 6 Nov 2018 14:21:49 +0100 From: Miquel Raynal To: Boris Brezillon Cc: Mark Brown , linux-spi@vger.kernel.org, David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , linux-mtd@lists.infradead.org, Vignesh R , Cyrille Pitchen , Tudor Ambarus , Yogesh Narayan Gaur , Frieder Schrempf Subject: Re: [PATCH v2 0/7] spi: spi-mem: Add a direct mapping API Message-ID: <20181106142149.13e35c98@xps13> In-Reply-To: <20181030133638.3322-1-boris.brezillon@bootlin.com> References: <20181030133638.3322-1-boris.brezillon@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Boris, Boris Brezillon wrote on Tue, 30 Oct 2018 14:36:31 +0100: > Hello, >=20 > I didn't have much review on the RFC, so I'm resending this series > without "RFC" in the subject. Maybe I'll get more reviews this time. >=20 > A few things have changed since I submitted the RFC > - The spi-nand framework has been merged, and I can thus patch this > driver to use the dirmap API > - The MXIC controller has been submitted, and since I did my tests > with this controller, I can also add a patch showing how to > implement the dirmap hooks >=20 > Other changes are addressing the comments I received from Miquel. >=20 > I'd still like to get feedback on the API and controller interface if > anyone is interested in reviewing it. >=20 > Thanks, >=20 > Boris >=20 > Boris Brezillon (7): > spi: spi-mem: Add missing word in the SPI_MEM_DATA_OUT description > spi: spi-mem: Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum > spi: spi-mem: Split spi_mem_exec_op() code > spi: spi-mem: Add a new API to support direct mapping > mtd: devices: m25p80: Use the spi-mem dirmap API > mtd: spinand: Use the spi-mem dirmap API > spi: mxic: Add support for direct mapping >=20 > drivers/mtd/devices/m25p80.c | 142 +++++++++++------- > drivers/mtd/nand/spi/core.c | 231 +++++++++++++++++------------- > drivers/spi/spi-mem.c | 269 ++++++++++++++++++++++++++++++++--- > drivers/spi/spi-mxic.c | 140 ++++++++++++++---- > include/linux/mtd/spinand.h | 7 + > include/linux/spi/spi-mem.h | 84 ++++++++++- > 6 files changed, 670 insertions(+), 203 deletions(-) >=20 For the whole series: Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v2 0/7] spi: spi-mem: Add a direct mapping API Date: Tue, 6 Nov 2018 14:21:49 +0100 Message-ID: <20181106142149.13e35c98@xps13> References: <20181030133638.3322-1-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Yogesh Narayan Gaur , Vignesh R , Tudor Ambarus , Richard Weinberger , Cyrille Pitchen , linux-spi@vger.kernel.org, Marek Vasut , Frieder Schrempf , Mark Brown , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse To: Boris Brezillon Return-path: In-Reply-To: <20181030133638.3322-1-boris.brezillon@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org SGkgQm9yaXMsCgpCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBib290bGluLmNvbT4g d3JvdGUgb24gVHVlLCAzMCBPY3QgMjAxOAoxNDozNjozMSArMDEwMDoKCj4gSGVsbG8sCj4gCj4g SSBkaWRuJ3QgaGF2ZSBtdWNoIHJldmlldyBvbiB0aGUgUkZDLCBzbyBJJ20gcmVzZW5kaW5nIHRo aXMgc2VyaWVzCj4gd2l0aG91dCAiUkZDIiBpbiB0aGUgc3ViamVjdC4gTWF5YmUgSSdsbCBnZXQg bW9yZSByZXZpZXdzIHRoaXMgdGltZS4KPiAKPiBBIGZldyB0aGluZ3MgaGF2ZSBjaGFuZ2VkIHNp bmNlIEkgc3VibWl0dGVkIHRoZSBSRkMKPiAtIFRoZSBzcGktbmFuZCBmcmFtZXdvcmsgaGFzIGJl ZW4gbWVyZ2VkLCBhbmQgSSBjYW4gdGh1cyBwYXRjaCB0aGlzCj4gICBkcml2ZXIgdG8gdXNlIHRo ZSBkaXJtYXAgQVBJCj4gLSBUaGUgTVhJQyBjb250cm9sbGVyIGhhcyBiZWVuIHN1Ym1pdHRlZCwg YW5kIHNpbmNlIEkgZGlkIG15IHRlc3RzCj4gICB3aXRoIHRoaXMgY29udHJvbGxlciwgSSBjYW4g YWxzbyBhZGQgYSBwYXRjaCBzaG93aW5nIGhvdyB0bwo+ICAgaW1wbGVtZW50IHRoZSBkaXJtYXAg aG9va3MKPiAKPiBPdGhlciBjaGFuZ2VzIGFyZSBhZGRyZXNzaW5nIHRoZSBjb21tZW50cyBJIHJl Y2VpdmVkIGZyb20gTWlxdWVsLgo+IAo+IEknZCBzdGlsbCBsaWtlIHRvIGdldCBmZWVkYmFjayBv biB0aGUgQVBJIGFuZCBjb250cm9sbGVyIGludGVyZmFjZSBpZgo+IGFueW9uZSBpcyBpbnRlcmVz dGVkIGluIHJldmlld2luZyBpdC4KPiAKPiBUaGFua3MsCj4gCj4gQm9yaXMKPiAKPiBCb3JpcyBC cmV6aWxsb24gKDcpOgo+ICAgc3BpOiBzcGktbWVtOiBBZGQgbWlzc2luZyB3b3JkIGluIHRoZSBT UElfTUVNX0RBVEFfT1VUIGRlc2NyaXB0aW9uCj4gICBzcGk6IHNwaS1tZW06IEFkZCBTUElfTUVN X05PX0RBVEEgdG8gdGhlIHNwaV9tZW1fZGF0YV9kaXIgZW51bQo+ICAgc3BpOiBzcGktbWVtOiBT cGxpdCBzcGlfbWVtX2V4ZWNfb3AoKSBjb2RlCj4gICBzcGk6IHNwaS1tZW06IEFkZCBhIG5ldyBB UEkgdG8gc3VwcG9ydCBkaXJlY3QgbWFwcGluZwo+ICAgbXRkOiBkZXZpY2VzOiBtMjVwODA6IFVz ZSB0aGUgc3BpLW1lbSBkaXJtYXAgQVBJCj4gICBtdGQ6IHNwaW5hbmQ6IFVzZSB0aGUgc3BpLW1l bSBkaXJtYXAgQVBJCj4gICBzcGk6IG14aWM6IEFkZCBzdXBwb3J0IGZvciBkaXJlY3QgbWFwcGlu Zwo+IAo+ICBkcml2ZXJzL210ZC9kZXZpY2VzL20yNXA4MC5jIHwgMTQyICsrKysrKysrKysrLS0t LS0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3NwaS9jb3JlLmMgIHwgMjMxICsrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL3NwaS9zcGktbWVtLmMgICAgICAgIHwgMjY5ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tCj4gIGRyaXZlcnMvc3BpL3NwaS1teGlj LmMgICAgICAgfCAxNDAgKysrKysrKysrKysrKystLS0tCj4gIGluY2x1ZGUvbGludXgvbXRkL3Nw aW5hbmQuaCAgfCAgIDcgKwo+ICBpbmNsdWRlL2xpbnV4L3NwaS9zcGktbWVtLmggIHwgIDg0ICsr KysrKysrKystCj4gIDYgZmlsZXMgY2hhbmdlZCwgNjcwIGluc2VydGlvbnMoKyksIDIwMyBkZWxl dGlvbnMoLSkKPiAKCkZvciB0aGUgd2hvbGUgc2VyaWVzOgoKUmV2aWV3ZWQtYnk6IE1pcXVlbCBS YXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+CgoKVGhhbmtzLApNaXF1w6hsCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgg TVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo=