All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: linux-nvdimm@lists.01.org, linux-edac@vger.kernel.org,
	elliott@hpe.com, stable@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	Tony Luck <tony.luck@intel.com>
Subject: [v3,2/2] nfit, mce: validate the mce->addr before using it
Date: Tue, 6 Nov 2018 15:51:37 +0100	[thread overview]
Message-ID: <20181106145137.GJ13712@zn.tnic> (raw)

On Thu, Oct 25, 2018 at 06:37:29PM -0600, Vishal Verma wrote:
> The NFIT machine check handler uses the physical address from the 'mce'
> structure, and compares it against information in the ACPI NFIT table to
> determine whether that location lies on an NVDIMM. The mce->addr field
> however may not always be valid, and this is indicated by the
> MCI_STATUS_ADDRV bit in the status field.
> 
> Export mce_usable_address() which already performs validation for the
> address, and use it in the NFIT handler.
> 
> Reported-by: Robert Elliott <elliott@hpe.com>
> Fixes: 6839a6d96f4e ("nfit: do an ARS scrub on hitting a latent media error")
> Cc: stable@vger.kernel.org
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
>  arch/x86/include/asm/mce.h       | 1 +
>  arch/x86/kernel/cpu/mcheck/mce.c | 3 ++-
>  drivers/acpi/nfit/mce.c          | 4 ++++
>  3 files changed, 7 insertions(+), 1 deletion(-)

Is there any particular reason why is this a separate patch and not part
of the first one?

Also, do s/mce/MCE/g.

Thx.

WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: Tony Luck <tony.luck@intel.com>,
	linux-nvdimm@lists.01.org, stable@vger.kernel.org,
	linux-edac@vger.kernel.org
Subject: Re: [PATCH v3 2/2] nfit, mce: validate the mce->addr before using it
Date: Tue, 6 Nov 2018 15:51:37 +0100	[thread overview]
Message-ID: <20181106145137.GJ13712@zn.tnic> (raw)
In-Reply-To: <20181026003729.8420-2-vishal.l.verma@intel.com>

On Thu, Oct 25, 2018 at 06:37:29PM -0600, Vishal Verma wrote:
> The NFIT machine check handler uses the physical address from the 'mce'
> structure, and compares it against information in the ACPI NFIT table to
> determine whether that location lies on an NVDIMM. The mce->addr field
> however may not always be valid, and this is indicated by the
> MCI_STATUS_ADDRV bit in the status field.
> 
> Export mce_usable_address() which already performs validation for the
> address, and use it in the NFIT handler.
> 
> Reported-by: Robert Elliott <elliott@hpe.com>
> Fixes: 6839a6d96f4e ("nfit: do an ARS scrub on hitting a latent media error")
> Cc: stable@vger.kernel.org
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
>  arch/x86/include/asm/mce.h       | 1 +
>  arch/x86/kernel/cpu/mcheck/mce.c | 3 ++-
>  drivers/acpi/nfit/mce.c          | 4 ++++
>  3 files changed, 7 insertions(+), 1 deletion(-)

Is there any particular reason why is this a separate patch and not part
of the first one?

Also, do s/mce/MCE/g.

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: linux-nvdimm@lists.01.org, linux-edac@vger.kernel.org,
	elliott@hpe.com, stable@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v3 2/2] nfit, mce: validate the mce->addr before using it
Date: Tue, 6 Nov 2018 15:51:37 +0100	[thread overview]
Message-ID: <20181106145137.GJ13712@zn.tnic> (raw)
In-Reply-To: <20181026003729.8420-2-vishal.l.verma@intel.com>

On Thu, Oct 25, 2018 at 06:37:29PM -0600, Vishal Verma wrote:
> The NFIT machine check handler uses the physical address from the 'mce'
> structure, and compares it against information in the ACPI NFIT table to
> determine whether that location lies on an NVDIMM. The mce->addr field
> however may not always be valid, and this is indicated by the
> MCI_STATUS_ADDRV bit in the status field.
> 
> Export mce_usable_address() which already performs validation for the
> address, and use it in the NFIT handler.
> 
> Reported-by: Robert Elliott <elliott@hpe.com>
> Fixes: 6839a6d96f4e ("nfit: do an ARS scrub on hitting a latent media error")
> Cc: stable@vger.kernel.org
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
>  arch/x86/include/asm/mce.h       | 1 +
>  arch/x86/kernel/cpu/mcheck/mce.c | 3 ++-
>  drivers/acpi/nfit/mce.c          | 4 ++++
>  3 files changed, 7 insertions(+), 1 deletion(-)

Is there any particular reason why is this a separate patch and not part
of the first one?

Also, do s/mce/MCE/g.

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

             reply	other threads:[~2018-11-06 14:51 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 14:51 Borislav Petkov [this message]
2018-11-06 14:51 ` [PATCH v3 2/2] nfit, mce: validate the mce->addr before using it Borislav Petkov
2018-11-06 14:51 ` Borislav Petkov
  -- strict thread matches above, loose matches on Subject: below --
2019-02-21 17:09 [v3,1/2] nfit, mce: only handle uncorrectable machine checks Borislav Petkov
2019-02-21 17:09 ` [PATCH v3 1/2] " Borislav Petkov
2019-02-21 16:11 [v3,1/2] " Jeff Moyer
2019-02-21 16:11 ` [PATCH v3 1/2] " Jeff Moyer
2019-02-20 19:47 [v3,1/2] " Borislav Petkov
2019-02-20 19:47 ` [PATCH v3 1/2] " Borislav Petkov
2019-02-20 19:40 [v3,1/2] " Dan Williams
2019-02-20 19:40 ` [PATCH v3 1/2] " Dan Williams
2019-02-20 19:39 [v3,1/2] " Borislav Petkov
2019-02-20 19:39 ` [PATCH v3 1/2] " Borislav Petkov
2019-02-20 19:26 [v3,1/2] " Jeff Moyer
2019-02-20 19:26 ` [PATCH v3 1/2] " Jeff Moyer
2019-02-20 19:18 [v3,1/2] " Borislav Petkov
2019-02-20 19:18 ` [PATCH v3 1/2] " Borislav Petkov
2019-02-20 18:59 [v3,1/2] " Jeff Moyer
2019-02-20 18:59 ` [PATCH v3 1/2] " Jeff Moyer
2019-02-20 18:59 ` Jeff Moyer
2018-11-06 18:19 [tip:x86/urgent] acpi/nfit, x86/mce: Validate a MCE's address before using it tip-bot for Borislav Petkov
2018-11-06 18:19 ` tip-bot for Vishal Verma
2018-11-06 18:18 [tip:x86/urgent] acpi/nfit, x86/mce: Handle only uncorrectable machine checks tip-bot for Borislav Petkov
2018-11-06 18:18 ` tip-bot for Vishal Verma
2018-11-06 18:07 [v3,2/2] nfit, mce: validate the mce->addr before using it Borislav Petkov
2018-11-06 18:07 ` [PATCH v3 2/2] " Borislav Petkov
2018-11-06 18:07 ` Borislav Petkov
2018-11-06 18:02 [v3,2/2] " Dan Williams
2018-11-06 18:02 ` [PATCH v3 2/2] " Dan Williams
2018-11-06 18:02 ` Dan Williams
2018-11-06 17:53 [v3,2/2] " Borislav Petkov
2018-11-06 17:53 ` [PATCH v3 2/2] " Borislav Petkov
2018-11-06 17:53 ` Borislav Petkov
2018-11-06 16:20 [v3,2/2] " Dan Williams
2018-11-06 16:20 ` [PATCH v3 2/2] " Dan Williams
2018-11-06 16:20 ` Dan Williams
2018-10-26  0:37 [v3,2/2] " Vishal Verma
2018-10-26  0:37 ` [PATCH v3 2/2] " Vishal Verma
2018-10-26  0:37 ` Vishal Verma
2018-10-26  0:37 [v3,1/2] nfit, mce: only handle uncorrectable machine checks Vishal Verma
2018-10-26  0:37 ` [PATCH v3 1/2] " Vishal Verma
2018-10-26  0:37 ` Vishal Verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181106145137.GJ13712@zn.tnic \
    --to=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=elliott@hpe.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=stable@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.