From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [v6 1/4] i915/dp/fec: Add fec_enable to the crtc state. Date: Tue, 6 Nov 2018 16:53:27 +0200 Message-ID: <20181106145327.GZ9144@intel.com> References: <20181105233150.1972-1-anusha.srivatsa@intel.com> <20181105233150.1972-2-anusha.srivatsa@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181105233150.1972-2-anusha.srivatsa@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Anusha Srivatsa Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBOb3YgMDUsIDIwMTggYXQgMDM6MzE6NDdQTSAtMDgwMCwgQW51c2hhIFNyaXZhdHNh IHdyb3RlOgo+IEZvciBEUCAxLjQgYW5kIGFib3ZlLCBEaXNwbGF5IFN0cmVhbSBjb21wcmVzc2lv biBjYW4gYmUKPiBlbmFibGVkIG9ubHkgaWYgRm9yd2FyZCBFcnJvciBDb3JyZWN0aW4gY2FuIGJl IHBlcmZvcm1lZC4KPiAKPiBBZGQgYSBjcnRjIHN0YXRlIGZvciBGRUMuIEN1cnJlbnRseSwgdGhl IHN0YXRlCj4gaXMgZGV0ZXJtaW5lZCBieSBwbGF0Zm9ybSwgRFAgYW5kIERTQyBiZWluZwo+IGVu YWJsZWQuIE1vdmluZyBmb3J3YXJkIHdlIGNhbiB1c2UgdGhlIHN0YXRlCj4gdG8gaGF2ZSBlcnJv ciBjb3JyZWN0aW9uIG9uIG90aGVyIHNjZW5hcmlvcyB0b28KPiBpZiBuZWVkZWQuCj4gCj4gdjI6 Cj4gLSBDb250cm9sIGNvbXByZXNzaW9uX2VuYWJsZSB3aXRoIHRoZSBmZWNfZW5hYmxlCj4gcGFy YW1ldGVyIGluIGNydGMgc3RhdGUgYW5kIHdpdGggaW50ZWxfZHBfc3VwcG9ydHNfZmVjKCkKPiAo VmlsbGUpCj4gCj4gLSBpbnRlbF9kcF9jYW5fZmVjKCkvaW50ZWxfZHBfc3VwcG9ydHNfZmVjKCko bWFuYXNpKQo+IAo+IHYzOiBDaGVjayBmb3IgRkVDIHN1cHBvcnQgYWxvbmcgd2l0aCBzZXR0aW5n IGNydGMgc3RhdGUuCj4gCj4gdjQ6IGFkZCBjaGVja3MgdG8gaW50ZWxfZHBfc291cmNlX3N1cHBv cnRzX2RzYy4obWFuYXNpKQo+IC0gTW92ZSBpbnRlbF9kcF9zdXBwb3J0c19mZWMoKSBjbG9zZXIg dG8KPiBpbnRlbF9kcF9zdXBwb3J0c19kc2MoKSAoQW51c2hhKQo+IAo+IFN1Z2dlc3RlZC1ieTog VmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IGRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51 eC5pbnRlbC5jb20+Cj4gQ2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5j b20+Cj4gU2lnbmVkLW9mZi1ieTogQW51c2hhIFNyaXZhdHNhIDxhbnVzaGEuc3JpdmF0c2FAaW50 ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICB8IDI4ICsr KysrKysrKysrKysrKysrKysrKysrKystLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmggfCAgMyArKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAzIGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IDczYzAwYzVhY2Yx NC4uNjBlMzIzNjYyZWVhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAgLTU0NSw3 ICs1NDUsNyBAQCBpbnRlbF9kcF9tb2RlX3ZhbGlkKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25u ZWN0b3IsCj4gIAkJCWRzY19zbGljZV9jb3VudCA9Cj4gIAkJCQlkcm1fZHBfZHNjX3NpbmtfbWF4 X3NsaWNlX2NvdW50KGludGVsX2RwLT5kc2NfZHBjZCwKPiAgCQkJCQkJCQl0cnVlKTsKPiAtCQl9 IGVsc2Ugewo+ICsJCX0gZWxzZSBpZiAoZHJtX2RwX3Npbmtfc3VwcG9ydHNfZmVjKGludGVsX2Rw LT5mZWNfY2FwYWJsZSkpIHsKPiAgCQkJZHNjX21heF9vdXRwdXRfYnBwID0KPiAgCQkJCWludGVs X2RwX2RzY19nZXRfb3V0cHV0X2JwcChtYXhfbGlua19jbG9jaywKPiAgCQkJCQkJCSAgICBtYXhf bGFuZXMsCj4gQEAgLTE3MTAsMTMgKzE3MTAsMjcgQEAgc3RydWN0IGxpbmtfY29uZmlnX2xpbWl0 cyB7Cj4gIAlpbnQgbWluX2JwcCwgbWF4X2JwcDsKPiAgfTsKPiAgCj4gK3N0YXRpYyBib29sIGlu dGVsX2RwX3NvdXJjZV9zdXBwb3J0c19mZWMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAr ewo+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPSBkcF90b19kaWdfcG9y dChpbnRlbF9kcCk7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19p OTE1KGRpZ19wb3J0LT5iYXNlLmJhc2UuZGV2KTsKPiArCWVudW0gcG9ydCBwb3J0ID0gZGlnX3Bv cnQtPmJhc2UucG9ydDsKPiArCj4gKwlyZXR1cm4gSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSAm JiBwb3J0ICE9IFBPUlRfQTsKPiArfQo+ICsKPiArc3RhdGljIGJvb2wgaW50ZWxfZHBfc3VwcG9y dHNfZmVjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gK3sKPiArCXJldHVybiBpbnRlbF9k cF9zb3VyY2Vfc3VwcG9ydHNfZmVjKGludGVsX2RwKSAmJgo+ICsJCWRybV9kcF9zaW5rX3N1cHBv cnRzX2ZlYyhpbnRlbF9kcC0+ZmVjX2NhcGFibGUpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgYm9vbCBp bnRlbF9kcF9zb3VyY2Vfc3VwcG9ydHNfZHNjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4g IAkJCQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZykKPiAgewo+ ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZHBfdG9faTkxNShpbnRlbF9k cCk7Cj4gIAo+IC0JLyogRklYTUU6IEZFQyBuZWVkZWQgZm9yIGV4dGVybmFsIERQIHVudGlsIHRo ZW4gcmVqZWN0IERTQyBvbiBEUCAqLwo+IC0JaWYgKCFpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHAp KQo+ICsJaWYgKCFpbnRlbF9kcF9zdXBwb3J0c19mZWMoaW50ZWxfZHApICYmICFpbnRlbF9kcF9p c19lZHAoaW50ZWxfZHApKQo+ICAJCXJldHVybiBmYWxzZTsKCkhtbS4gSSBndWVzcyB3ZSBzaG91 bGQgbW92ZSB0aGlzIHdob2xlIGNoZWNrIHRvCmludGVsX2RwX3N1cHBvcnRzX2RzYygpIHNpbmNl IHdlJ3JlIG5vdyBjaGVja2luZyBzaW5rIGNhcHMgYXMgd2VsbC4KCj4gIAo+ICAJcmV0dXJuIElO VEVMX0dFTihkZXZfcHJpdikgPj0gMTAgJiYKPiBAQCAtMTg4Niw5ICsxOTAwLDE3IEBAIHN0YXRp YyBib29sIGludGVsX2RwX2RzY19jb21wdXRlX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVs X2RwLAo+ICAJdTE2IGRzY19tYXhfb3V0cHV0X2JwcCA9IDA7Cj4gIAl1OCBkc2NfZHBfc2xpY2Vf Y291bnQgPSAwOwo+ICAKPiArCXBpcGVfY29uZmlnLT5mZWNfZW5hYmxlID0gIWludGVsX2RwX2lz X2VkcChpbnRlbF9kcCk7Cj4gKwo+ICAJaWYgKCFpbnRlbF9kcF9zdXBwb3J0c19kc2MoaW50ZWxf ZHAsIHBpcGVfY29uZmlnKSkKPiAgCQlyZXR1cm4gZmFsc2U7Cj4gIAo+ICsJLyogRFNDIG5vdCBz dXBwb3J0ZWQgaWYgZXh0ZXJuYWwgRFAgc2luayBkb2VzIG5vdCBzdXBwb3J0IEZFQyAqLwo+ICsJ aWYgKHBpcGVfY29uZmlnLT5mZWNfZW5hYmxlICYmICFpbnRlbF9kcF9zdXBwb3J0c19mZWMoaW50 ZWxfZHApKSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiU2luayBkb2VzIG5vdCBzdXBwb3J0IEZvcndh cmQgRXJyb3IgQ29ycmVjdGlvbiwgZGlzYWJsaW5nIERpc3BsYXkgQ29tcHJlc3Npb25cbiIpOwo+ ICsJCXJldHVybiBmYWxzZTsKPiArCX0KPiArCj4gIAkvKiBEU0Mgbm90IHN1cHBvcnRlZCBmb3Ig RFNDIHNpbmsgQlBDIDwgOCAqLwo+ICAJaWYgKGxpbWl0cy0+bWF4X2JwcCA8IDMgKiBEUF9EU0Nf TUlOX1NVUFBPUlRFRF9CUEMpIHsKPiAgCQlEUk1fREVCVUdfS01TKCJObyBEU0Mgc3VwcG9ydCBm b3IgbGVzcyB0aGFuIDhicGNcbiIpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5kZXgg ZGQyMmNkZWFhNjczLi45OTdiZWE1ZmRmMTYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYu aAo+IEBAIC05NDUsNiArOTQ1LDkgQEAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgewo+ICAJCXU4 IHNsaWNlX2NvdW50Owo+ICAJfSBkc2NfcGFyYW1zOwo+ICAJc3RydWN0IGRybV9kc2NfY29uZmln IGRwX2RzY19jZmc7Cj4gKwo+ICsJLyogRm9yd2FyZCBFcnJvciBjb3JyZWN0aW9uIFN0YXRlICov Cj4gKwlib29sIGZlY19lbmFibGU7Cj4gIH07Cj4gIAo+ICBzdHJ1Y3QgaW50ZWxfY3J0YyB7Cj4g LS0gCj4gMi4xOS4xCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=