From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/5] syscalls/chmod05: Use new ltp library
Date: Tue, 6 Nov 2018 17:01:19 +0100 [thread overview]
Message-ID: <20181106160119.GE3014@rei.lan> (raw)
In-Reply-To: <20181106155524.GC259383@sspatil-workstation.mtv.corp.google.com>
Hi!
> > -void cleanup(void)
> > -{
> > - if (setegid(0) == -1)
> > - tst_resm(TWARN | TERRNO, "setegid(0) failed");
> > - if (seteuid(0) == -1)
> > - tst_resm(TWARN | TERRNO, "seteuid(0) failed");
> > -
>
> It looks like I need to do this in some cleanup function for the new test.
> Otherwise the library cleanup won't be able to delete the tmpdir. Let me
> rework this..
Actually the temporary directory cleanup in the new library is executed
from the parent process, the actuall test is executed from a forked
child so it shouldn't matter what euid and egid the child process ends
up with.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-11-06 16:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 23:50 [LTP] [PATCH 0/5] Misc cleanups (new lib) and fixes for Android Sandeep Patil
2018-11-05 23:50 ` [LTP] [PATCH 1/5] chroot01: Use the 'tmpdir' we create Sandeep Patil
2018-11-06 15:45 ` Cyril Hrubis
2018-11-05 23:50 ` [LTP] [PATCH 2/5] syscalls/chmod07: Use new ltp library Sandeep Patil
2018-11-06 15:46 ` Cyril Hrubis
2018-11-05 23:50 ` [LTP] [PATCH 3/5] syscalls/fchmod02: fall back to use "daemon" group if "users" is absent Sandeep Patil
2018-11-06 16:02 ` Cyril Hrubis
2018-11-05 23:50 ` [LTP] [PATCH 4/5] syscalls/chmod05: Use new ltp library Sandeep Patil
2018-11-06 15:55 ` Sandeep Patil
2018-11-06 16:01 ` Cyril Hrubis [this message]
2018-11-06 16:13 ` Sandeep Patil
2018-11-05 23:50 ` [LTP] [PATCH 5/5] syscalls/posix_fadvise0[13]: Start using new library Sandeep Patil
2018-11-06 7:00 ` Amir Goldstein
2018-11-06 15:52 ` Sandeep Patil
2018-11-06 15:54 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106160119.GE3014@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.