From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/framebuffer: Expose only modifiers that support at
 least a format
Date: Tue, 6 Nov 2018 22:21:43 +0200
Message-ID: <20181106202143.GG9144@intel.com>
References: <20181106024434.12322-1-dhinakaran.pandiyan@intel.com>
 <20181106141325.GU9144@intel.com>
 <0671193e8b85311bec4b2738d28d132e0cf01838.camel@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <0671193e8b85311bec4b2738d28d132e0cf01838.camel@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gVHVlLCBOb3YgMDYsIDIwMTggYXQgMTE6NTQ6NDVBTSAtMDgwMCwgRGhpbmFrYXJhbiBQYW5k
aXlhbiB3cm90ZToKPiBPbiBUdWUsIDIwMTgtMTEtMDYgYXQgMTY6MTMgKzAyMDAsIFZpbGxlIFN5
cmrDpGzDpCB3cm90ZToKPiA+IE9uIE1vbiwgTm92IDA1LCAyMDE4IGF0IDA2OjQ0OjM0UE0gLTA4
MDAsIERoaW5ha2FyYW4gUGFuZGl5YW4gd3JvdGU6Cj4gPiA+IEFsbG93cyBkcml2ZXJzIHRvIHBh
c3MgYSBsYXJnZXIgbW9kaWZpZXIgYXJyYXksIHRoZXJlYnkgYXZvaWRpbmcKPiA+ID4gZGVjbGFy
YXRpb25zIG9mIHN0YXRpYyBtb2RpZmllciBhcnJheXMgdGhhdCBhcmUgb25seSBzbGlnaHQKPiA+
ID4gZGlmZmVyZW50Cj4gPiA+IGZvciBlYWNoIHBsYW5lLgo+ID4gPiAKPiA+ID4gQ2M6IGRyaS1k
ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmls
bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IFN1Z2dlc3RlZC1ieTogVmlsbGUgU3ly
asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gU2lnbmVkLW9mZi1i
eTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4g
PiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jIHwgMzUgKysrKysrKysr
KysrKysrKysrKysrKysrKysrLS0tLQo+ID4gPiAtLS0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwg
MjcgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQg
YS9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vZHJt
X3BsYW5lLmMKPiA+ID4gaW5kZXggMWZhOThiZDEyMDAzLi4xNTQ2ZmZiZjhlMzYgMTAwNjQ0Cj4g
PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGxhbmUuYwo+ID4gPiArKysgYi9kcml2ZXJz
L2dwdS9kcm0vZHJtX3BsYW5lLmMKPiA+ID4gQEAgLTE3OSw4ICsxNzksOCBAQCBpbnQgZHJtX3Vu
aXZlcnNhbF9wbGFuZV9pbml0KHN0cnVjdCBkcm1fZGV2aWNlCj4gPiA+ICpkZXYsIHN0cnVjdCBk
cm1fcGxhbmUgKnBsYW5lLAo+ID4gPiAgCQkJICAgICBjb25zdCBjaGFyICpuYW1lLCAuLi4pCj4g
PiA+ICB7Cj4gPiA+ICAJc3RydWN0IGRybV9tb2RlX2NvbmZpZyAqY29uZmlnID0gJmRldi0+bW9k
ZV9jb25maWc7Cj4gPiA+IC0JdW5zaWduZWQgaW50IGZvcm1hdF9tb2RpZmllcl9jb3VudCA9IDA7
Cj4gPiA+IC0JaW50IHJldDsKPiA+ID4gKwl1bnNpZ25lZCBpbnQgZm9ybWF0X21vZGlmaWVyX2Nv
dW50LCBpbl9tb2RpZmllcl9jb3VudCA9IDA7Cj4gPiA+ICsJaW50IHJldCwgaTsKPiA+ID4gIAo+
ID4gPiAgCS8qIHBsYW5lIGluZGV4IGlzIHVzZWQgd2l0aCAzMmJpdCBiaXRtYXNrcyAqLwo+ID4g
PiAgCWlmIChXQVJOX09OKGNvbmZpZy0+bnVtX3RvdGFsX3BsYW5lID49IDMyKSkKPiA+ID4gQEAg
LTIxNiwyMiArMjE2LDQzIEBAIGludCBkcm1fdW5pdmVyc2FsX3BsYW5lX2luaXQoc3RydWN0Cj4g
PiA+IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gPiA+ICAKPiA+
ID4gIAlpZiAoZm9ybWF0X21vZGlmaWVycykgewo+ID4gPiAgCQljb25zdCB1aW50NjRfdCAqdGVt
cF9tb2RpZmllcnMgPSBmb3JtYXRfbW9kaWZpZXJzOwo+ID4gPiArCj4gPiA+ICAJCXdoaWxlICgq
dGVtcF9tb2RpZmllcnMrKyAhPSBEUk1fRk9STUFUX01PRF9JTlZBTElEKQo+ID4gPiAtCQkJZm9y
bWF0X21vZGlmaWVyX2NvdW50Kys7Cj4gPiA+ICsJCQlpbl9tb2RpZmllcl9jb3VudCsrOwo+ID4g
PiAgCX0KPiA+ID4gIAo+ID4gPiAtCXBsYW5lLT5tb2RpZmllcl9jb3VudCA9IGZvcm1hdF9tb2Rp
Zmllcl9jb3VudDsKPiA+ID4gLQlwbGFuZS0+bW9kaWZpZXJzID0ga21hbGxvY19hcnJheShmb3Jt
YXRfbW9kaWZpZXJfY291bnQsCj4gPiA+ICsJcGxhbmUtPm1vZGlmaWVycyA9IGttYWxsb2NfYXJy
YXkoaW5fbW9kaWZpZXJfY291bnQsCj4gPiA+ICAJCQkJCSBzaXplb2YoZm9ybWF0X21vZGlmaWVy
c1swXSksCj4gPiA+ICAJCQkJCSBHRlBfS0VSTkVMKTsKPiA+ID4gIAo+ID4gPiAtCWlmIChmb3Jt
YXRfbW9kaWZpZXJfY291bnQgJiYgIXBsYW5lLT5tb2RpZmllcnMpIHsKPiA+ID4gKwlpZiAoaW5f
bW9kaWZpZXJfY291bnQgJiYgIXBsYW5lLT5tb2RpZmllcnMpIHsKPiA+ID4gIAkJRFJNX0RFQlVH
X0tNUygib3V0IG9mIG1lbW9yeSB3aGVuIGFsbG9jYXRpbmcgcGxhbmVcbiIpOwo+ID4gPiAgCQlr
ZnJlZShwbGFuZS0+Zm9ybWF0X3R5cGVzKTsKPiA+ID4gIAkJZHJtX21vZGVfb2JqZWN0X3VucmVn
aXN0ZXIoZGV2LCAmcGxhbmUtPmJhc2UpOwo+ID4gPiAgCQlyZXR1cm4gLUVOT01FTTsKPiA+ID4g
IAl9Cj4gPiA+ICAKPiA+ID4gKwlmb3IgKGkgPSAwLCBmb3JtYXRfbW9kaWZpZXJfY291bnQgPSAw
OyBpIDwgaW5fbW9kaWZpZXJfY291bnQ7Cj4gPiA+IGkrKykgewo+ID4gPiArCQlpbnQgajsKPiA+
ID4gKwo+ID4gPiArCQlmb3IgKGogPSAwOyBmdW5jcy0+Zm9ybWF0X21vZF9zdXBwb3J0ZWQgJiYg
aiA8Cj4gPiA+IGZvcm1hdF9jb3VudDsgaisrKQo+ID4gPiArCQkJaWYgKGZ1bmNzLT5mb3JtYXRf
bW9kX3N1cHBvcnRlZChwbGFuZSwKPiA+ID4gZm9ybWF0c1tqXSwKPiA+ID4gKwkJCQkJCQlmb3Jt
YXRfbW9kaWZpZXIKPiA+ID4gc1tpXSkpCj4gPiA+ICsJCQkJYnJlYWs7Cj4gPiA+ICsKPiA+ID4g
KwkJaWYgKGogPCBmb3JtYXRfY291bnQpCj4gPiA+ICsJCQlwbGFuZS0+bW9kaWZpZXJzW2Zvcm1h
dF9tb2RpZmllcl9jb3VudCsrXSA9Cj4gPiA+ICsJCQkJZm9ybWF0X21vZGlmaWVyc1tpXTsKPiA+
ID4gKwl9Cj4gPiA+ICsKPiA+ID4gKwlpZiAoZm9ybWF0X21vZGlmaWVyX2NvdW50IDwgaW5fbW9k
aWZpZXJfY291bnQpIHsKPiA+ID4gKwkJc2l6ZV90IHNpemU7Cj4gPiA+ICsKPiA+ID4gKwkJc2l6
ZSA9IGZvcm1hdF9tb2RpZmllcl9jb3VudCAqCj4gPiA+IHNpemVvZihmb3JtYXRfbW9kaWZpZXJz
WzBdKTsKPiA+ID4gKwkJcGxhbmUtPm1vZGlmaWVycyA9IGtyZWFsbG9jKHBsYW5lLT5tb2RpZmll
cnMsIHNpemUsCj4gPiA+IEdGUF9LRVJORUwpOwo+ID4gCj4gPiBTaG91bGQgY2hlY2sgdGhhdCB0
aGUgcmVhbGxvYyBhY3R1YWxseSBzdWNjZWVkZWQuCj4gRGlkbid0IHNlZSBhIGZhaWx1cmUgcGF0
aCBmb3IgbmV3IHNpemUgc21hbGxlciB0aGFuIG9sZCwgdGhlIHJldHVybiBpcwo+IHRoZSBzYW1l
IHBvaW50ZXIgcGFzc2VkIHRvIGtyZWFsbG9jKCkuCgpJIGRvbid0IGtub3cgaWYgd2Ugd2FudCB0
byByZWx5IG9uIGFuIGltcGxlbWVudGF0aW9uIGRldGFpbCB0aGF0CmhldmlseS4gQnV0IHRoYXQg
ZG9lcyByYWlzZSB0aGUgaW50ZXJlc3RpbmcgcG9pbnQgdGhhdCB0cnlpbmcgdG8Kc2hyaW5rIG91
ciBtZW1vcnkgZm9vdHByaW50IHdpdGgga3JlYWxsb2MoKSBpcyBmdXRpbGUuIEkgc3VwcG9zZQp0
aGVyZSBpcyBzdGlsbCBzb21lIGtpbmQgb2YgZGVidWdnaW5nIGJlbmVmaXQgZnJvbSB0aGUga2Fz
YW4Kc3R1ZmYuCgo+IAo+ID4gCj4gPiBBbmQgSSB0aGluayB3ZSBtaWdodCB3YW50IHRvIGdpdmUg
dGhpcyBzYW1lIHRyZWF0bWVudCB0byBwbGFuZS0KPiA+ID5mb3JtYXRzW10KPiA+IGFzIHdlbGwu
Cj4gPiAKPiA+IEFuZCBwZXJoYXBzIHdlIGNvdWxkIGV2ZW4gdGhyb3cgb3V0IHBsYW5lLT5tb2Rp
ZmllcnNbXSBhbmQganVzdCByZWx5Cj4gPiBvbgo+ID4gdGhlIElOX0ZPUk1BVFMgYmxvYiBleGNs
dXNpdmVseT8gSG1tLiBMb29rcyBsaWtlIHRoYXQgaXMgbm90IGdldHRpbmcKPiA+IGZ1bGx5Cj4g
PiBwb3B1bGF0ZWQgdW5sZXNzIHRoZSBkcml2ZXIgaGFzIHByb3ZpZGVkIC5mb3JtYXRfbW9kX3N1
cHBvcnRlZCgpLiBOb3QKPiA+IHN1cmUgd2h5IHRoYXQgaXMsIGFuZCBub3Qgc3VyZSB3aGF0IHVz
ZXJzcGFjZSBpcyBzdXBwb3NlZCB0byBkbyB3aXRoCj4gPiBhCj4gPiBwYXJ0aWFsbHkgZmlsbGVk
IGJsb2IgbGlrZSB0aGF0LiBJJ20gdGhpbmtpbmcgd2Ugc2hvdWxkbid0IGV2ZW4KPiA+IGF0dGFj
aAo+ID4gdGhlIHByb3BlcnR5IHRvIHRoZSBwbGFuZSBpbiB0aGF0IGNhc2UuCj4gCj4gU2hvdWxk
bid0IGl0IGNvcHkgdGhlIG1vZGlmaWVyIGFycmF5IGludG8gdGhlIGJsb2IgYW5kIG1hcmsgYWxs
IGZvcm1hdHMKPiBhcyBzdXBwb3J0ZWQ/IGRybV9wbGFuZV9jaGVja19waXhlbF9mb3JtYXQoKSBz
ZWVtcyB0byBhbGxvdyBhbnkgdmFsaWQKPiBmb3JtYXQgZm9yIGEgbW9kaWZpZXIgaW4gdGhpcyBj
YXNlLgoKWWVhaCwgSSBndWVzcyB0aGF0IG1pZ2h0IGJlIHRoZSBiZXR0ZXIgYXBwcm9hY2guCgot
LSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy
ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp
bmZvL2RyaS1kZXZlbAo=