From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Linus Walleij <linus.walleij@linaro.org>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Linux MIPS Mailing List <linux-mips@linux-mips.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH next] mtd: maps: physmap: Fix infinite loop crash in ROM type probing
Date: Tue, 6 Nov 2018 23:34:32 +0100 [thread overview]
Message-ID: <20181106233432.76df6bbf@bbrezillon> (raw)
In-Reply-To: <CAMuHMdUQhsikcBzRFAvrCwZwzFK_Coh=fqpSihFP6jEtugCMQw@mail.gmail.com>
On Tue, 6 Nov 2018 23:19:14 +0100
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Boris,
>
> On Tue, Nov 6, 2018 at 10:58 PM Boris Brezillon
> <boris.brezillon@bootlin.com> wrote:
> > On Tue, 6 Nov 2018 22:44:16 +0100
> > Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > On Toshiba RBTX4927, where map_probe is supposed to fail:
> > >
> > > Creating 2 MTD partitions on "physmap-flash.0":
> > > 0x000000c00000-0x000001000000 : "boot"
> > > 0x000000000000-0x000000c00000 : "user"
> > > physmap-flash physmap-flash.1: physmap platform flash device: [mem 0x1e000000-0x1effffff]
> > > CPU 0 Unable to handle kernel paging request at virtual address 00000000, epc == 80320f40, ra == 80321004
> > > ...
> > > Call Trace:
> > > [<80320f40>] get_mtd_chip_driver+0x30/0x8c
> > > [<80321004>] do_map_probe+0x20/0x90
> > > [<80328448>] physmap_flash_probe+0x484/0x4ec
> > >
> > > The access to rom_probe_types[] was changed from a sentinel-based loop
> > > to an infinite loop, causing a crash when reaching the sentinel.
> >
> > Oops. Do you mind if I fix that in-place (squash your changes in
> > Ricardo's original commit)?
Done.
>
> No problem. Thanks!
Thanks for reporting/fixing the bug.
Boris
next prev parent reply other threads:[~2018-11-06 22:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 21:44 [PATCH next] mtd: maps: physmap: Fix infinite loop crash in ROM type probing Geert Uytterhoeven
2018-11-06 21:58 ` Boris Brezillon
2018-11-06 22:19 ` Geert Uytterhoeven
2018-11-06 22:34 ` Boris Brezillon [this message]
2018-11-07 7:33 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106233432.76df6bbf@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=ricardo.ribalda@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.