From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [v7 1/4] i915/dp/fec: Add fec_enable to the crtc state. Date: Tue, 6 Nov 2018 18:39:49 -0800 Message-ID: <20181107023949.GK26420@intel.com> References: <20181107003122.25462-1-anusha.srivatsa@intel.com> <20181107003122.25462-2-anusha.srivatsa@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181107003122.25462-2-anusha.srivatsa@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Anusha Srivatsa Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMDYsIDIwMTggYXQgMDQ6MzE6MTlQTSAtMDgwMCwgQW51c2hhIFNyaXZhdHNh IHdyb3RlOgo+IEZvciBEUCAxLjQgYW5kIGFib3ZlLCBEaXNwbGF5IFN0cmVhbSBjb21wcmVzc2lv biBjYW4gYmUKPiBlbmFibGVkIG9ubHkgaWYgRm9yd2FyZCBFcnJvciBDb3JyZWN0aW4gY2FuIGJl IHBlcmZvcm1lZC4KPiAKPiBBZGQgYSBjcnRjIHN0YXRlIGZvciBGRUMuIEN1cnJlbnRseSwgdGhl IHN0YXRlCj4gaXMgZGV0ZXJtaW5lZCBieSBwbGF0Zm9ybSwgRFAgYW5kIERTQyBiZWluZwo+IGVu YWJsZWQuIE1vdmluZyBmb3J3YXJkIHdlIGNhbiB1c2UgdGhlIHN0YXRlCj4gdG8gaGF2ZSBlcnJv ciBjb3JyZWN0aW9uIG9uIG90aGVyIHNjZW5hcmlvcyB0b28KPiBpZiBuZWVkZWQuCj4gCj4gdjI6 Cj4gLSBDb250cm9sIGNvbXByZXNzaW9uX2VuYWJsZSB3aXRoIHRoZSBmZWNfZW5hYmxlCj4gcGFy YW1ldGVyIGluIGNydGMgc3RhdGUgYW5kIHdpdGggaW50ZWxfZHBfc3VwcG9ydHNfZmVjKCkKPiAo VmlsbGUpCj4gCj4gLSBpbnRlbF9kcF9jYW5fZmVjKCkvaW50ZWxfZHBfc3VwcG9ydHNfZmVjKCko bWFuYXNpKQo+IAo+IHYzOiBDaGVjayBmb3IgRkVDIHN1cHBvcnQgYWxvbmcgd2l0aCBzZXR0aW5n IGNydGMgc3RhdGUuCj4gCj4gdjQ6IGFkZCBjaGVja3MgdG8gaW50ZWxfZHBfc291cmNlX3N1cHBv cnRzX2RzYy4obWFuYXNpKQo+IC0gTW92ZSBpbnRlbF9kcF9zdXBwb3J0c19mZWMoKSBjbG9zZXIg dG8KPiBpbnRlbF9kcF9zdXBwb3J0c19kc2MoKSAoQW51c2hhKQo+IAo+IHY1OiBNb3ZlIGZlYyBj aGVjayB0byBpbnRlbF9kcF9zdXBwb3J0c19kc2MoVmlsbGUpCj4gCj4gdjY6IFJlbW92ZSB3YXJu aW5nLiByZWJhc2UuCj4gCj4gdjc6IGNoYW5nZSBjcnRjIHN0YXRlIHRvIGluY2x1ZGUgRFAgc2lu ayBhbmQgZmVjIGNhcGFiaWxpdHkKPiBvZiBzb3VyY2UuKE1hbmFzaSkKPiAKPiBTdWdnZXN0ZWQt Ynk6IFZpbGxlIFN5cmphbGEgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IFZpbGxlIFN5cmphbGEgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFA bGludXguaW50ZWwuY29tPgo+IENjOiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50 ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEFudXNoYSBTcml2YXRzYSA8YW51c2hhLnNyaXZhdHNh QGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyAgfCAz MSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rydi5oIHwgIDMgKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCA3M2Mw MGM1YWNmMTQuLmY3NjRjNDVkZWFhYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBA IC01NDUsNyArNTQ1LDcgQEAgaW50ZWxfZHBfbW9kZV92YWxpZChzdHJ1Y3QgZHJtX2Nvbm5lY3Rv ciAqY29ubmVjdG9yLAo+ICAJCQlkc2Nfc2xpY2VfY291bnQgPQo+ICAJCQkJZHJtX2RwX2RzY19z aW5rX21heF9zbGljZV9jb3VudChpbnRlbF9kcC0+ZHNjX2RwY2QsCj4gIAkJCQkJCQkJdHJ1ZSk7 Cj4gLQkJfSBlbHNlIHsKPiArCQl9IGVsc2UgaWYgKGRybV9kcF9zaW5rX3N1cHBvcnRzX2ZlYyhp bnRlbF9kcC0+ZmVjX2NhcGFibGUpKSB7Cj4gIAkJCWRzY19tYXhfb3V0cHV0X2JwcCA9Cj4gIAkJ CQlpbnRlbF9kcF9kc2NfZ2V0X291dHB1dF9icHAobWF4X2xpbmtfY2xvY2ssCj4gIAkJCQkJCQkg ICAgbWF4X2xhbmVzLAo+IEBAIC0xNzEwLDEyICsxNzEwLDI3IEBAIHN0cnVjdCBsaW5rX2NvbmZp Z19saW1pdHMgewo+ICAJaW50IG1pbl9icHAsIG1heF9icHA7Cj4gIH07Cj4gIAo+ICtzdGF0aWMg Ym9vbCBpbnRlbF9kcF9zb3VyY2Vfc3VwcG9ydHNfZmVjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxf ZHAsCj4gKwkJCQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZykK PiArewo+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPSBkcF90b19kaWdf cG9ydChpbnRlbF9kcCk7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0 b19pOTE1KGRpZ19wb3J0LT5iYXNlLmJhc2UuZGV2KTsKPiArCj4gKwlyZXR1cm4gSU5URUxfR0VO KGRldl9wcml2KSA+PSAxMSAmJiBwaXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29kZXIgIT0gVFJBTlND T0RFUl9BOwo+ICt9Cj4gKwo+ICtzdGF0aWMgYm9vbCBpbnRlbF9kcF9zdXBwb3J0c19mZWMoc3Ry dWN0IGludGVsX2RwICppbnRlbF9kcCwKPiArCQkJCSAgY29uc3Qgc3RydWN0IGludGVsX2NydGNf c3RhdGUgKnBpcGVfY29uZmlnKQo+ICt7Cj4gKwlyZXR1cm4gaW50ZWxfZHBfc291cmNlX3N1cHBv cnRzX2ZlYyhpbnRlbF9kcCwgcGlwZV9jb25maWcpICYmCj4gKwkJZHJtX2RwX3Npbmtfc3VwcG9y dHNfZmVjKGludGVsX2RwLT5mZWNfY2FwYWJsZSk7Cj4gK30KPiArCj4gIHN0YXRpYyBib29sIGlu dGVsX2RwX3NvdXJjZV9zdXBwb3J0c19kc2Moc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAg CQkJCQkgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKQo+ICB7Cj4g IAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkcF90b19pOTE1KGludGVsX2Rw KTsKPiAgCj4gLQkvKiBGSVhNRTogRkVDIG5lZWRlZCBmb3IgZXh0ZXJuYWwgRFAgdW50aWwgdGhl biByZWplY3QgRFNDIG9uIERQICovCj4gIAlpZiAoIWludGVsX2RwX2lzX2VkcChpbnRlbF9kcCkp Cj4gIAkJcmV0dXJuIGZhbHNlOwoKTm8gcG9pbnQgaW4ga2VlcGluZyB0aGlzICFlZHAgY29uZGl0 aW9uIGhlcmUsIHRoYXRzIHN1cHBvc2VkIHRvIGdvIHdpdGggRkVDIGNoZWNrLAptb3ZlIHRoYXQg dG8gd2hlcmUgZmVjX3N1cHBvcnRzIGlzIGFkZGVkLgoKPiAgCj4gQEAgLTE3MjYsNiArMTc0MSw5 IEBAIHN0YXRpYyBib29sIGludGVsX2RwX3NvdXJjZV9zdXBwb3J0c19kc2Moc3RydWN0IGludGVs X2RwICppbnRlbF9kcCwKPiAgc3RhdGljIGJvb2wgaW50ZWxfZHBfc3VwcG9ydHNfZHNjKHN0cnVj dCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gIAkJCQkgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpwaXBlX2NvbmZpZykKPiAgewo+ICsJaWYgKCFwaXBlX2NvbmZpZy0+ZmVjX2VuYWJsZSkK PiArCQlyZXR1cm4gZmFsc2U7CgpJIHRoaW5rIGl0cyBiZXR0ZXIgdG8gdXNlIGludGVsX2RwX3N1 cHBvcnRzX2ZlYyhpbnRlbF9kcCwgcGlwZV9jb25maWcpICYmICFlZHAgaW5zdGVhZApvZiBwaXBl X2NvbmZpZy0+ZmVjX2VuYWJsZSBiZWNhdXNlIHBpcGVfY29uZmlnLT5mZWNfZW5hYmxlIHN0YXRl IHdpbGwgYmUgc2V0IG9ubHkgaW4gZHBfY29tcHV0ZV9jb25maWcKCj4gKwo+ICAJaWYgKCFpbnRl bF9kcF9zb3VyY2Vfc3VwcG9ydHNfZHNjKGludGVsX2RwLCBwaXBlX2NvbmZpZykgfHwKPiAgCSAg ICAhZHJtX2RwX3Npbmtfc3VwcG9ydHNfZHNjKGludGVsX2RwLT5kc2NfZHBjZCkpCj4gIAkJcmV0 dXJuIGZhbHNlOwo+IEBAIC0xODg2LDkgKzE5MDQsMTggQEAgc3RhdGljIGJvb2wgaW50ZWxfZHBf ZHNjX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gIAl1MTYgZHNj X21heF9vdXRwdXRfYnBwID0gMDsKPiAgCXU4IGRzY19kcF9zbGljZV9jb3VudCA9IDA7Cj4gIAo+ ICsJcGlwZV9jb25maWctPmZlY19lbmFibGUgPSAhaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSAm Jgo+ICsJCQkJICBpbnRlbF9kcF9zdXBwb3J0c19mZWMoaW50ZWxfZHAsIHBpcGVfY29uZmlnKTsK CldoeSBpcyBwaXBlX2NvbmZpZy0+ZmVjX2VuYWJsZSBzZXQgaW4gZHNjX2NvbXB1dGVfY29uZmln KCk/IFRoaXMgc3RhdGUgaXMgdG90YWxseSBpbmRlcGVuZWRlbnQgb2YgZHNjIHN0YXRlCmFuZCB3 ZSBhcmUgdHJlYXRpbmcgdGhpcyBhcyBhbiBpbmRlcGVuZGVudCBmZWF0dXJlLiBJIHRoaW5rIHRo ZSBlYXJsaWVyIHBsYWNlIG9mIHNldHRpbmcgdGhpcyBpbiBpbnRlbF9kcF9jb21wdXRlX2xpbmtf Y29uZmlnKCkKaXMgY29ycmVjdAoKTWFuYXNpCgo+ICsKPiAgCWlmICghaW50ZWxfZHBfc3VwcG9y dHNfZHNjKGludGVsX2RwLCBwaXBlX2NvbmZpZykpCj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAKPiAr CS8qIERTQyBub3Qgc3VwcG9ydGVkIGlmIGV4dGVybmFsIERQIHNpbmsgZG9lcyBub3Qgc3VwcG9y dCBGRUMgKi8KPiArCWlmICghcGlwZV9jb25maWctPmZlY19lbmFibGUpIHsKPiArCQlEUk1fREVC VUdfS01TKCJTaW5rIGRvZXMgbm90IHN1cHBvcnQgRm9yd2FyZCBFcnJvciBDb3JyZWN0aW9uLCBk aXNhYmxpbmcgRGlzcGxheSBDb21wcmVzc2lvblxuIik7Cj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsJ fQo+ICsKPiAgCS8qIERTQyBub3Qgc3VwcG9ydGVkIGZvciBEU0Mgc2luayBCUEMgPCA4ICovCj4g IAlpZiAobGltaXRzLT5tYXhfYnBwIDwgMyAqIERQX0RTQ19NSU5fU1VQUE9SVEVEX0JQQykgewo+ ICAJCURSTV9ERUJVR19LTVMoIk5vIERTQyBzdXBwb3J0IGZvciBsZXNzIHRoYW4gOGJwY1xuIik7 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCBkZDIyY2RlYWE2NzMuLjk5N2JlYTVm ZGYxNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTk0NSw2ICs5NDUsOSBA QCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSB7Cj4gIAkJdTggc2xpY2VfY291bnQ7Cj4gIAl9IGRz Y19wYXJhbXM7Cj4gIAlzdHJ1Y3QgZHJtX2RzY19jb25maWcgZHBfZHNjX2NmZzsKPiArCj4gKwkv KiBGb3J3YXJkIEVycm9yIGNvcnJlY3Rpb24gU3RhdGUgKi8KPiArCWJvb2wgZmVjX2VuYWJsZTsK PiAgfTsKPiAgCj4gIHN0cnVjdCBpbnRlbF9jcnRjIHsKPiAtLSAKPiAyLjE5LjEKPiAKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==