From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-rdma: Don't fail the controller if only part of the queues fail to connect
Date: Wed, 7 Nov 2018 10:07:51 +0100 [thread overview]
Message-ID: <20181107090751.GA25759@lst.de> (raw)
In-Reply-To: <67c9a957-1b61-2632-396c-3c410f6729fa@mellanox.com>
On Tue, Nov 06, 2018@01:10:27PM +0200, Max Gurtovoy wrote:
>> This sounds odd.?? Why aren't you concerned that io queues are not
>> connecting ?? Are there any log messages hinting at the failures ? any
>> way someone looking at the controller knows how many queues were actually
>> created ? ? I would assume any failure is significant and should be
>> visible, and it's worthwhile knowing whether this is a consistent failure
>> or a random failure. and what the failure was.
>
> This may happen (well it happened in the past, and fixed in the block
> layer) in case there are offline cpu's or some other reason that some queue
> is unmapped.
>
> I prefer not to relay on the block layer to ensure us 100% mapping and
> prefer be safe in our ULP.
How do we ensure we ensure any potential new block layer bug returns
-EXDEV so that your handling kicks in?
next prev parent reply other threads:[~2018-11-07 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 16:37 [PATCH] nvme-rdma: Don't fail the controller if only part of the queues fail to connect Israel Rukshin
2018-11-04 17:09 ` [Suspected-Phishing][PATCH] " Max Gurtovoy
2018-11-05 19:34 ` [PATCH] " James Smart
2018-11-06 11:10 ` Max Gurtovoy
2018-11-07 9:07 ` Christoph Hellwig [this message]
2018-11-07 18:31 ` Sagi Grimberg
2018-11-08 8:20 ` Max Gurtovoy
2018-11-08 8:37 ` Christoph Hellwig
2018-11-08 14:46 ` Max Gurtovoy
2018-11-08 14:58 ` Christoph Hellwig
2018-11-09 0:00 ` Sagi Grimberg
2018-11-09 18:55 ` James Smart
2018-11-09 21:52 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107090751.GA25759@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.