From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] of/device: Really only set bus DMA mask when appropriate Date: Wed, 7 Nov 2018 09:52:35 -0600 Message-ID: <20181107155235.GA18618@bogus> References: <20181107080335.GA24511@lst.de> <22cbe798-612f-8c88-90e7-388202f603cf@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <22cbe798-612f-8c88-90e7-388202f603cf-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Robin Murphy Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, aaro.koskinen-X3B1VOXEql0@public.gmane.org, jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org, linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Christoph Hellwig , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Wed, Nov 07, 2018 at 12:56:49PM +0000, Robin Murphy wrote: > On 2018-11-07 8:03 am, Christoph Hellwig wrote: > > On Tue, Nov 06, 2018 at 11:54:15AM +0000, Robin Murphy wrote: > > > of_dma_configure() was *supposed* to be following the same logic as > > > acpi_dma_configure() and only setting bus_dma_mask if some range was > > > specified by the firmware. However, it seems that subtlety got lost in > > > the process of fitting it into the differently-shaped control flow, and > > > as a result the force_dma==true case ends up always setting the bus mask > > > to the 32-bit default, which is not what anyone wants. > > > > > > Make sure we only touch it if the DT actually said so. > > > > This looks good, but I think it could really use a comment as the use > > of ret all the way down the function isn't exactly obvious. > > Fair point. > > > Let me now if you want this picked up through the OF or DMA trees. > > I don't mind either way; I figure I'll wait a bit longer to see if Rob has > any preference, then resend with the comment and the tags picked up so it > can hopefully make rc2. I have other fixes to send, so I can take it. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 07 Nov 2018 16:54:10 +0100 (CET) Received: from mail-ot1-f67.google.com ([209.85.210.67]:37332 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23991062AbeKGPwiFlMCo (ORCPT ); Wed, 7 Nov 2018 16:52:38 +0100 Received: by mail-ot1-f67.google.com with SMTP id 40so14944299oth.4 for ; Wed, 07 Nov 2018 07:52:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=umJZHl8PkfcYCP16RtQI+OUv5ThrkI64xEcobDoYTa0=; b=SLYk5oRKT1JBpTNQtMXkQxrms7HbbpG1Urf2fIQUTqMjKChQWQnnGzJMnpOFm+uBqK fwwvLLHK3IaTl12ZSZ2utWfJA7EZV9flgDgeidZUcq+w+SSwtsjY7Asc8EhLEW9Dm1DH kSFuX+8hrG9J2hXCYxKJPcKAsHBA+s8Xb7kRiAHqheBNYQsd5NPEeQ5GmTGCNim7u0Ym zWxKsYJaFjPKowSS8qYwxq7desKEC8xLTsnKd7Iu4mVswoAO7aU9utuyR/saO/H8DrrU 0vLml9bhCfgcpCb7QbUkob/r+Tepf/ZGM1KRqa8Ku4eNtDWHWFWIHdMGdmcWwk0UB2ot TijQ== X-Gm-Message-State: AGRZ1gLMGIoDSBTcV12tnv9pwBZ34BfipXU7MBGzZ/glPneq+O4EhDe7 lz65Rb1+NETgQp9B1gkR5Q== X-Google-Smtp-Source: AJdET5ePTBhfX51uLqN+blXIvSAZdi11LE4jWkJobuh1VcrCXjL9qw8KqGQTp60mUj8O2OIyNnsxOQ== X-Received: by 2002:a9d:4a21:: with SMTP id h30mr446223otf.280.1541605956890; Wed, 07 Nov 2018 07:52:36 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id o62-v6sm340125oia.5.2018.11.07.07.52.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Nov 2018 07:52:36 -0800 (PST) Date: Wed, 7 Nov 2018 09:52:35 -0600 From: Rob Herring To: Robin Murphy Cc: Christoph Hellwig , m.szyprowski@samsung.com, aaro.koskinen@iki.fi, jean-philippe.brucker@arm.com, john.stultz@linaro.org, iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-mips@linux-mips.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] of/device: Really only set bus DMA mask when appropriate Message-ID: <20181107155235.GA18618@bogus> References: <20181107080335.GA24511@lst.de> <22cbe798-612f-8c88-90e7-388202f603cf@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22cbe798-612f-8c88-90e7-388202f603cf@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 67132 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: robh@kernel.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Wed, Nov 07, 2018 at 12:56:49PM +0000, Robin Murphy wrote: > On 2018-11-07 8:03 am, Christoph Hellwig wrote: > > On Tue, Nov 06, 2018 at 11:54:15AM +0000, Robin Murphy wrote: > > > of_dma_configure() was *supposed* to be following the same logic as > > > acpi_dma_configure() and only setting bus_dma_mask if some range was > > > specified by the firmware. However, it seems that subtlety got lost in > > > the process of fitting it into the differently-shaped control flow, and > > > as a result the force_dma==true case ends up always setting the bus mask > > > to the 32-bit default, which is not what anyone wants. > > > > > > Make sure we only touch it if the DT actually said so. > > > > This looks good, but I think it could really use a comment as the use > > of ret all the way down the function isn't exactly obvious. > > Fair point. > > > Let me now if you want this picked up through the OF or DMA trees. > > I don't mind either way; I figure I'll wait a bit longer to see if Rob has > any preference, then resend with the comment and the tags picked up so it > can hopefully make rc2. I have other fixes to send, so I can take it. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Wed, 7 Nov 2018 09:52:35 -0600 Subject: [PATCH] of/device: Really only set bus DMA mask when appropriate In-Reply-To: <22cbe798-612f-8c88-90e7-388202f603cf@arm.com> References: <20181107080335.GA24511@lst.de> <22cbe798-612f-8c88-90e7-388202f603cf@arm.com> Message-ID: <20181107155235.GA18618@bogus> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Nov 07, 2018 at 12:56:49PM +0000, Robin Murphy wrote: > On 2018-11-07 8:03 am, Christoph Hellwig wrote: > > On Tue, Nov 06, 2018 at 11:54:15AM +0000, Robin Murphy wrote: > > > of_dma_configure() was *supposed* to be following the same logic as > > > acpi_dma_configure() and only setting bus_dma_mask if some range was > > > specified by the firmware. However, it seems that subtlety got lost in > > > the process of fitting it into the differently-shaped control flow, and > > > as a result the force_dma==true case ends up always setting the bus mask > > > to the 32-bit default, which is not what anyone wants. > > > > > > Make sure we only touch it if the DT actually said so. > > > > This looks good, but I think it could really use a comment as the use > > of ret all the way down the function isn't exactly obvious. > > Fair point. > > > Let me now if you want this picked up through the OF or DMA trees. > > I don't mind either way; I figure I'll wait a bit longer to see if Rob has > any preference, then resend with the comment and the tags picked up so it > can hopefully make rc2. I have other fixes to send, so I can take it. Rob