From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iommu/ipmmu-vmsa: Fix crash on early domain free
Date: Wed, 7 Nov 2018 17:53:36 +0100 [thread overview]
Message-ID: <20181107165336.GB19831@8bytes.org> (raw)
In-Reply-To: <f8259910-3e07-497b-9f18-6bcb47430cff@arm.com>
On Wed, Nov 07, 2018 at 04:17:09PM +0000, Robin Murphy wrote:
> FWIW it looks like it *has* always been possible to hit this crash by
> allocating a domain and freeing it again without attaching any devices, it's
> just highly improbable for any sane code to do that explicitly, so the real
> latent triggers are failure paths in external callers (which in this case
> are themselves only being reached thanks to my bug elsewhere).
Okay, given this, it probably makes more sense to change the fixes tag.
This is what I just committed:
Fixes: d25a2a16f0889 ('iommu: Add driver for Renesas VMSA-compatible IPMMU')
Regards,
Joerg
next prev parent reply other threads:[~2018-11-07 16:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 13:18 [PATCH] iommu/ipmmu-vmsa: Fix crash on early domain free Geert Uytterhoeven
[not found] ` <20181107131850.11584-1-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2018-11-07 13:22 ` Robin Murphy
2018-11-07 13:22 ` Robin Murphy
2018-11-07 15:34 ` Joerg Roedel
2018-11-07 15:50 ` Geert Uytterhoeven
2018-11-07 16:03 ` Joerg Roedel
2018-11-07 16:17 ` Robin Murphy
2018-11-07 16:53 ` Joerg Roedel [this message]
2018-11-07 16:04 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107165336.GB19831@8bytes.org \
--to=joro@8bytes.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.