From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 02/14] drm/i915: Clean up skl_program_scaler() Date: Wed, 7 Nov 2018 20:29:53 +0200 Message-ID: <20181107182953.GM9144@intel.com> References: <20181101150605.18235-3-ville.syrjala@linux.intel.com> <20181101151736.20522-1-ville.syrjala@linux.intel.com> <20181101181350.GC2092@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E2466E401 for ; Wed, 7 Nov 2018 18:29:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181101181350.GC2092@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBOb3YgMDEsIDIwMTggYXQgMTE6MTM6NTBBTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFRodSwgTm92IDAxLCAyMDE4IGF0IDA1OjE3OjM2UE0gKzAyMDAsIFZpbGxlIFN5 cmphbGEgd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+ID4gCj4gPiBSZW1vdmUgdGhlICJzaXplcyBhcmUgMCBiYXNlZCIgc3R1 ZmYgdGhhdCBpcyBub3QgZXZlbiB0cnVlIGZvciB0aGUKPiA+IHNjYWxlci4KPiA+IAo+ID4gdjI6 IFJlYmFzZQo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+IAo+IFJldmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkgPHJv ZHJpZ28udml2aUBpbnRlbC5jb20+CgpUaGFua3MuIEZpcnN0IHR3byBwYXRjaGVzIHB1c2hlZC4K Cj4gCj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyB8IDE4 ICsrKysrLS0tLS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyks IDEzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfc3ByaXRlLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ ID4gaW5kZXggMzBiNzQ4NWYxOTkyLi5hNzdhMTdmZGE2OTIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfc3ByaXRlLmMKPiA+IEBAIC0zMTAsMTIgKzMxMCwxMSBAQCBza2xfcGxhbmVf bWF4X3N0cmlkZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ID4gIH0KPiA+ICAKPiA+ICBz dGF0aWMgdm9pZAo+ID4gLXNrbF9wcm9ncmFtX3NjYWxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4gPiAtCQkgICBzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ID4gK3Nr bF9wcm9ncmFtX3NjYWxlcihzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ID4gIAkJICAgY29u c3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gPiAgCQkgICBjb25zdCBz dHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ID4gIHsKPiA+IC0JZW51bSBw bGFuZV9pZCBwbGFuZV9pZCA9IHBsYW5lLT5pZDsKPiA+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gdG9faTkxNShwbGFuZS0+YmFzZS5kZXYpOwo+ID4gIAllbnVtIHBpcGUg cGlwZSA9IHBsYW5lLT5waXBlOwo+ID4gIAlpbnQgc2NhbGVyX2lkID0gcGxhbmVfc3RhdGUtPnNj YWxlcl9pZDsKPiA+ICAJY29uc3Qgc3RydWN0IGludGVsX3NjYWxlciAqc2NhbGVyID0KPiA+IEBA IC0zMjcsMTAgKzMyNiw2IEBAIHNrbF9wcm9ncmFtX3NjYWxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4gPiAgCXUxNiB5X2hwaGFzZSwgdXZfcmdiX2hwaGFzZTsKPiA+ICAJ dTE2IHlfdnBoYXNlLCB1dl9yZ2JfdnBoYXNlOwo+ID4gIAo+ID4gLQkvKiBTaXplcyBhcmUgMCBi YXNlZCAqLwo+ID4gLQljcnRjX3ctLTsKPiA+IC0JY3J0Y19oLS07Cj4gPiAtCj4gPiAgCS8qIFRP RE86IGhhbmRsZSBzdWItcGl4ZWwgY29vcmRpbmF0ZXMgKi8KPiA+ICAJaWYgKHBsYW5lX3N0YXRl LT5iYXNlLmZiLT5mb3JtYXQtPmZvcm1hdCA9PSBEUk1fRk9STUFUX05WMTIgJiYKPiA+ICAJICAg ICFpY2xfaXNfaGRyX3BsYW5lKHBsYW5lKSkgewo+ID4gQEAgLTM1MCwxNSArMzQ1LDE0IEBAIHNr bF9wcm9ncmFtX3NjYWxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAg CX0KPiA+ICAKPiA+ICAJSTkxNV9XUklURV9GVyhTS0xfUFNfQ1RSTChwaXBlLCBzY2FsZXJfaWQp LAo+ID4gLQkJICAgICAgUFNfU0NBTEVSX0VOIHwgUFNfUExBTkVfU0VMKHBsYW5lX2lkKSB8IHNj YWxlci0+bW9kZSk7Cj4gPiArCQkgICAgICBQU19TQ0FMRVJfRU4gfCBQU19QTEFORV9TRUwocGxh bmUtPmlkKSB8IHNjYWxlci0+bW9kZSk7Cj4gPiAgCUk5MTVfV1JJVEVfRlcoU0tMX1BTX1BXUl9H QVRFKHBpcGUsIHNjYWxlcl9pZCksIDApOwo+ID4gIAlJOTE1X1dSSVRFX0ZXKFNLTF9QU19WUEhB U0UocGlwZSwgc2NhbGVyX2lkKSwKPiA+ICAJCSAgICAgIFBTX1lfUEhBU0UoeV92cGhhc2UpIHwg UFNfVVZfUkdCX1BIQVNFKHV2X3JnYl92cGhhc2UpKTsKPiA+ICAJSTkxNV9XUklURV9GVyhTS0xf UFNfSFBIQVNFKHBpcGUsIHNjYWxlcl9pZCksCj4gPiAgCQkgICAgICBQU19ZX1BIQVNFKHlfaHBo YXNlKSB8IFBTX1VWX1JHQl9QSEFTRSh1dl9yZ2JfaHBoYXNlKSk7Cj4gPiAgCUk5MTVfV1JJVEVf RlcoU0tMX1BTX1dJTl9QT1MocGlwZSwgc2NhbGVyX2lkKSwgKGNydGNfeCA8PCAxNikgfCBjcnRj X3kpOwo+ID4gLQlJOTE1X1dSSVRFX0ZXKFNLTF9QU19XSU5fU1oocGlwZSwgc2NhbGVyX2lkKSwK PiA+IC0JCSAgICAgICgoY3J0Y193ICsgMSkgPDwgMTYpfChjcnRjX2ggKyAxKSk7Cj4gPiArCUk5 MTVfV1JJVEVfRlcoU0tMX1BTX1dJTl9TWihwaXBlLCBzY2FsZXJfaWQpLCAoY3J0Y193IDw8IDE2 KSB8IGNydGNfaCk7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyB2b2lkCj4gPiBAQCAtNDQxLDEx ICs0MzUsOSBAQCBza2xfcHJvZ3JhbV9wbGFuZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ ID4gIAkJSTkxNV9XUklURV9GVyhQTEFORV9DVVNfQ1RMKHBpcGUsIHBsYW5lX2lkKSwgY3VzX2N0 bCk7Cj4gPiAgCX0KPiA+ICAKPiA+IC0JLyogcHJvZ3JhbSBwbGFuZSBzY2FsZXIgKi8KPiA+ICAJ aWYgKHBsYW5lX3N0YXRlLT5zY2FsZXJfaWQgPj0gMCkgewo+ID4gIAkJaWYgKCFzbGF2ZSkKPiA+ IC0JCQlza2xfcHJvZ3JhbV9zY2FsZXIoZGV2X3ByaXYsIHBsYW5lLAo+ID4gLQkJCQkJICAgY3J0 Y19zdGF0ZSwgcGxhbmVfc3RhdGUpOwo+ID4gKwkJCXNrbF9wcm9ncmFtX3NjYWxlcihwbGFuZSwg Y3J0Y19zdGF0ZSwgcGxhbmVfc3RhdGUpOwo+ID4gIAo+ID4gIAkJSTkxNV9XUklURV9GVyhQTEFO RV9QT1MocGlwZSwgcGxhbmVfaWQpLCAwKTsKPiA+ICAJfSBlbHNlIHsKPiA+IC0tIAo+ID4gMi4x OC4xCj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK