From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 04/14] drm/i915: Polish the skl+ plane keyval/msk/max register setup Date: Wed, 7 Nov 2018 11:55:27 -0800 Message-ID: <20181107195527.GF2237@intel.com> References: <20181101150605.18235-1-ville.syrjala@linux.intel.com> <20181101150605.18235-5-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BF926E46F for ; Wed, 7 Nov 2018 19:55:29 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181101150605.18235-5-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBOb3YgMDEsIDIwMTggYXQgMDU6MDU6NTVQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IER1ZSB0byB0aGUgY29uc3RhbnQgYWxwaGEgd2UncmUgZ29pbmcgdG8gaGF2ZSB0 byBwcm9ncmFtIHR3byBvZgo+IHRoZSB0aGUgdHJlZSBrZXlpbmcgcmVnaXN0ZXJzIGFueXdheSwg c28gbWlnaHQgYXMgd2VsbCBhbHdheXMKPiBwcm9ncmFtIGFsbCB0aHJlZS4KPiAKPiBBbmQgcGFy YW1ldHJpemUgdGhlIHBsYW5lIGNvbnN0YW50IGFscGhhIGRlZmluZSB3aGlsZSBhdCBpdC4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgoKSSdtIG5vdCAxMDAlIGNvbmZpZGVudCB3ZSBjYW4ganVzdCBpZ25vcmUgdGhlIGtl eS0+ZmxhZ3MsCmJ1dCBJIGNvdWxkbid0IGNvbnZpbmNlIG1lIHRoYXQgd2UgbmVlZCB0aGF0IGVp dGhlci4KCkFuZCBjbGVhbi11cCBieSBpdHNlbGYgbG9va3MgZ29vZCwgc286CgpSZXZpZXdlZC1i eTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKCgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICB8ICAyICstCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3Nwcml0ZS5jIHwgMjIgKysrKysrKysrLS0tLS0tLS0tLS0tLQo+ICAyIGZp bGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9yZWcuaAo+IGluZGV4IDhkMDg5ZWY4NDhiMi4uYjZlZTg2M2I1ZGYyIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gQEAgLTY1NDUsNyArNjU0NSw3IEBAIGVudW0gewo+ ICAjZGVmaW5lICBQTEFORV9LRVlNU0tfQUxQSEFfRU5BQkxFCQkoMSA8PCAzMSkKPiAgI2RlZmlu ZSBfUExBTkVfS0VZTUFYXzFfQQkJCTB4NzAxYTAKPiAgI2RlZmluZSBfUExBTkVfS0VZTUFYXzJf QQkJCTB4NzAyYTAKPiAtI2RlZmluZSAgUExBTkVfS0VZTUFYX0FMUEhBX1NISUZUCQkyNAo+ICsj ZGVmaW5lICBQTEFORV9LRVlNQVhfQUxQSEEoYSkJCQkoKGEpIDw8IDI0KQo+ICAjZGVmaW5lIF9Q TEFORV9BVVhfRElTVF8xX0EJCQkweDcwMWMwCj4gICNkZWZpbmUgX1BMQU5FX0FVWF9ESVNUXzJf QQkJCTB4NzAyYzAKPiAgI2RlZmluZSBfUExBTkVfQVVYX09GRlNFVF8xX0EJCQkweDcwMWM0Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiBpbmRleCAzOTlkNDRjNTdhN2QuLmIzNjIz ODI4MmI0ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gQEAgLTM4Miwz MSArMzgyLDI3IEBAIHNrbF9wcm9ncmFtX3BsYW5lKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUs Cj4gIAl1aW50MzJfdCBzcmNfdyA9IGRybV9yZWN0X3dpZHRoKCZwbGFuZV9zdGF0ZS0+YmFzZS5z cmMpID4+IDE2Owo+ICAJdWludDMyX3Qgc3JjX2ggPSBkcm1fcmVjdF9oZWlnaHQoJnBsYW5lX3N0 YXRlLT5iYXNlLnNyYykgPj4gMTY7Cj4gIAlzdHJ1Y3QgaW50ZWxfcGxhbmUgKmxpbmtlZCA9IHBs YW5lX3N0YXRlLT5saW5rZWRfcGxhbmU7Cj4gKwl1OCBhbHBoYSA9IHBsYW5lX3N0YXRlLT5iYXNl LmFscGhhID4+IDg7Cj4gIAl1bnNpZ25lZCBsb25nIGlycWZsYWdzOwo+IC0JdTMyIGtleW1zayA9 IDAsIGtleW1heCA9IDA7Cj4gKwl1MzIga2V5bXNrLCBrZXltYXg7Cj4gIAo+ICAJLyogU2l6ZXMg YXJlIDAgYmFzZWQgKi8KPiAgCXNyY193LS07Cj4gIAlzcmNfaC0tOwo+ICAKPiArCWtleW1heCA9 IChrZXktPm1heF92YWx1ZSAmIDB4ZmZmZmZmKSB8IFBMQU5FX0tFWU1BWF9BTFBIQShhbHBoYSk7 Cj4gKwo+ICsJa2V5bXNrID0ga2V5LT5jaGFubmVsX21hc2sgJiAweDNmZmZmZmY7Cj4gKwlpZiAo YWxwaGEgPCAweGZmKQo+ICsJCWtleW1zayB8PSBQTEFORV9LRVlNU0tfQUxQSEFfRU5BQkxFOwo+ ICsKPiAgCXNwaW5fbG9ja19pcnFzYXZlKCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ssIGlycWZsYWdz KTsKPiAgCj4gIAlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMCB8fCBJU19HRU1JTklMQUtF KGRldl9wcml2KSkKPiAgCQlJOTE1X1dSSVRFX0ZXKFBMQU5FX0NPTE9SX0NUTChwaXBlLCBwbGFu ZV9pZCksCj4gIAkJCSAgICAgIHBsYW5lX3N0YXRlLT5jb2xvcl9jdGwpOwo+ICAKPiAtCWlmIChr ZXktPmZsYWdzKSB7Cj4gLQkJSTkxNV9XUklURV9GVyhQTEFORV9LRVlWQUwocGlwZSwgcGxhbmVf aWQpLCBrZXktPm1pbl92YWx1ZSk7Cj4gLQo+IC0JCWtleW1heCB8PSBrZXktPm1heF92YWx1ZSAm IDB4ZmZmZmZmOwo+IC0JCWtleW1zayB8PSBrZXktPmNoYW5uZWxfbWFzayAmIDB4M2ZmZmZmZjsK PiAtCX0KPiAtCj4gLQlrZXltYXggfD0gKHBsYW5lX3N0YXRlLT5iYXNlLmFscGhhID4+IDgpIDw8 IFBMQU5FX0tFWU1BWF9BTFBIQV9TSElGVDsKPiAtCj4gLQlpZiAocGxhbmVfc3RhdGUtPmJhc2Uu YWxwaGEgPCAweGZmMDApCj4gLQkJa2V5bXNrIHw9IFBMQU5FX0tFWU1TS19BTFBIQV9FTkFCTEU7 Cj4gLQo+ICsJSTkxNV9XUklURV9GVyhQTEFORV9LRVlWQUwocGlwZSwgcGxhbmVfaWQpLCBrZXkt Pm1pbl92YWx1ZSk7Cj4gIAlJOTE1X1dSSVRFX0ZXKFBMQU5FX0tFWU1BWChwaXBlLCBwbGFuZV9p ZCksIGtleW1heCk7Cj4gIAlJOTE1X1dSSVRFX0ZXKFBMQU5FX0tFWU1TSyhwaXBlLCBwbGFuZV9p ZCksIGtleW1zayk7Cj4gIAo+IC0tIAo+IDIuMTguMQo+IAo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK