From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 04/14] drm/i915: Polish the skl+ plane keyval/msk/max register setup Date: Wed, 7 Nov 2018 22:56:27 +0200 Message-ID: <20181107205627.GP9144@intel.com> References: <20181101150605.18235-1-ville.syrjala@linux.intel.com> <20181101150605.18235-5-ville.syrjala@linux.intel.com> <20181107195527.GF2237@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 33D316E4BF for ; Wed, 7 Nov 2018 20:56:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181107195527.GF2237@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMDcsIDIwMTggYXQgMTE6NTU6MjdBTSAtMDgwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFRodSwgTm92IDAxLCAyMDE4IGF0IDA1OjA1OjU1UE0gKzAyMDAsIFZpbGxlIFN5 cmphbGEgd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+ID4gCj4gPiBEdWUgdG8gdGhlIGNvbnN0YW50IGFscGhhIHdlJ3JlIGdv aW5nIHRvIGhhdmUgdG8gcHJvZ3JhbSB0d28gb2YKPiA+IHRoZSB0aGUgdHJlZSBrZXlpbmcgcmVn aXN0ZXJzIGFueXdheSwgc28gbWlnaHQgYXMgd2VsbCBhbHdheXMKPiA+IHByb2dyYW0gYWxsIHRo cmVlLgo+ID4gCj4gPiBBbmQgcGFyYW1ldHJpemUgdGhlIHBsYW5lIGNvbnN0YW50IGFscGhhIGRl ZmluZSB3aGlsZSBhdCBpdC4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBJJ20gbm90IDEwMCUgY29uZmlk ZW50IHdlIGNhbiBqdXN0IGlnbm9yZSB0aGUga2V5LT5mbGFncywKPiBidXQgSSBjb3VsZG4ndCBj b252aW5jZSBtZSB0aGF0IHdlIG5lZWQgdGhhdCBlaXRoZXIuCgpUaGUgY29sb3JrZXkgcmVnaXN0 ZXJzIHNob3VsZCBiZSBub3BzIHVubGVzcyB3ZSBlbmFibGUgdGhlIHJlbGV2YW50IGJpdHMKaW4g dGhlIGNvbnRyb2wgcmVnaXN0ZXIgKHNrbF9wbGFuZV9jdGwoKSkuIElmIG5vdCB3ZSdkIGFscmVh ZHkgaGF2ZSBhCmJ1ZyBiZWNhdXNlIHdlIHdlcmUgbGVhdmluZyBzdGFsZSB2YWx1ZXMgaW4gdGhv c2UgcmVnaXN0ZXJzIHdoZW4KY29sb3JrZXlpbmcgd2FzIG5vdCBlbmFibGVkLgoKPiAKPiBBbmQg Y2xlYW4tdXAgYnkgaXRzZWxmIGxvb2tzIGdvb2QsIHNvOgo+IAo+IFJldmlld2VkLWJ5OiBSb2Ry aWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gCj4gCj4gCj4gPiAtLS0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICB8ICAyICstCj4gPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgfCAyMiArKysrKysrKystLS0tLS0tLS0tLS0tCj4g PiAgMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKPiA+ IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gPiBpbmRleCA4ZDA4OWVmODQ4YjIuLmI2ZWU4 NjNiNWRmMiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgK PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+IEBAIC02NTQ1LDcg KzY1NDUsNyBAQCBlbnVtIHsKPiA+ICAjZGVmaW5lICBQTEFORV9LRVlNU0tfQUxQSEFfRU5BQkxF CQkoMSA8PCAzMSkKPiA+ICAjZGVmaW5lIF9QTEFORV9LRVlNQVhfMV9BCQkJMHg3MDFhMAo+ID4g ICNkZWZpbmUgX1BMQU5FX0tFWU1BWF8yX0EJCQkweDcwMmEwCj4gPiAtI2RlZmluZSAgUExBTkVf S0VZTUFYX0FMUEhBX1NISUZUCQkyNAo+ID4gKyNkZWZpbmUgIFBMQU5FX0tFWU1BWF9BTFBIQShh KQkJCSgoYSkgPDwgMjQpCj4gPiAgI2RlZmluZSBfUExBTkVfQVVYX0RJU1RfMV9BCQkJMHg3MDFj MAo+ID4gICNkZWZpbmUgX1BMQU5FX0FVWF9ESVNUXzJfQQkJCTB4NzAyYzAKPiA+ICAjZGVmaW5l IF9QTEFORV9BVVhfT0ZGU0VUXzFfQQkJCTB4NzAxYzQKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3Nwcml0ZS5jCj4gPiBpbmRleCAzOTlkNDRjNTdhN2QuLmIzNjIzODI4MmI0ZSAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ID4gQEAgLTM4MiwzMSArMzgyLDI3IEBA IHNrbF9wcm9ncmFtX3BsYW5lKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gPiAgCXVpbnQz Ml90IHNyY193ID0gZHJtX3JlY3Rfd2lkdGgoJnBsYW5lX3N0YXRlLT5iYXNlLnNyYykgPj4gMTY7 Cj4gPiAgCXVpbnQzMl90IHNyY19oID0gZHJtX3JlY3RfaGVpZ2h0KCZwbGFuZV9zdGF0ZS0+YmFz ZS5zcmMpID4+IDE2Owo+ID4gIAlzdHJ1Y3QgaW50ZWxfcGxhbmUgKmxpbmtlZCA9IHBsYW5lX3N0 YXRlLT5saW5rZWRfcGxhbmU7Cj4gPiArCXU4IGFscGhhID0gcGxhbmVfc3RhdGUtPmJhc2UuYWxw aGEgPj4gODsKPiA+ICAJdW5zaWduZWQgbG9uZyBpcnFmbGFnczsKPiA+IC0JdTMyIGtleW1zayA9 IDAsIGtleW1heCA9IDA7Cj4gPiArCXUzMiBrZXltc2ssIGtleW1heDsKPiA+ICAKPiA+ICAJLyog U2l6ZXMgYXJlIDAgYmFzZWQgKi8KPiA+ICAJc3JjX3ctLTsKPiA+ICAJc3JjX2gtLTsKPiA+ICAK PiA+ICsJa2V5bWF4ID0gKGtleS0+bWF4X3ZhbHVlICYgMHhmZmZmZmYpIHwgUExBTkVfS0VZTUFY X0FMUEhBKGFscGhhKTsKPiA+ICsKPiA+ICsJa2V5bXNrID0ga2V5LT5jaGFubmVsX21hc2sgJiAw eDNmZmZmZmY7Cj4gPiArCWlmIChhbHBoYSA8IDB4ZmYpCj4gPiArCQlrZXltc2sgfD0gUExBTkVf S0VZTVNLX0FMUEhBX0VOQUJMRTsKPiA+ICsKPiA+ICAJc3Bpbl9sb2NrX2lycXNhdmUoJmRldl9w cml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+ID4gIAo+ID4gIAlpZiAoSU5URUxfR0VOKGRl dl9wcml2KSA+PSAxMCB8fCBJU19HRU1JTklMQUtFKGRldl9wcml2KSkKPiA+ICAJCUk5MTVfV1JJ VEVfRlcoUExBTkVfQ09MT1JfQ1RMKHBpcGUsIHBsYW5lX2lkKSwKPiA+ICAJCQkgICAgICBwbGFu ZV9zdGF0ZS0+Y29sb3JfY3RsKTsKPiA+ICAKPiA+IC0JaWYgKGtleS0+ZmxhZ3MpIHsKPiA+IC0J CUk5MTVfV1JJVEVfRlcoUExBTkVfS0VZVkFMKHBpcGUsIHBsYW5lX2lkKSwga2V5LT5taW5fdmFs dWUpOwo+ID4gLQo+ID4gLQkJa2V5bWF4IHw9IGtleS0+bWF4X3ZhbHVlICYgMHhmZmZmZmY7Cj4g PiAtCQlrZXltc2sgfD0ga2V5LT5jaGFubmVsX21hc2sgJiAweDNmZmZmZmY7Cj4gPiAtCX0KPiA+ IC0KPiA+IC0Ja2V5bWF4IHw9IChwbGFuZV9zdGF0ZS0+YmFzZS5hbHBoYSA+PiA4KSA8PCBQTEFO RV9LRVlNQVhfQUxQSEFfU0hJRlQ7Cj4gPiAtCj4gPiAtCWlmIChwbGFuZV9zdGF0ZS0+YmFzZS5h bHBoYSA8IDB4ZmYwMCkKPiA+IC0JCWtleW1zayB8PSBQTEFORV9LRVlNU0tfQUxQSEFfRU5BQkxF Owo+ID4gLQo+ID4gKwlJOTE1X1dSSVRFX0ZXKFBMQU5FX0tFWVZBTChwaXBlLCBwbGFuZV9pZCks IGtleS0+bWluX3ZhbHVlKTsKPiA+ICAJSTkxNV9XUklURV9GVyhQTEFORV9LRVlNQVgocGlwZSwg cGxhbmVfaWQpLCBrZXltYXgpOwo+ID4gIAlJOTE1X1dSSVRFX0ZXKFBMQU5FX0tFWU1TSyhwaXBl LCBwbGFuZV9pZCksIGtleW1zayk7Cj4gPiAgCj4gPiAtLSAKPiA+IDIuMTguMQo+ID4gCj4gPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4g aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK Ci0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==