From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 12/14] drm/i915: Remove some useless zeroing on skl+ wm calculations Date: Wed, 7 Nov 2018 14:11:10 -0800 Message-ID: <20181107221110.GO2237@intel.com> References: <20181101150605.18235-1-ville.syrjala@linux.intel.com> <20181101150605.18235-13-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28FFD6E526 for ; Wed, 7 Nov 2018 22:11:20 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181101150605.18235-13-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIFRodSwgTm92IDAxLCAyMDE4IGF0IDA1OjA2OjAzUE0gKzAyMDAsIFZpbGxlIFN5cmphbGEg d3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiAKPiBXZSBtZW1zZXQoMCkgdGhlIGVudGlyZSB3YXRlcm1hcmsgc3RydWN0IHRoZSBz dGFydCwgc28gdGhlcmUncyBubwo+IG5lZWQgdG8gY2xlYXIgdGhpbmdzIGxhdGVyIG9uLgo+IAo+ IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAyMCArKysr Ky0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxNSBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBpbmRleCBiZDVmMTZiYzdl MDguLmIwNzIwOTk0ZmEwYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IEBAIC00NzA2 LDEwICs0NzA2LDggQEAgc3RhdGljIGludCBza2xfY29tcHV0ZV9wbGFuZV93bShjb25zdCBzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAlpZiAobGF0ZW5jeSA9PSAwKQo+ICAJ CXJldHVybiBsZXZlbCA9PSAwID8gLUVJTlZBTCA6IDA7Cj4gIAo+IC0JaWYgKCFpbnRlbF93bV9w bGFuZV92aXNpYmxlKGNzdGF0ZSwgaW50ZWxfcHN0YXRlKSkgewo+IC0JCXJlc3VsdC0+cGxhbmVf ZW4gPSBmYWxzZTsKPiArCWlmICghaW50ZWxfd21fcGxhbmVfdmlzaWJsZShjc3RhdGUsIGludGVs X3BzdGF0ZSkpCj4gIAkJcmV0dXJuIDA7Cj4gLQl9Cj4gIAo+ICAJLyogRGlzcGxheSBXQSAjMTE0 MToga2JsLGNmbCAqLwo+ICAJaWYgKChJU19LQUJZTEFLRShkZXZfcHJpdikgfHwgSVNfQ09GRkVF TEFLRShkZXZfcHJpdikgfHwKPiBAQCAtNDgwNiw4ICs0ODA0LDYgQEAgc3RhdGljIGludCBza2xf Y29tcHV0ZV9wbGFuZV93bShjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs Cj4gIAlpZiAoKGxldmVsID4gMCAmJiByZXNfbGluZXMgPiAzMSkgfHwKPiAgCSAgICByZXNfYmxv Y2tzID49IGRkYl9hbGxvY2F0aW9uIHx8Cj4gIAkgICAgbWluX2Rpc3BfYnVmX25lZWRlZCA+PSBk ZGJfYWxsb2NhdGlvbikgewo+IC0JCXJlc3VsdC0+cGxhbmVfZW4gPSBmYWxzZTsKPiAtCj4gIAkJ LyoKPiAgCQkgKiBJZiB0aGVyZSBhcmUgbm8gdmFsaWQgbGV2ZWwgMCB3YXRlcm1hcmtzLCB0aGVu IHdlIGNhbid0Cj4gIAkJICogc3VwcG9ydCB0aGlzIGRpc3BsYXkgY29uZmlndXJhdGlvbi4KPiBA QCAtNDgzMSwxMCArNDgyNyw4IEBAIHN0YXRpYyBpbnQgc2tsX2NvbXB1dGVfcGxhbmVfd20oY29u c3Qgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJICovCj4gIAlpZiAod3At PmlzX3BsYW5hciAmJiBsZXZlbCA+PSAxICYmCj4gIAkgICAgKElTX1NLWUxBS0UoZGV2X3ByaXYp IHx8IElTX0JST1hUT04oZGV2X3ByaXYpIHx8Cj4gLQkgICAgIElTX0NOTF9SRVZJRChkZXZfcHJp diwgQ05MX1JFVklEX0EwLCBDTkxfUkVWSURfQTApKSkgewo+IC0JCXJlc3VsdC0+cGxhbmVfZW4g PSBmYWxzZTsKPiArCSAgICAgSVNfQ05MX1JFVklEKGRldl9wcml2LCBDTkxfUkVWSURfQTAsIENO TF9SRVZJRF9BMCkpKQoKdGhpcyByZW1pbmRzIG1lIHRoYXQgSSBwcm9iYWJseSBmb3Jnb3Qgb25l IHBhdGNoIGJlaGluZCBzb21ld2hlcmUuLi4KCgpSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxy b2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKCj4gIAkJcmV0dXJuIDA7Cj4gLQl9Cj4gIAo+ICAJLyog VGhlIG51bWJlciBvZiBsaW5lcyBhcmUgaWdub3JlZCBmb3IgdGhlIGxldmVsIDAgd2F0ZXJtYXJr LiAqLwo+ICAJcmVzdWx0LT5wbGFuZV9yZXNfYiA9IHJlc19ibG9ja3M7Cj4gQEAgLTQ5MjAsMTUg KzQ5MTQsMTUgQEAgc3RhdGljIHZvaWQgc2tsX2NvbXB1dGVfdHJhbnNpdGlvbl93bShjb25zdCBz dHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3N0YXRlLAo+ICAJdWludDE2X3Qgd20wX3NlbF9yZXNf YiwgdHJhbnNfb2Zmc2V0X2IsIHJlc19ibG9ja3M7Cj4gIAo+ICAJaWYgKCFjc3RhdGUtPmJhc2Uu YWN0aXZlKQo+IC0JCWdvdG8gZXhpdDsKPiArCQlyZXR1cm47Cj4gIAo+ICAJLyogVHJhbnNpdGlv biBXTSBhcmUgbm90IHJlY29tbWVuZGVkIGJ5IEhXIHRlYW0gZm9yIEdFTjkgKi8KPiAgCWlmIChJ TlRFTF9HRU4oZGV2X3ByaXYpIDw9IDkpCj4gLQkJZ290byBleGl0Owo+ICsJCXJldHVybjsKPiAg Cj4gIAkvKiBUcmFuc2l0aW9uIFdNIGRvbid0IG1ha2UgYW55IHNlbnNlIGlmIGlwYyBpcyBkaXNh YmxlZCAqLwo+ICAJaWYgKCFkZXZfcHJpdi0+aXBjX2VuYWJsZWQpCj4gLQkJZ290byBleGl0Owo+ ICsJCXJldHVybjsKPiAgCj4gIAl0cmFuc19taW4gPSAxNDsKPiAgCWlmIChJTlRFTF9HRU4oZGV2 X3ByaXYpID49IDExKQo+IEBAIC00OTY3LDExICs0OTYxLDcgQEAgc3RhdGljIHZvaWQgc2tsX2Nv bXB1dGVfdHJhbnNpdGlvbl93bShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3N0YXRl LAo+ICAJaWYgKHJlc19ibG9ja3MgPCBkZGJfYWxsb2NhdGlvbikgewo+ICAJCXRyYW5zX3dtLT5w bGFuZV9yZXNfYiA9IHJlc19ibG9ja3M7Cj4gIAkJdHJhbnNfd20tPnBsYW5lX2VuID0gdHJ1ZTsK PiAtCQlyZXR1cm47Cj4gIAl9Cj4gLQo+IC1leGl0Ogo+IC0JdHJhbnNfd20tPnBsYW5lX2VuID0g ZmFsc2U7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgX19za2xfYnVpbGRfcGxhbmVfd21fc2luZ2xl KHN0cnVjdCBza2xfZGRiX2FsbG9jYXRpb24gKmRkYiwKPiAtLSAKPiAyLjE4LjEKPiAKPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBt YWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==