From: Greg KH <greg@kroah.com>
To: tungolcild@gmail.com
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] Re: [PATCH 00/15] staging: greybus: fix various coding style issues
Date: Thu, 8 Nov 2018 01:00:20 +0100 [thread overview]
Message-ID: <20181108000020.GA28675@kroah.com> (raw)
In-Reply-To: <a0685897-c32d-47de-a6a7-0c0c5344febe@googlegroups.com>
On Wed, Nov 07, 2018 at 09:48:03AM -0800, tungolcild@gmail.com wrote:
> On Wednesday, November 7, 2018 at 11:17:52 AM UTC, gregkh wrote:
> >
> > On Tue, Nov 06, 2018 at 01:04:06AM +0000, Ioannis Valasakis wrote:
> > > Fix various coding style issues reported by reportcheck, uncrustify and
> > > coccinelle.
> > >
> > > Ioannis Valasakis (15):
> > > staging: greybus: shorten comparison to NULL
> > > staging: greybus: align parameters to parentheses
> > > staging: greybus: add a blank line after declaration
> > > staging: greybus: fix SPDX License Identifier
> > > greybus: staging: align arguments with parentheses
> >
> > Looks like your subject got switched around here.
> >
> > Again, doing a review of your email before sending it out is very good.
> >
> > v2?
> >
> > thanks,
> >
> > greg k-h
> >
>
> thanks greg! probably it's due to my misunderstanding but this patch series
> wasn't the same
> as before (as I've added a few commits). So I didn't consider it a
> continuation that's why I re-edited
> the code and added new subject lines/commits. Was that wrong? I am going to
> do a v2 if needed, just
> need to understand :)
Sorry for not being explicit, you did this correctly, except for that
one patch with the subject line a bit messed up.
I was _asking_ for a v2 series to be sent to fix this up, so that I can
accept these patches. Can you do that please?
thanks,
greg k-h
prev parent reply other threads:[~2018-11-08 0:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 1:04 [PATCH 00/15] staging: greybus: fix various coding style issues Ioannis Valasakis
2018-11-06 1:04 ` [PATCH 01/15] staging: greybus: shorten comparison to NULL Ioannis Valasakis
2018-11-06 1:04 ` [PATCH 02/15] staging: greybus: align parameters to parentheses Ioannis Valasakis
2018-11-06 1:04 ` [PATCH 03/15] staging: greybus: add a blank line after declaration Ioannis Valasakis
2018-11-06 1:04 ` [PATCH 04/15] staging: greybus: fix SPDX License Identifier Ioannis Valasakis
2018-11-06 1:04 ` [PATCH 05/15] greybus: staging: align arguments with parentheses Ioannis Valasakis
2018-11-06 1:05 ` [PATCH 06/15] staging: greybus: correct SPDX License Identifier Ioannis Valasakis
2018-11-06 1:05 ` [PATCH 07/15] staging: greybus: remove multiple blank lines Ioannis Valasakis
2018-11-06 1:05 ` [PATCH 08/15] staging: greybus: insert empty line after struct Ioannis Valasakis
2018-11-06 1:05 ` [PATCH 09/15] staging: greybus: remove space before tab Ioannis Valasakis
2018-11-06 1:05 ` [PATCH 10/15] staging: greybus: remove multiple blank lines Ioannis Valasakis
2018-11-06 1:05 ` [PATCH 11/15] staging: greybus: add extra space around OR operator Ioannis Valasakis
2018-11-06 1:05 ` [PATCH 12/15] staging: greybus: remove extra space before tab Ioannis Valasakis
2018-11-06 1:05 ` [PATCH 13/15] staging: greybus: correct SPDX license identifiers Ioannis Valasakis
2018-11-06 1:05 ` [PATCH 14/15] staging: greybus: remove comparison to BOOL Ioannis Valasakis
2018-11-06 1:06 ` [PATCH 15/15] staging: greybus: remove unmatched right bracket Ioannis Valasakis
2018-11-07 11:17 ` [PATCH 00/15] staging: greybus: fix various coding style issues Greg KH
2018-11-07 17:48 ` tungolcild
2018-11-08 0:00 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108000020.GA28675@kroah.com \
--to=greg@kroah.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=tungolcild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.