From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH v2 04/11] nvmet: Make kato and AEN processing for use by other controllers
Date: Thu, 8 Nov 2018 01:53:41 -0800 [thread overview]
Message-ID: <20181108095341.GD29432@infradead.org> (raw)
In-Reply-To: <1539709883-12424-5-git-send-email-jay.e.sternberg@intel.com>
On Tue, Oct 16, 2018@10:11:16AM -0700, Jay Sternberg wrote:
> Make common process of get/set features available to other controllers by
> making simple functions static inline and others not static and prototypes
> in nvmet.h file
>
> Also remove static from nvmet_execute_async_event and add prototype to
> nvmet.h to allow used by other controllers
I'd move nvmet_get_feat_kato and nvmet_get_feat_async_event out of
line, just to not bloat the header with too much random sprinkled
implementation bits, given none of this is timing critical.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2018-11-08 9:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 17:11 [PATCH v2 00/11] nvmet: Enable AENs support for Discovery controllers Jay Sternberg
2018-10-16 17:11 ` [PATCH v2 01/11] nvmet: Provide aen bit functions for multiple controller types Jay Sternberg
2018-11-08 9:49 ` Christoph Hellwig
2018-10-16 17:11 ` [PATCH v2 02/11] nvmet: Change aen mask functions to use bit numbers Jay Sternberg
2018-11-08 9:50 ` Christoph Hellwig
2018-10-16 17:11 ` [PATCH v2 03/11] nvmet: Allow Keep Alive for Discovery controller Jay Sternberg
2018-11-08 9:52 ` Christoph Hellwig
2018-10-16 17:11 ` [PATCH v2 04/11] nvmet: Make kato and AEN processing for use by other controllers Jay Sternberg
2018-11-08 9:53 ` Christoph Hellwig [this message]
2018-10-16 17:11 ` [PATCH v2 05/11] nvmet: Add defines for discovery change async events Jay Sternberg
2018-11-08 9:54 ` Christoph Hellwig
2018-11-08 9:54 ` Christoph Hellwig
2018-10-16 17:11 ` [PATCH v2 06/11] nvmet: Add support to Discovery controllers for commands Jay Sternberg
2018-11-08 9:54 ` Christoph Hellwig
2018-10-16 17:11 ` [PATCH v2 07/11] nvmet: Add parent to nvmet_referral_disable Jay Sternberg
2018-11-08 9:55 ` Christoph Hellwig
2018-10-16 17:11 ` [PATCH v2 08/11] nvmet: Maintain a global list of ports Jay Sternberg
2018-11-08 9:56 ` Christoph Hellwig
2018-10-16 17:11 ` [PATCH v2 09/11] nvmet: allow host connect even if no allowed Jay Sternberg
2018-11-08 9:58 ` Christoph Hellwig
2018-10-16 17:11 ` [PATCH v2 10/11] nvmet: Provide adding AENs for multiple controller types Jay Sternberg
2018-11-08 9:58 ` Christoph Hellwig
2018-10-16 17:11 ` [PATCH v2 11/11] nvmet: Enable Discovery Controller AENs Jay Sternberg
2018-11-08 10:03 ` Christoph Hellwig
2018-10-31 5:01 ` [PATCH v2 00/11] nvmet: Enable AENs support for Discovery controllers Sagi Grimberg
2018-11-01 6:05 ` Christoph Hellwig
2018-11-01 15:57 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108095341.GD29432@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.