From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Alexander Graf <agraf@suse.de>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>,
=Collin Walling <walling@linux.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v1 4/4] s390x/zpci: properly fail if the zPCI device cannot be created
Date: Thu, 8 Nov 2018 12:14:46 +0100 [thread overview]
Message-ID: <20181108121446.4f1d09dc.cohuck@redhat.com> (raw)
In-Reply-To: <b38c2f96-46ed-db0f-86b7-dc458ac80ee8@redhat.com>
On Mon, 5 Nov 2018 13:46:10 +0100
David Hildenbrand <david@redhat.com> wrote:
> On 05.11.18 13:41, Cornelia Huck wrote:
> > On Mon, 5 Nov 2018 13:04:04 +0100
> > Thomas Huth <thuth@redhat.com> wrote:
> >
> >> On 2018-11-05 12:03, David Hildenbrand wrote:
> >>> Right now, errors during realize()/pre_plug/plug of the zPCI device
> >>> would result in QEMU crashing instead of failing nicely when creating
> >>> a zPCI device for a PCI device.
> >
> > Yeah, failing instead of crashing is better :)
> >
> > Is there any way we can trigger this problem for testing?
>
> I guess trying to add more PCI devices (with implicit zPCI devices
> getting created) than we have zPCI slots should be enough. So making
> e.g. s390_pci_alloc_idx() fail.
>
> (FH_MASK_INDEX = 0x0000ffff implies 65536 devices, which is not really
> easy to test ;) )
>
I was hoping for an easy test. Oh well :)
next prev parent reply other threads:[~2018-11-08 11:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 11:03 [Qemu-devel] [PATCH v1 0/4] s390x/zpci: some hotplug handler cleanups David Hildenbrand
2018-11-05 11:03 ` [Qemu-devel] [PATCH v1 1/4] s390x/zpci: drop msix.available David Hildenbrand
2018-11-05 11:19 ` Cornelia Huck
2018-11-07 16:26 ` [Qemu-devel] [qemu-s390x] " Collin Walling
2018-11-08 10:54 ` Cornelia Huck
2018-11-05 11:25 ` [Qemu-devel] " Thomas Huth
2018-11-12 17:12 ` Cornelia Huck
2018-11-05 11:03 ` [Qemu-devel] [PATCH v1 2/4] s390x/zpci: use hotplug_dev instead of looking up the host bridge David Hildenbrand
2018-11-05 11:21 ` Cornelia Huck
2018-11-05 11:37 ` David Hildenbrand
2018-11-05 11:40 ` Christian Borntraeger
2018-11-05 11:50 ` David Hildenbrand
2018-11-07 20:28 ` Collin Walling
2018-11-08 11:07 ` Cornelia Huck
2018-11-08 11:56 ` David Hildenbrand
2018-11-05 11:03 ` [Qemu-devel] [PATCH v1 3/4] s390x/zpci: move some hotplug checks to the pre_plug handler David Hildenbrand
2018-11-05 11:50 ` David Hildenbrand
2018-11-07 19:34 ` [Qemu-devel] [qemu-s390x] " Collin Walling
2018-11-07 19:36 ` David Hildenbrand
2018-11-07 19:46 ` Collin Walling
2018-11-05 11:03 ` [Qemu-devel] [PATCH v1 4/4] s390x/zpci: properly fail if the zPCI device cannot be created David Hildenbrand
2018-11-05 12:04 ` Thomas Huth
2018-11-05 12:41 ` Cornelia Huck
2018-11-05 12:46 ` David Hildenbrand
2018-11-08 11:14 ` Cornelia Huck [this message]
2018-11-07 20:15 ` Collin Walling
2018-11-08 13:35 ` Cornelia Huck
2018-11-08 13:58 ` David Hildenbrand
2018-11-12 17:14 ` [Qemu-devel] [PATCH v1 0/4] s390x/zpci: some hotplug handler cleanups Cornelia Huck
2018-11-12 17:34 ` David Hildenbrand
2018-11-13 9:03 ` Cornelia Huck
2018-11-13 12:06 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108121446.4f1d09dc.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.