From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 01/10] target/tcmu: Fix queue_cmd_ring() declaration
Date: Thu, 08 Nov 2018 11:56:04 +0000 [thread overview]
Message-ID: <20181108125604.23af996b@suse.de> (raw)
In-Reply-To: <20181106171718.89594-2-bvanassche@acm.org>
On Tue, 6 Nov 2018 09:17:09 -0800, Bart Van Assche wrote:
...
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -958,7 +958,7 @@ static int add_to_cmdr_queue(struct tcmu_cmd *tcmu_cmd)
> * 0 success
> * 1 internally queued to wait for ring memory to free.
> */
> -static sense_reason_t queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, int *scsi_err)
> +static int queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, sense_reason_t *scsi_err)
> {
> struct tcmu_dev *udev = tcmu_cmd->tcmu_dev;
> struct se_cmd *se_cmd = tcmu_cmd->se_cmd;
Looks good.
Reviewed-by: David Disseldorp <ddiss@suse.de>
prev parent reply other threads:[~2018-11-08 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 17:17 [PATCH 01/10] target/tcmu: Fix queue_cmd_ring() declaration Bart Van Assche
2018-11-08 11:56 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108125604.23af996b@suse.de \
--to=ddiss@suse.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.