From: Christoph Hellwig <hch@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Mike Snitzer <msnitzer@redhat.com>,
dm-devel@redhat.com, "Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: [patch 5/5] block: use a driver-specific handler for the "inflight" value
Date: Thu, 8 Nov 2018 06:52:40 -0800 [thread overview]
Message-ID: <20181108145240.GA20087@infradead.org> (raw)
In-Reply-To: <20181106213858.391264280@debian-a64.vm>
On Tue, Nov 06, 2018 at 10:35:03PM +0100, Mikulas Patocka wrote:
> Device mapper was converted to percpu inflight counters. In order to
> display the correct values in the "inflight" sysfs file, we need a custom
> callback that sums the percpu counters.
The attribute that calls this is per-partition, while your method
is per-queue, so there is some impedence mismatch here.
Is there any way you could look into just making the generic code
use percpu counters?
Also please cc linux-block on patches that touch the generic block
code.
next prev parent reply other threads:[~2018-11-08 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 21:35 [patch 5/5] block: use a driver-specific handler for the "inflight" value Mikulas Patocka
2018-11-08 14:52 ` Christoph Hellwig [this message]
2018-11-08 17:07 ` Mike Snitzer
2018-11-08 17:07 ` Mike Snitzer
2018-11-14 15:18 ` Christoph Hellwig
2018-11-14 15:18 ` Christoph Hellwig
2018-11-14 15:34 ` Mike Snitzer
2018-11-14 15:34 ` Mike Snitzer
2018-11-14 22:49 ` Mikulas Patocka
2018-11-14 22:49 ` Mikulas Patocka
2018-11-14 22:35 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108145240.GA20087@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
--cc=msnitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.