From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Yi Wang <wang.yi59@zte.com.cn>, Michael Matz <matz@suse.de>,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
suravee.suthikulpanit@amd.com, puwen@hygon.cn,
davidwang@zhaoxin.com, linux-kernel@vger.kernel.org,
zhong.weidong@zte.com.cn
Subject: Re: [PATCH v2] x86/cpu: fix prototype warning
Date: Thu, 8 Nov 2018 16:41:21 +0100 [thread overview]
Message-ID: <20181108154121.GG7543@zn.tnic> (raw)
In-Reply-To: <alpine.DEB.2.21.1811081633160.1549@nanos.tec.linutronix.de>
On Thu, Nov 08, 2018 at 04:35:45PM +0100, Thomas Gleixner wrote:
> Global function declarations must have a prototype definition, really.
>
> Otherwise you can change the function signature and all callers which use
> the old unchanged prototype are hosed.
Ok, should we then enable this warning by default?
It is an extra warning now, behind W=1.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-11-08 15:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 1:12 [PATCH v2] x86/cpu: fix prototype warning Yi Wang
2018-11-08 15:03 ` Borislav Petkov
2018-11-08 15:32 ` Borislav Petkov
2018-11-08 15:35 ` Thomas Gleixner
2018-11-08 15:41 ` Borislav Petkov [this message]
2018-11-09 16:07 ` David Laight
2018-11-10 10:51 ` [tip:ras/core] x86/mce: Fix -Wmissing-prototypes warnings tip-bot for Borislav Petkov
2018-11-10 14:16 ` Borislav Petkov
2018-11-12 5:24 ` Ingo Molnar
2018-11-12 12:19 ` Borislav Petkov
2018-11-13 14:22 ` [tip:x86/cleanups] x86/traps: Complete prototype declarations tip-bot for Borislav Petkov
2018-11-14 13:19 ` tip-bot for Borislav Petkov
2018-11-13 14:21 ` [tip:x86/cleanups] x86/mce: Fix -Wmissing-prototypes warnings tip-bot for Borislav Petkov
2018-11-14 13:18 ` tip-bot for Borislav Petkov
2018-11-08 15:47 ` [PATCH v2] x86/cpu: fix prototype warning Michael Matz
2018-11-08 17:22 ` Borislav Petkov
[not found] ` <201811090843126464658@zte.com.cn>
2018-11-09 10:55 ` Borislav Petkov
2018-11-09 11:12 ` Greg KH
2018-11-09 11:41 ` Borislav Petkov
2018-11-09 12:25 ` Greg KH
2018-11-09 22:17 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108154121.GG7543@zn.tnic \
--to=bp@alien8.de \
--cc=davidwang@zhaoxin.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matz@suse.de \
--cc=mingo@redhat.com \
--cc=puwen@hygon.cn \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=wang.yi59@zte.com.cn \
--cc=x86@kernel.org \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.