All of lore.kernel.org
 help / color / mirror / Atom feed
From: snitzer@redhat.com (Mike Snitzer)
Subject: nvme: make ANA support independent on native nvme multipath
Date: Thu, 8 Nov 2018 11:24:56 -0500	[thread overview]
Message-ID: <20181108162456.GA28854@redhat.com> (raw)
In-Reply-To: <20181105154136.142597-1-hare@suse.de>

On Mon, Nov 05 2018 at 10:41am -0500,
Hannes Reinecke <hare@suse.de> wrote:

> NVMe native multipathing is an implementation detail on the host,
> and ANA support is actually independent on that.
> So we shouldn't check for native NVMe multipathing when trying to
> evaluate whether ANA is supported; not doing so results in the
> ANA sysfs attributes not to be present when the 'multipath=false'
> module option is set.
> 
> Signed-off-by: Hannes Reinecke <hare at suse.com>
> ---
>  drivers/nvme/host/multipath.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
> index 4944ffdf6831..f7efcaeb2d98 100644
> --- a/drivers/nvme/host/multipath.c
> +++ b/drivers/nvme/host/multipath.c
> @@ -22,7 +22,7 @@ MODULE_PARM_DESC(multipath,
>  
>  inline bool nvme_ctrl_use_ana(struct nvme_ctrl *ctrl)
>  {
> -	return multipath && ctrl->subsys && (ctrl->subsys->cmic & (1 << 3));
> +	return ctrl->subsys && (ctrl->subsys->cmic & (1 << 3));
>  }
>  
>  /*
> -- 
> 2.16.4
> 

So you're going for ANA to work with CONFIG_NVME_MULTIPATH=Y but
nvme_core.multipath=N

Yes please.

Acked-by: Mike Snitzer <snitzer at redhat.com>

      parent reply	other threads:[~2018-11-08 16:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05 15:41 [PATCH] nvme: make ANA support independent on native nvme multipath Hannes Reinecke
2018-11-07  2:54 ` Sagi Grimberg
2018-11-08  8:48 ` Christoph Hellwig
2018-11-08 16:27   ` Mike Snitzer
2018-11-08 16:24 ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108162456.GA28854@redhat.com \
    --to=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.